Removing some unnecessary string manipulation code from VoEBase::GetVersion().

Removing some unnecessary string manipulation code from VoEBase::GetVersion().

BUG=webrtc:4690
Committed: https://crrev.com/2515af28e97213b4a4b89269f6b855378d31e153
Cr-Commit-Position: refs/heads/master@{#10868}

[the sun, 2015-12-02 09:56:54]

solenberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2015-12-02 10:24:59]

lgtm, with suggestions

https://codereview.webrtc.org/1493663002/diff/20001/webrtc/voice_engine/voe_b...
File webrtc/voice_engine/voe_base_impl.cc (right):

https://codereview.webrtc.org/1493663002/diff/20001/webrtc/voice_engine/voe_b...
webrtc/voice_engine/voe_base_impl.cc:591: std::string versionString =
VoiceEngine::GetVersionString() + "\n";
You force the allocation and deallocation of a second string here, which could
easily be avoided if you handled the terminating \n along with the terminating
\0 below.

https://codereview.webrtc.org/1493663002/diff/20001/webrtc/voice_engine/voe_b...
webrtc/voice_engine/voe_base_impl.cc:594: version[versionString.size()] = '\0';
I think it's generally a good idea to prefer std::copy to memcpy, because the
latter has a more permissive type. E.g.

  char* end = std::copy(versionString.cbegin(), versionString.cend(), version);
  end[0] = '\n';
  end[1] = '\0';

[the sun, 2015-12-02 10:44:18]

https://codereview.webrtc.org/1493663002/diff/20001/webrtc/voice_engine/voe_b...
File webrtc/voice_engine/voe_base_impl.cc (right):

https://codereview.webrtc.org/1493663002/diff/20001/webrtc/voice_engine/voe_b...
webrtc/voice_engine/voe_base_impl.cc:591: std::string versionString =
VoiceEngine::GetVersionString() + "\n";
On 2015/12/02 10:24:59, kwiberg-webrtc wrote:
> You force the allocation and deallocation of a second string here, which could
> easily be avoided if you handled the terminating \n along with the terminating
> \0 below.

Done.

https://codereview.webrtc.org/1493663002/diff/20001/webrtc/voice_engine/voe_b...
webrtc/voice_engine/voe_base_impl.cc:594: version[versionString.size()] = '\0';
On 2015/12/02 10:24:59, kwiberg-webrtc wrote:
> I think it's generally a good idea to prefer std::copy to memcpy, because the
> latter has a more permissive type. E.g.
> 
>   char* end = std::copy(versionString.cbegin(), versionString.cend(),
version);
>   end[0] = '\n';
>   end[1] = '\0';

Done.

[kwiberg-webrtc, 2015-12-02 10:50:12]

https://codereview.webrtc.org/1493663002/diff/40001/webrtc/voice_engine/voe_b...
File webrtc/voice_engine/voe_base_unittest.cc (right):

https://codereview.webrtc.org/1493663002/diff/40001/webrtc/voice_engine/voe_b...
webrtc/voice_engine/voe_base_unittest.cc:82: char v1[1024] = {0};
Or fill it with something other than zeros, to test if GetVersion really appends
a null.

[the sun, 2015-12-02 11:09:39]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-12-02 11:09:39]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1493663002/#ps60001 (title:
"comment")

[commit-bot: I haz the power, 2015-12-02 11:09:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1493663002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1493663002/60001

[commit-bot: I haz the power, 2015-12-02 13:09:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 13:09:58]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[the sun, 2015-12-02 13:19:31]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-12-02 13:19:36]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2015-12-02 13:19:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1493663002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1493663002/60001

[commit-bot: I haz the power, 2015-12-02 14:19:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-02 14:19:52]

Description was changed from

==========
Removing some unnecessary string manipulation code from VoEBase::GetVersion().

BUG=webrtc:4690
==========

to

==========
Removing some unnecessary string manipulation code from VoEBase::GetVersion().

BUG=webrtc:4690

Committed: https://crrev.com/2515af28e97213b4a4b89269f6b855378d31e153
Cr-Commit-Position: refs/heads/master@{#10868}
==========

[commit-bot: I haz the power, 2015-12-02 14:19:53]

Patchset 4 (id:??) landed as
https://crrev.com/2515af28e97213b4a4b89269f6b855378d31e153
Cr-Commit-Position: refs/heads/master@{#10868}