webrtc/voice_engine/voice_engine_defines.h - Issue 1493663002: Removing some unnecessary string manipulation code from VoEBase::GetVersion().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/voice_engine_defines.h

Issue 1493663002: Removing some unnecessary string manipulation code from VoEBase::GetVersion(). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: comment Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/voice_engine/voice_engine_defines.h

diff --git a/webrtc/voice_engine/voice_engine_defines.h b/webrtc/voice_engine/voice_engine_defines.h

index f929cd0101dd222bb095e38d16018290a2b25032..f4bdd957e9dae95a61af1e6eb8128b9c1d3ce702 100644

--- a/webrtc/voice_engine/voice_engine_defines.h

+++ b/webrtc/voice_engine/voice_engine_defines.h

@@ -57,9 +57,6 @@ enum { kVoiceEngineMaxIpPacketSizeBytes = 1500 }; // assumes Ethernet

enum { kVoiceEngineMaxModuleVersionSize = 960 };

-// Base

-enum { kVoiceEngineVersionMaxMessageSize = 1024 };

// Audio processing

const NoiseSuppression::Level kDefaultNsMode = NoiseSuppression::kModerate;

const GainControl::Mode kDefaultAgcMode =

« no previous file with comments | « webrtc/voice_engine/voe_base_unittest.cc ('k') | webrtc/voice_engine/voice_engine_impl.cc » ('j') | no next file with comments »