Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: webrtc/voice_engine/voice_engine_impl.cc

Issue 1493663002: Removing some unnecessary string manipulation code from VoEBase::GetVersion(). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: comment Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/voice_engine/voice_engine_defines.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 #ifdef WEBRTC_ANDROID 158 #ifdef WEBRTC_ANDROID
159 webrtc::JVM::Initialize(reinterpret_cast<JavaVM*>(javaVM), 159 webrtc::JVM::Initialize(reinterpret_cast<JavaVM*>(javaVM),
160 reinterpret_cast<jobject>(context)); 160 reinterpret_cast<jobject>(context));
161 return 0; 161 return 0;
162 #else 162 #else
163 return -1; 163 return -1;
164 #endif 164 #endif
165 } 165 }
166 #endif 166 #endif
167 167
168 std::string VoiceEngine::GetVersionString() {
169 std::string version = "VoiceEngine 4.1.0";
170 #ifdef WEBRTC_EXTERNAL_TRANSPORT
171 version += " (External transport build)";
172 #endif
173 return version;
174 }
175
168 } // namespace webrtc 176 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/voice_engine/voice_engine_defines.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698