Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Side by Side Diff: webrtc/voice_engine/voe_base_unittest.cc

Issue 1493663002: Removing some unnecessary string manipulation code from VoEBase::GetVersion(). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: comment Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/voice_engine/voe_base_impl.cc ('k') | webrtc/voice_engine/voice_engine_defines.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 EXPECT_EQ(0, base_->DeleteChannel(channel_1)); 71 EXPECT_EQ(0, base_->DeleteChannel(channel_1));
72 // Make sure that the only use of the channel-to-delete is |reference| 72 // Make sure that the only use of the channel-to-delete is |reference|
73 // at this point. 73 // at this point.
74 EXPECT_EQ(1, reference.use_count()); 74 EXPECT_EQ(1, reference.use_count());
75 75
76 reference = shared_data->channel_manager().GetChannel(channel_2); 76 reference = shared_data->channel_manager().GetChannel(channel_2);
77 EXPECT_EQ(0, base_->DeleteChannel(channel_2)); 77 EXPECT_EQ(0, base_->DeleteChannel(channel_2));
78 EXPECT_EQ(1, reference.use_count()); 78 EXPECT_EQ(1, reference.use_count());
79 } 79 }
80 80
81 TEST_F(VoEBaseTest, GetVersion) {
82 char v1[1024] = {0};
kwiberg-webrtc 2015/12/02 10:50:12 Or fill it with something other than zeros, to tes
83 base_->GetVersion(v1);
84 std::string v2 = VoiceEngine::GetVersionString() + "\n";
85 EXPECT_EQ(v2, v1);
86 }
81 } // namespace webrtc 87 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/voice_engine/voe_base_impl.cc ('k') | webrtc/voice_engine/voice_engine_defines.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698