talk: Use NDEBUG macro.

talk: Use NDEBUG macro.

NDEBUG is a standard macro with the semantic "Not Debug" for C89, C99, C++98,
  C++2003, C++2011, C++2014 standards. There are no _DEBUG macros in the
  standards.

_DEBUG is a macro Visual Studio defines when you specify the /MTd or /MDd
option.

http://stackoverflow.com/a/29253284/5237416

This should help fix the TODO in third_party/libjingle/libjingle.gyp

BUG=None
R=sergeyu@chromium.org

Committed: https://crrev.com/ff134ebd3d35ae2edd6eaa63b0a19cb16cc256b7
Cr-Commit-Position: refs/heads/master@{#10377}

[tfarina, 2015-10-22 18:17:27]

Description was changed from

==========
talk: Use NDEBUG macro.

NDEBUG is a standard macro with the semantic "Not Debug" for C89, C99, C++98,
  C++2003, C++2011, C++2014 standards. There are no _DEBUG macros in the
  standards.

_DEBUG is a macro Visual Studio defines when you specify the /MTd or /MDd
option.

This should help fix the TODO in third_party/libjingle/libjingle.gyp

BUG=None
R=sergeyu@chomium.org
==========

to

==========
talk: Use NDEBUG macro.

NDEBUG is a standard macro with the semantic "Not Debug" for C89, C99, C++98,
  C++2003, C++2011, C++2014 standards. There are no _DEBUG macros in the
  standards.

_DEBUG is a macro Visual Studio defines when you specify the /MTd or /MDd
option.

This should help fix the TODO in third_party/libjingle/libjingle.gyp

BUG=None
R=sergeyu@chromium.org
==========

[tfarina, 2015-10-22 18:17:28]

tfarina@chromium.org changed reviewers:
+ sergeyu@chromium.org
- sergeyu@chomium.org

[tfarina, 2015-10-22 18:18:11]

Sergey, is this correct/OK?

[juberti, 2015-10-22 19:51:28]

On 2015/10/22 18:18:11, tfarina wrote:
> Sergey, is this correct/OK?

Are these the only usages of _DEBUG across all of webrtc?

[tfarina, 2015-10-22 19:58:59]

On 2015/10/22 19:51:28, juberti wrote:
> On 2015/10/22 18:18:11, tfarina wrote:
> > Sergey, is this correct/OK?
> 
> Are these the only usages of _DEBUG across all of webrtc?

This change is self-contained for talk only. It excludes webrtc/ directory.

[Sergey Ulanov, 2015-10-22 21:18:05]

https://codereview.webrtc.org/1419733004/diff/1/talk/build/common.gypi
File talk/build/common.gypi (right):

https://codereview.webrtc.org/1419733004/diff/1/talk/build/common.gypi#newcod...
talk/build/common.gypi:154: 'NDEBUG',
I don't think you need this. build/common.gypi already defines it for release
builds.

[Sergey Ulanov, 2015-10-22 21:18:22]

Rest of the changes LGTM.

On 2015/10/22 21:18:05, Sergey Ulanov wrote:
> https://codereview.webrtc.org/1419733004/diff/1/talk/build/common.gypi
> File talk/build/common.gypi (right):
> 
>
https://codereview.webrtc.org/1419733004/diff/1/talk/build/common.gypi#newcod...
> talk/build/common.gypi:154: 'NDEBUG',
> I don't think you need this. build/common.gypi already defines it for release
> builds.

[tfarina, 2015-10-22 22:01:36]

Description was changed from

==========
talk: Use NDEBUG macro.

NDEBUG is a standard macro with the semantic "Not Debug" for C89, C99, C++98,
  C++2003, C++2011, C++2014 standards. There are no _DEBUG macros in the
  standards.

_DEBUG is a macro Visual Studio defines when you specify the /MTd or /MDd
option.

This should help fix the TODO in third_party/libjingle/libjingle.gyp

BUG=None
R=sergeyu@chromium.org
==========

to

==========
talk: Use NDEBUG macro.

NDEBUG is a standard macro with the semantic "Not Debug" for C89, C99, C++98,
  C++2003, C++2011, C++2014 standards. There are no _DEBUG macros in the
  standards.

_DEBUG is a macro Visual Studio defines when you specify the /MTd or /MDd
option.

http://stackoverflow.com/a/29253284/5237416

This should help fix the TODO in third_party/libjingle/libjingle.gyp

BUG=None
R=sergeyu@chromium.org
==========

[tfarina, 2015-10-22 22:09:28]

https://codereview.webrtc.org/1419733004/diff/1/talk/build/common.gypi
File talk/build/common.gypi (right):

https://codereview.webrtc.org/1419733004/diff/1/talk/build/common.gypi#newcod...
talk/build/common.gypi:154: 'NDEBUG',
On 2015/10/22 21:18:05, Sergey Ulanov wrote:
> I don't think you need this. build/common.gypi already defines it for release
> builds.
Removed. I can add it back if needed. I assume that you were talking about
Chromium's build/common.gypi.

[tfarina, 2015-10-22 22:09:33]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-10-22 22:09:34]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.webrtc.org/1419733004/#ps20001 (title:
"review")

[commit-bot: I haz the power, 2015-10-22 22:09:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419733004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419733004/20001

[Sergey Ulanov, 2015-10-22 22:39:58]

https://codereview.webrtc.org/1419733004/diff/1/talk/build/common.gypi
File talk/build/common.gypi (right):

https://codereview.webrtc.org/1419733004/diff/1/talk/build/common.gypi#newcod...
talk/build/common.gypi:154: 'NDEBUG',
On 2015/10/22 22:09:28, tfarina wrote:
> On 2015/10/22 21:18:05, Sergey Ulanov wrote:
> > I don't think you need this. build/common.gypi already defines it for
release
> > builds.
> Removed. I can add it back if needed. I assume that you were talking about
> Chromium's build/common.gypi.

There is build/common.gypi in webrtc and it defines NDEBUG too.

[tfarina, 2015-10-22 22:55:22]

https://codereview.webrtc.org/1419733004/diff/1/talk/build/common.gypi
File talk/build/common.gypi (right):

https://codereview.webrtc.org/1419733004/diff/1/talk/build/common.gypi#newcod...
talk/build/common.gypi:154: 'NDEBUG',
On 2015/10/22 22:39:58, Sergey Ulanov wrote:
> On 2015/10/22 22:09:28, tfarina wrote:
> > On 2015/10/22 21:18:05, Sergey Ulanov wrote:
> > > I don't think you need this. build/common.gypi already defines it for
> release
> > > builds.
> > Removed. I can add it back if needed. I assume that you were talking about
> > Chromium's build/common.gypi.
> 
> There is build/common.gypi in webrtc and it defines NDEBUG too.
I don't see one in webrtc/build/common.gypi.

[commit-bot: I haz the power, 2015-10-22 23:15:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-22 23:15:35]

Patchset 2 (id:??) landed as
https://crrev.com/ff134ebd3d35ae2edd6eaa63b0a19cb16cc256b7
Cr-Commit-Position: refs/heads/master@{#10377}