talk/app/webrtc/objc/public/RTCLogging.h - Issue 1419733004: talk: Use NDEBUG macro.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: talk/app/webrtc/objc/public/RTCLogging.h

Issue 1419733004: talk: Use NDEBUG macro. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | talk/media/base/videoframe_unittest.h » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * libjingle	2 * libjingle

3 * Copyright 2015 Google Inc.	3 * Copyright 2015 Google Inc.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions are met:	6 * modification, are permitted provided that the following conditions are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright notice,	8 * 1. Redistributions of source code must retain the above copyright notice,

9 * this list of conditions and the following disclaimer.	9 * this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright notice,	10 * 2. Redistributions in binary form must reproduce the above copyright notice,

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
74	74

75 #define RTCLogInfo(format, ...) \	75 #define RTCLogInfo(format, ...) \

76 RTCLogFormat(kRTCLoggingSeverityInfo, format, ##__VA_ARGS__) \	76 RTCLogFormat(kRTCLoggingSeverityInfo, format, ##__VA_ARGS__) \

77	77

78 #define RTCLogWarning(format, ...) \	78 #define RTCLogWarning(format, ...) \

79 RTCLogFormat(kRTCLoggingSeverityWarning, format, ##__VA_ARGS__) \	79 RTCLogFormat(kRTCLoggingSeverityWarning, format, ##__VA_ARGS__) \

80	80

81 #define RTCLogError(format, ...) \	81 #define RTCLogError(format, ...) \

82 RTCLogFormat(kRTCLoggingSeverityError, format, ##__VA_ARGS__) \	82 RTCLogFormat(kRTCLoggingSeverityError, format, ##__VA_ARGS__) \

83	83

84 #ifdef _DEBUG	84 #if !defined(NDEBUG)

85 #define RTCLogDebug(format, ...) RTCLogInfo(format, ##__VA_ARGS__)	85 #define RTCLogDebug(format, ...) RTCLogInfo(format, ##__VA_ARGS__)

86 #else	86 #else

87 #define RTCLogDebug(format, ...) \	87 #define RTCLogDebug(format, ...) \

88 do { \	88 do { \

89 } while (false)	89 } while (false)

90 #endif	90 #endif

91	91

92 #define RTCLog(format, ...) RTCLogInfo(format, ##__VA_ARGS__)	92 #define RTCLog(format, ...) RTCLogInfo(format, ##__VA_ARGS__)

OLD	NEW