Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: talk/media/base/videoframe_unittest.h

Issue 1419733004: talk: Use NDEBUG macro. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: review Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/app/webrtc/objc/public/RTCLogging.h ('k') | talk/media/base/videorenderer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2004 Google Inc. 3 * Copyright 2004 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 1233 matching lines...) Expand 10 before | Expand all | Expand 10 after
1244 void ValidateI420HugeSize() { 1244 void ValidateI420HugeSize() {
1245 #ifndef WIN32 // TODO(fbarchard): Reenable when fixing bug 9603762. 1245 #ifndef WIN32 // TODO(fbarchard): Reenable when fixing bug 9603762.
1246 ValidateFrame(kImageFilename, cricket::FOURCC_I420, 1000000000u, 1246 ValidateFrame(kImageFilename, cricket::FOURCC_I420, 1000000000u,
1247 1000000000u, false); 1247 1000000000u, false);
1248 #endif 1248 #endif
1249 } 1249 }
1250 1250
1251 // The following test that Validate crashes if the size is greater than the 1251 // The following test that Validate crashes if the size is greater than the
1252 // actual buffer size. 1252 // actual buffer size.
1253 // TODO(fbarchard): Consider moving a filter into the capturer/plugin. 1253 // TODO(fbarchard): Consider moving a filter into the capturer/plugin.
1254 #if defined(_MSC_VER) && defined(_DEBUG) 1254 #if defined(_MSC_VER) && !defined(NDEBUG)
1255 int ExceptionFilter(unsigned int code, struct _EXCEPTION_POINTERS *ep) { 1255 int ExceptionFilter(unsigned int code, struct _EXCEPTION_POINTERS *ep) {
1256 if (code == EXCEPTION_ACCESS_VIOLATION) { 1256 if (code == EXCEPTION_ACCESS_VIOLATION) {
1257 LOG(LS_INFO) << "Caught EXCEPTION_ACCESS_VIOLATION as expected."; 1257 LOG(LS_INFO) << "Caught EXCEPTION_ACCESS_VIOLATION as expected.";
1258 return EXCEPTION_EXECUTE_HANDLER; 1258 return EXCEPTION_EXECUTE_HANDLER;
1259 } else { 1259 } else {
1260 LOG(LS_INFO) << "Did not catch EXCEPTION_ACCESS_VIOLATION. Unexpected."; 1260 LOG(LS_INFO) << "Did not catch EXCEPTION_ACCESS_VIOLATION. Unexpected.";
1261 return EXCEPTION_CONTINUE_SEARCH; 1261 return EXCEPTION_CONTINUE_SEARCH;
1262 } 1262 }
1263 } 1263 }
1264 1264
(...skipping 681 matching lines...) Expand 10 before | Expand all | Expand 10 after
1946 ASSERT_TRUE(LoadFrameNoRepeat(&target2)); 1946 ASSERT_TRUE(LoadFrameNoRepeat(&target2));
1947 source.StretchToFrame(&target2, true, true); 1947 source.StretchToFrame(&target2, true, true);
1948 EXPECT_TRUE(IsBlack(target2)); 1948 EXPECT_TRUE(IsBlack(target2));
1949 EXPECT_EQ(source.GetTimeStamp(), target2.GetTimeStamp()); 1949 EXPECT_EQ(source.GetTimeStamp(), target2.GetTimeStamp());
1950 } 1950 }
1951 1951
1952 int repeat_; 1952 int repeat_;
1953 }; 1953 };
1954 1954
1955 #endif // TALK_MEDIA_BASE_VIDEOFRAME_UNITTEST_H_ 1955 #endif // TALK_MEDIA_BASE_VIDEOFRAME_UNITTEST_H_
OLDNEW
« no previous file with comments | « talk/app/webrtc/objc/public/RTCLogging.h ('k') | talk/media/base/videorenderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698