talk: Use NDEBUG macro.

talk/build/common.gypi

 #
 # libjingle
 # Copyright 2012 Google Inc.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
 #
 #  1. Redistributions of source code must retain the above copyright notice,
 #     this list of conditions and the following disclaimer.
 #  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 131 matching lines @@
       ['os_posix==1', {
         'configurations': {
           'Debug_Base': {
             'defines': [
               # Chromium's build/common.gypi defines this for all posix _except_
               # for ios & mac.  We want it there as well, e.g. because ASSERT
               # and friends trigger off of it.
               '_DEBUG',
             ],
           },
+          'Release_Base': {
+            'defines': [
+              'NDEBUG',

[Sergey Ulanov, 2015/10/22 21:18:05]

I don't think you need this. build/common.gypi already defines it for release
builds.

[tfarina, 2015/10/22 22:09:28]

Removed. I can add it back if needed. I assume that you were talking about
Chromium's build/common.gypi.

[Sergey Ulanov, 2015/10/22 22:39:58]

There is build/common.gypi in webrtc and it defines NDEBUG too.

[tfarina, 2015/10/22 22:55:22]

I don't see one in webrtc/build/common.gypi. 

+            ],
+          }
         },
         'defines': [
           'HASH_NAMESPACE=__gnu_cxx',
           'WEBRTC_POSIX',
           'DISABLE_DYNAMIC_CAST',
           # The POSIX standard says we have to define this.
           '_REENTRANT',
         ],
       }],
     ],
   }, # target_defaults
 }