Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1410663004: modules/video_processing: refactor interface->include + more. (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

modules/video_processing: refactor interface->include + more. Moved/renamed: webrtc/modules/video_processing/main/interface -> webrtc/modules/video_processing/include webrtc/modules/video_processing/main/source/* -> webrtc/modules/video_processing webrtc/modules/video_processing/main/test/unit_test -> webrtc/modules/video_processing/test No downstream code seems to use this module. BUG=webrtc:5095 TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc R=pbos@webrtc.org, stefan@webrtc.org Committed: https://crrev.com/0f59a88b32d95430bf12bd8c4d9b2963e018ead2 Cr-Commit-Position: refs/heads/master@{#10697}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Patch Set 3 : Rebase fix #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -3546 lines) Patch
M webrtc/modules/modules.gyp View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/modules/video_processing/BUILD.gn View 2 chunks +19 lines, -19 lines 0 comments Download
A + webrtc/modules/video_processing/brighten.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/video_processing/brighten.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/video_processing/brightness_detection.h View 1 2 chunks +5 lines, -7 lines 0 comments Download
A + webrtc/modules/video_processing/brightness_detection.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/video_processing/content_analysis.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/video_processing/content_analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/video_processing/content_analysis_sse2.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/video_processing/deflickering.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/video_processing/deflickering.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/video_processing/frame_preprocessor.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + webrtc/modules/video_processing/frame_preprocessor.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/video_processing/include/video_processing.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/video_processing/include/video_processing_defines.h View 2 chunks +3 lines, -3 lines 0 comments Download
D webrtc/modules/video_processing/main/interface/video_processing.h View 1 chunk +0 lines, -270 lines 0 comments Download
D webrtc/modules/video_processing/main/interface/video_processing_defines.h View 1 chunk +0 lines, -41 lines 0 comments Download
D webrtc/modules/video_processing/main/source/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/video_processing/main/source/brighten.h View 1 chunk +0 lines, -25 lines 0 comments Download
D webrtc/modules/video_processing/main/source/brighten.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/modules/video_processing/main/source/brightness_detection.h View 1 chunk +0 lines, -37 lines 0 comments Download
D webrtc/modules/video_processing/main/source/brightness_detection.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D webrtc/modules/video_processing/main/source/content_analysis.h View 1 chunk +0 lines, -87 lines 0 comments Download
D webrtc/modules/video_processing/main/source/content_analysis.cc View 1 chunk +0 lines, -274 lines 0 comments Download
D webrtc/modules/video_processing/main/source/content_analysis_sse2.cc View 1 chunk +0 lines, -264 lines 0 comments Download
D webrtc/modules/video_processing/main/source/deflickering.h View 1 chunk +0 lines, -56 lines 0 comments Download
D webrtc/modules/video_processing/main/source/deflickering.cc View 1 2 3 1 chunk +0 lines, -398 lines 0 comments Download
D webrtc/modules/video_processing/main/source/frame_preprocessor.h View 1 chunk +0 lines, -79 lines 0 comments Download
D webrtc/modules/video_processing/main/source/frame_preprocessor.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D webrtc/modules/video_processing/main/source/spatial_resampler.h View 1 chunk +0 lines, -61 lines 0 comments Download
D webrtc/modules/video_processing/main/source/spatial_resampler.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D webrtc/modules/video_processing/main/source/video_decimator.h View 1 chunk +0 lines, -58 lines 0 comments Download
D webrtc/modules/video_processing/main/source/video_decimator.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D webrtc/modules/video_processing/main/source/video_processing_impl.h View 1 chunk +0 lines, -75 lines 0 comments Download
D webrtc/modules/video_processing/main/source/video_processing_impl.cc View 1 2 3 1 chunk +0 lines, -182 lines 0 comments Download
D webrtc/modules/video_processing/main/test/unit_test/brightness_detection_test.cc View 1 chunk +0 lines, -121 lines 0 comments Download
D webrtc/modules/video_processing/main/test/unit_test/content_metrics_test.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D webrtc/modules/video_processing/main/test/unit_test/createTable.m View 1 chunk +0 lines, -179 lines 0 comments Download
D webrtc/modules/video_processing/main/test/unit_test/deflickering_test.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D webrtc/modules/video_processing/main/test/unit_test/readYUV420file.m View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/modules/video_processing/main/test/unit_test/video_processing_unittest.h View 1 chunk +0 lines, -47 lines 0 comments Download
D webrtc/modules/video_processing/main/test/unit_test/video_processing_unittest.cc View 1 chunk +0 lines, -390 lines 0 comments Download
D webrtc/modules/video_processing/main/test/unit_test/writeYUV420file.m View 1 chunk +0 lines, -22 lines 0 comments Download
A + webrtc/modules/video_processing/spatial_resampler.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/video_processing/spatial_resampler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/video_processing/test/brightness_detection_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/video_processing/test/content_metrics_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + webrtc/modules/video_processing/test/createTable.m View 2 chunks +2 lines, -2 lines 0 comments Download
A + webrtc/modules/video_processing/test/deflickering_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/video_processing/test/readYUV420file.m View 2 chunks +5 lines, -5 lines 0 comments Download
A + webrtc/modules/video_processing/test/video_processing_unittest.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/video_processing/test/video_processing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/video_processing/test/writeYUV420file.m View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/video_processing/video_decimator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/video_processing/video_decimator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/video_processing.gypi View 2 chunks +19 lines, -19 lines 0 comments Download
A + webrtc/modules/video_processing/video_processing_impl.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + webrtc/modules/video_processing/video_processing_impl.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/video/video_capture_input.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_capture_input.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_channel.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_encoder.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
kjellander_webrtc
5 years, 1 month ago (2015-11-05 16:17:35 UTC) #3
stefan-webrtc
https://codereview.webrtc.org/1410663004/diff/1/webrtc/modules/video_processing/brightness_detection.h File webrtc/modules/video_processing/brightness_detection.h (right): https://codereview.webrtc.org/1410663004/diff/1/webrtc/modules/video_processing/brightness_detection.h#newcode13 webrtc/modules/video_processing/brightness_detection.h:13: #include "webrtc/modules/video_processing/include/video_processing.h" Newline above.
5 years, 1 month ago (2015-11-16 19:05:08 UTC) #4
stefan-webrtc
lgtm with nit fixed.
5 years, 1 month ago (2015-11-16 19:05:16 UTC) #5
kjellander_webrtc
+pbos for video{,_engine} https://codereview.webrtc.org/1410663004/diff/1/webrtc/modules/video_processing/brightness_detection.h File webrtc/modules/video_processing/brightness_detection.h (right): https://codereview.webrtc.org/1410663004/diff/1/webrtc/modules/video_processing/brightness_detection.h#newcode13 webrtc/modules/video_processing/brightness_detection.h:13: #include "webrtc/modules/video_processing/include/video_processing.h" On 2015/11/16 19:05:08, stefan-webrtc ...
5 years, 1 month ago (2015-11-16 19:59:15 UTC) #7
pbos-webrtc
lgtm for those parts, thank you, this has been ugly for a while. Though I ...
5 years, 1 month ago (2015-11-17 11:42:03 UTC) #10
kjellander_webrtc
Committed patchset #4 (id:80001) manually as 0f59a88b32d95430bf12bd8c4d9b2963e018ead2 (presubmit successful).
5 years, 1 month ago (2015-11-18 21:31:38 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 21:31:39 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0f59a88b32d95430bf12bd8c4d9b2963e018ead2
Cr-Commit-Position: refs/heads/master@{#10697}

Powered by Google App Engine
This is Rietveld 408576698