Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1350163005: Avoid circular dependency rtp_rtcp <-> paced_sender (Closed)

Created:
5 years, 3 months ago by sprang_webrtc
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman, kjellander_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make sure rtp_rtcp module doesn't directly reference anything in the pacer module, and remove build dependencies on it. BUG= Committed: https://crrev.com/ebbf8a805b45613b4cb118e4eb0cebe7eeee69ac Cr-Commit-Position: refs/heads/master@{#10005}

Patch Set 1 #

Patch Set 2 : Remove references rtp_rtcp -> paced_sender #

Patch Set 3 : GN #

Patch Set 4 : Add explicit rtp_rtcp -> pacing dep. #

Total comments: 4

Patch Set 5 : Made class names more java-like. Woo! #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -126 lines) Patch
M webrtc/modules/pacing/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/pacing/bitrate_prober.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/bitrate_prober.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/pacing/include/paced_sender.h View 1 4 chunks +10 lines, -15 lines 0 comments Download
M webrtc/modules/pacing/include/packet_router.h View 1 2 3 4 2 chunks +7 lines, -3 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 1 3 chunks +8 lines, -5 lines 0 comments Download
M webrtc/modules/pacing/pacing.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h View 1 2 3 4 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h View 1 2 3 4 1 chunk +31 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 2 3 4 6 chunks +13 lines, -13 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 2 3 4 8 chunks +25 lines, -20 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 12 chunks +41 lines, -42 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/webrtc_video.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video_engine/vie_channel.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video_engine/vie_channel.cc View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
sprang_webrtc
5 years, 3 months ago (2015-09-21 07:11:57 UTC) #2
stefan-webrtc
https://codereview.webrtc.org/1350163005/diff/60001/webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h File webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h (right): https://codereview.webrtc.org/1350163005/diff/60001/webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h#newcode421 webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h:421: class SequenceNumberAllocator { This allocates a transport sequence number, ...
5 years, 3 months ago (2015-09-21 13:48:14 UTC) #3
sprang_webrtc
https://codereview.webrtc.org/1350163005/diff/60001/webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h File webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h (right): https://codereview.webrtc.org/1350163005/diff/60001/webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h#newcode421 webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h:421: class SequenceNumberAllocator { On 2015/09/21 13:48:14, stefan-webrtc (holmer) wrote: ...
5 years, 3 months ago (2015-09-21 14:02:34 UTC) #4
stefan-webrtc
lgtm
5 years, 3 months ago (2015-09-21 14:04:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350163005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350163005/80001
5 years, 3 months ago (2015-09-21 14:19:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350163005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350163005/100001
5 years, 3 months ago (2015-09-21 15:20:53 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios/builds/9597)
5 years, 3 months ago (2015-09-21 15:21:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350163005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350163005/100001
5 years, 3 months ago (2015-09-21 22:09:06 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 3 months ago (2015-09-21 22:11:20 UTC) #15
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/ebbf8a805b45613b4cb118e4eb0cebe7eeee69ac Cr-Commit-Position: refs/heads/master@{#10005}
5 years, 3 months ago (2015-09-21 22:11:27 UTC) #16
kjellander_webrtc
5 years, 3 months ago (2015-09-22 06:16:56 UTC) #18
Message was sent while issue was closed. 
Did someone reopen the CL? I closed it now.

Powered by Google App Engine
This is Rietveld 408576698