webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc - Issue 1350163005: Avoid circular dependency rtp_rtcp <-> paced_sender

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

Issue 1350163005: Avoid circular dependency rtp_rtcp <-> paced_sender (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

index b245e81d1a238b33e41968b32faadc6a330f48db..d941201cb18bfe98c9eae223627df2dd5e58aa1b 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

@@ -40,7 +40,7 @@ RtpRtcp::Configuration::Configuration()

audio_messages(NullObjectRtpAudioFeedback()),

remote_bitrate_estimator(nullptr),

paced_sender(nullptr),

- packet_router(nullptr),

+ transport_sequence_number_allocator(nullptr),

send_bitrate_observer(nullptr),

send_frame_count_observer(nullptr),

send_side_delay_observer(nullptr) {}

@@ -64,7 +64,7 @@ ModuleRtpRtcpImpl::ModuleRtpRtcpImpl(const Configuration& configuration)

configuration.outgoing_transport,

configuration.audio_messages,

configuration.paced_sender,

- configuration.packet_router,

+ configuration.transport_sequence_number_allocator,

configuration.transport_feedback_callback,

configuration.send_bitrate_observer,

configuration.send_frame_count_observer,

« no previous file with comments | « webrtc/modules/rtp_rtcp/rtp_rtcp.gypi ('k') | webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc » ('j') | no next file with comments »