Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Side by Side Diff: webrtc/modules/pacing/include/packet_router.h

Issue 1350163005: Avoid circular dependency rtp_rtcp <-> paced_sender (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/pacing/include/paced_sender.h ('k') | webrtc/modules/pacing/paced_sender.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_PACING_INCLUDE_PACKET_ROUTER_H_ 11 #ifndef WEBRTC_MODULES_PACING_INCLUDE_PACKET_ROUTER_H_
12 #define WEBRTC_MODULES_PACING_INCLUDE_PACKET_ROUTER_H_ 12 #define WEBRTC_MODULES_PACING_INCLUDE_PACKET_ROUTER_H_
13 13
14 #include <list> 14 #include <list>
15 15
16 #include "webrtc/base/constructormagic.h" 16 #include "webrtc/base/constructormagic.h"
17 #include "webrtc/base/criticalsection.h" 17 #include "webrtc/base/criticalsection.h"
18 #include "webrtc/base/scoped_ptr.h" 18 #include "webrtc/base/scoped_ptr.h"
19 #include "webrtc/base/thread_annotations.h" 19 #include "webrtc/base/thread_annotations.h"
20 #include "webrtc/common_types.h" 20 #include "webrtc/common_types.h"
21 #include "webrtc/modules/pacing/include/paced_sender.h" 21 #include "webrtc/modules/pacing/include/paced_sender.h"
22 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h" 22 #include "webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h"
23 23
24 namespace webrtc { 24 namespace webrtc {
25 25
26 class RtpRtcp; 26 class RtpRtcp;
27 namespace rtcp {
28 class TransportFeedback;
29 } // namespace rtcp
27 30
28 // PacketRouter routes outgoing data to the correct sending RTP module, based 31 // PacketRouter routes outgoing data to the correct sending RTP module, based
29 // on the simulcast layer in RTPVideoHeader. 32 // on the simulcast layer in RTPVideoHeader.
30 class PacketRouter : public PacedSender::Callback { 33 class PacketRouter : public PacedSender::Callback,
34 public TransportSequenceNumberAllocator {
31 public: 35 public:
32 PacketRouter(); 36 PacketRouter();
33 virtual ~PacketRouter(); 37 virtual ~PacketRouter();
34 38
35 void AddRtpModule(RtpRtcp* rtp_module); 39 void AddRtpModule(RtpRtcp* rtp_module);
36 void RemoveRtpModule(RtpRtcp* rtp_module); 40 void RemoveRtpModule(RtpRtcp* rtp_module);
37 41
38 // Implements PacedSender::Callback. 42 // Implements PacedSender::Callback.
39 bool TimeToSendPacket(uint32_t ssrc, 43 bool TimeToSendPacket(uint32_t ssrc,
40 uint16_t sequence_number, 44 uint16_t sequence_number,
41 int64_t capture_timestamp, 45 int64_t capture_timestamp,
42 bool retransmission) override; 46 bool retransmission) override;
43 47
44 size_t TimeToSendPadding(size_t bytes) override; 48 size_t TimeToSendPadding(size_t bytes) override;
45 49
46 void SetTransportWideSequenceNumber(uint16_t sequence_number); 50 void SetTransportWideSequenceNumber(uint16_t sequence_number);
47 uint16_t AllocateSequenceNumber(); 51 uint16_t AllocateSequenceNumber() override;
48 52
49 // Send transport feedback packet to send-side. 53 // Send transport feedback packet to send-side.
50 virtual bool SendFeedback(rtcp::TransportFeedback* packet); 54 virtual bool SendFeedback(rtcp::TransportFeedback* packet);
51 55
52 private: 56 private:
53 rtc::CriticalSection modules_lock_; 57 rtc::CriticalSection modules_lock_;
54 // Map from ssrc to sending rtp module. 58 // Map from ssrc to sending rtp module.
55 std::list<RtpRtcp*> rtp_modules_ GUARDED_BY(modules_lock_); 59 std::list<RtpRtcp*> rtp_modules_ GUARDED_BY(modules_lock_);
56 60
57 volatile int transport_seq_; 61 volatile int transport_seq_;
58 62
59 RTC_DISALLOW_COPY_AND_ASSIGN(PacketRouter); 63 RTC_DISALLOW_COPY_AND_ASSIGN(PacketRouter);
60 }; 64 };
61 } // namespace webrtc 65 } // namespace webrtc
62 #endif // WEBRTC_MODULES_PACING_INCLUDE_PACKET_ROUTER_H_ 66 #endif // WEBRTC_MODULES_PACING_INCLUDE_PACKET_ROUTER_H_
OLDNEW
« no previous file with comments | « webrtc/modules/pacing/include/paced_sender.h ('k') | webrtc/modules/pacing/paced_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698