Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: webrtc/video_engine/vie_channel.cc

Issue 1350163005: Avoid circular dependency rtp_rtcp <-> paced_sender (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/video_engine/vie_channel.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1120 matching lines...) Expand 10 before | Expand all | Expand 10 after
1131 std::vector<RtpRtcp*> ViEChannel::CreateRtpRtcpModules( 1131 std::vector<RtpRtcp*> ViEChannel::CreateRtpRtcpModules(
1132 bool receiver_only, 1132 bool receiver_only,
1133 ReceiveStatistics* receive_statistics, 1133 ReceiveStatistics* receive_statistics,
1134 Transport* outgoing_transport, 1134 Transport* outgoing_transport,
1135 RtcpIntraFrameObserver* intra_frame_callback, 1135 RtcpIntraFrameObserver* intra_frame_callback,
1136 RtcpBandwidthObserver* bandwidth_callback, 1136 RtcpBandwidthObserver* bandwidth_callback,
1137 TransportFeedbackObserver* transport_feedback_callback, 1137 TransportFeedbackObserver* transport_feedback_callback,
1138 RtcpRttStats* rtt_stats, 1138 RtcpRttStats* rtt_stats,
1139 RtcpPacketTypeCounterObserver* rtcp_packet_type_counter_observer, 1139 RtcpPacketTypeCounterObserver* rtcp_packet_type_counter_observer,
1140 RemoteBitrateEstimator* remote_bitrate_estimator, 1140 RemoteBitrateEstimator* remote_bitrate_estimator,
1141 PacedSender* paced_sender, 1141 RtpPacketSender* paced_sender,
1142 PacketRouter* packet_router, 1142 TransportSequenceNumberAllocator* transport_sequence_number_allocator,
1143 BitrateStatisticsObserver* send_bitrate_observer, 1143 BitrateStatisticsObserver* send_bitrate_observer,
1144 FrameCountObserver* send_frame_count_observer, 1144 FrameCountObserver* send_frame_count_observer,
1145 SendSideDelayObserver* send_side_delay_observer, 1145 SendSideDelayObserver* send_side_delay_observer,
1146 size_t num_modules) { 1146 size_t num_modules) {
1147 RTC_DCHECK_GT(num_modules, 0u); 1147 RTC_DCHECK_GT(num_modules, 0u);
1148 RtpRtcp::Configuration configuration; 1148 RtpRtcp::Configuration configuration;
1149 ReceiveStatistics* null_receive_statistics = configuration.receive_statistics; 1149 ReceiveStatistics* null_receive_statistics = configuration.receive_statistics;
1150 configuration.audio = false; 1150 configuration.audio = false;
1151 configuration.receiver_only = receiver_only; 1151 configuration.receiver_only = receiver_only;
1152 configuration.receive_statistics = receive_statistics; 1152 configuration.receive_statistics = receive_statistics;
1153 configuration.outgoing_transport = outgoing_transport; 1153 configuration.outgoing_transport = outgoing_transport;
1154 configuration.intra_frame_callback = intra_frame_callback; 1154 configuration.intra_frame_callback = intra_frame_callback;
1155 configuration.rtt_stats = rtt_stats; 1155 configuration.rtt_stats = rtt_stats;
1156 configuration.rtcp_packet_type_counter_observer = 1156 configuration.rtcp_packet_type_counter_observer =
1157 rtcp_packet_type_counter_observer; 1157 rtcp_packet_type_counter_observer;
1158 configuration.paced_sender = paced_sender; 1158 configuration.paced_sender = paced_sender;
1159 configuration.packet_router = packet_router; 1159 configuration.transport_sequence_number_allocator =
1160 transport_sequence_number_allocator;
1160 configuration.send_bitrate_observer = send_bitrate_observer; 1161 configuration.send_bitrate_observer = send_bitrate_observer;
1161 configuration.send_frame_count_observer = send_frame_count_observer; 1162 configuration.send_frame_count_observer = send_frame_count_observer;
1162 configuration.send_side_delay_observer = send_side_delay_observer; 1163 configuration.send_side_delay_observer = send_side_delay_observer;
1163 configuration.bandwidth_callback = bandwidth_callback; 1164 configuration.bandwidth_callback = bandwidth_callback;
1164 configuration.transport_feedback_callback = transport_feedback_callback; 1165 configuration.transport_feedback_callback = transport_feedback_callback;
1165 1166
1166 std::vector<RtpRtcp*> modules; 1167 std::vector<RtpRtcp*> modules;
1167 for (size_t i = 0; i < num_modules; ++i) { 1168 for (size_t i = 0; i < num_modules; ++i) {
1168 RtpRtcp* rtp_rtcp = RtpRtcp::CreateRtpRtcp(configuration); 1169 RtpRtcp* rtp_rtcp = RtpRtcp::CreateRtpRtcp(configuration);
1169 rtp_rtcp->SetSendingStatus(false); 1170 rtp_rtcp->SetSendingStatus(false);
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
1252 CriticalSectionScoped cs(crit_.get()); 1253 CriticalSectionScoped cs(crit_.get());
1253 receive_stats_callback_ = receive_statistics_proxy; 1254 receive_stats_callback_ = receive_statistics_proxy;
1254 } 1255 }
1255 1256
1256 void ViEChannel::SetIncomingVideoStream( 1257 void ViEChannel::SetIncomingVideoStream(
1257 IncomingVideoStream* incoming_video_stream) { 1258 IncomingVideoStream* incoming_video_stream) {
1258 CriticalSectionScoped cs(crit_.get()); 1259 CriticalSectionScoped cs(crit_.get());
1259 incoming_video_stream_ = incoming_video_stream; 1260 incoming_video_stream_ = incoming_video_stream;
1260 } 1261 }
1261 } // namespace webrtc 1262 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/video_engine/vie_channel.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698