Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1286133002: Revert of AppRTCDemo: Render each video in a separate SurfaceView (Closed)

Created:
5 years, 4 months ago by magjed_webrtc
Modified:
5 years, 4 months ago
Reviewers:
AlexG, wzh
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of AppRTCDemo: Render each video in a separate SurfaceView (patchset #4 id:120001 of https://codereview.webrtc.org/1257043004/ ) Reason for revert: AppRTCDemo often crashes in loopback mode and incorrect layout when connection is established BUG=webrtc:4909, webrtc:4910 Original issue's description: > AppRTCDemo: Render each video in a separate SurfaceView > > This CL introduces a new org.webrtc.VideoRenderer.Callbacks implementation called SurfaceViewRenderer that renders each video stream in its own SurfaceView. AppRTCDemo is updated to use this new rendering. > > This CL also does the following changes: > * Make the VideoRenderer.Callbacks interface asynchronous and require that renderFrameDone() is called for every renderFrame(). In JNI, this is implemented with cricket::VideoFrame::Copy()/delete. > * Make public static helper functions: convertScalingTypeToVisibleFraction(), getDisplaySize(), and getTextureMatrix(). > * Introduces new helper functions surfaceWidth()/surfaceHeight() in EGlBase that allows to query the surface size. > * Introduce PercentFrameLayout that implements the percentage layout that is used by AppRTCDemo. > > BUG=webrtc:4742 > > Committed: https://crrev.com/05bfbe47ef6bcc9ca731c0fa0d5cd15a4f21e93f > Cr-Commit-Position: refs/heads/master@{#9699} TBR=glaznev@webrtc.org,wzh@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4742 Committed: https://crrev.com/e2a8be124458d77d0d3f30a8e33e0a1eede4a849 Cr-Commit-Position: refs/heads/master@{#9703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -835 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/EglBase.java View 1 chunk +0 lines, -12 lines 0 comments Download
D talk/app/webrtc/java/android/org/webrtc/RendererCommon.java View 1 chunk +0 lines, -126 lines 0 comments Download
D talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java View 1 chunk +0 lines, -474 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java View 16 chunks +79 lines, -17 lines 0 comments Download
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 5 chunks +4 lines, -12 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/VideoRenderer.java View 7 chunks +5 lines, -26 lines 0 comments Download
M talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M talk/libjingle.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/examples/androidapp/res/layout/activity_call.xml View 1 chunk +3 lines, -18 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java View 9 chunks +38 lines, -48 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallFragment.java View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/examples/androidapp/src/org/appspot/apprtc/PercentFrameLayout.java View 1 chunk +0 lines, -95 lines 0 comments Download
M webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
magjed_webrtc
Created Revert of AppRTCDemo: Render each video in a separate SurfaceView
5 years, 4 months ago (2015-08-12 06:53:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286133002/1
5 years, 4 months ago (2015-08-12 06:54:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 06:55:03 UTC) #4
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 06:55:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2a8be124458d77d0d3f30a8e33e0a1eede4a849
Cr-Commit-Position: refs/heads/master@{#9703}

Powered by Google App Engine
This is Rietveld 408576698