Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1208993010: iSAC: Make separate AudioEncoder and AudioDecoder objects (Closed)

Created:
5 years, 5 months ago by kwiberg-webrtc
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iSAC: Make separate AudioEncoder and AudioDecoder objects The only shared state is now the bandwidth estimation info. This reduces the amount and complexity of the locking substantially. Committed: https://crrev.com/608c3cfe77c165965ea04fcd0a2a71aad05a1d16 Cr-Commit-Position: refs/heads/master@{#9762}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment (variable name) #

Patch Set 3 : rebase #

Patch Set 4 : Move shared iSAC files to their own build target #

Patch Set 5 : Set BwInfo in AudioEncoderMutableIsacFix constructor #

Patch Set 6 : Initialize BandwidthInfo.in_use to 0 #

Patch Set 7 : Set decoder sample rate in encoder #

Patch Set 8 : Initialize iSACfix function pointers in the decoder too, not just the encoder #

Patch Set 9 : AudioDecoderIsac*Test: Encoder and decoder must be separate, like they used to be #

Total comments: 4

Patch Set 10 : review fixes #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -518 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 2 3 5 chunks +11 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/audio_coding.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h View 1 2 3 3 chunks +40 lines, -50 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h View 1 2 3 4 5 6 7 chunks +81 lines, -51 lines 2 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/interface/audio_encoder_isacfix.h View 1 2 3 4 1 chunk +6 lines, -34 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/audio_encoder_isacfix.cc View 1 2 3 4 2 chunks +14 lines, -100 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/isacfix.c View 1 2 3 4 5 6 7 8 9 3 chunks +28 lines, -23 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/isac.gypi View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/isac/isac_common.gypi View 1 2 3 4 5 6 7 8 9 2 chunks +6 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/isacfix.gypi View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/isac/locked_bandwidth_info.h View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/isac/locked_bandwidth_info.cc View 1 2 3 4 5 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/interface/audio_encoder_isac.h View 1 2 1 chunk +6 lines, -34 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac.cc View 2 chunks +14 lines, -99 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_owner.h View 1 chunk +8 lines, -12 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_owner.cc View 5 chunks +41 lines, -54 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc View 1 2 1 chunk +5 lines, -14 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -19 lines 0 comments Download

Dependent Patchsets:

Issue 1312493004 Patch 1

Messages

Total messages: 18 (5 generated)
kwiberg-webrtc
Please review. Note that this still fails a small number of iSAC encoding bit-exactness tests; ...
5 years, 5 months ago (2015-07-07 13:43:35 UTC) #2
Jelena
lgtm
5 years, 5 months ago (2015-07-07 14:02:42 UTC) #3
hlundin-webrtc
This is so much better. LGTM with one nit. https://codereview.webrtc.org/1208993010/diff/1/webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac_unittest.cc File webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac_unittest.cc (right): https://codereview.webrtc.org/1208993010/diff/1/webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac_unittest.cc#newcode26 webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac_unittest.cc:26: ...
5 years, 4 months ago (2015-08-10 07:43:33 UTC) #4
hlundin-webrtc
This is so much better. LGTM with one nit. https://codereview.webrtc.org/1208993010/diff/1/webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac_unittest.cc File webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac_unittest.cc (right): https://codereview.webrtc.org/1208993010/diff/1/webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac_unittest.cc#newcode26 webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac_unittest.cc:26: ...
5 years, 4 months ago (2015-08-10 07:43:33 UTC) #5
kwiberg-webrtc
https://codereview.webrtc.org/1208993010/diff/1/webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac_unittest.cc File webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac_unittest.cc (right): https://codereview.webrtc.org/1208993010/diff/1/webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac_unittest.cc#newcode26 webrtc/modules/audio_coding/codecs/isac/main/source/audio_encoder_isac_unittest.cc:26: AudioEncoderIsac ed(config); On 2015/08/10 07:43:33, hlundin-webrtc wrote: > Variable ...
5 years, 4 months ago (2015-08-10 10:00:05 UTC) #6
kwiberg-webrtc
Henrik, take another look if you don't mind. I've had to fix a bunch of ...
5 years, 4 months ago (2015-08-20 12:12:58 UTC) #8
hlundin-webrtc
LGTM again, with two nits. https://codereview.webrtc.org/1208993010/diff/170001/webrtc/modules/audio_coding/codecs/isac/fix/source/isacfix.c File webrtc/modules/audio_coding/codecs/isac/fix/source/isacfix.c (right): https://codereview.webrtc.org/1208993010/diff/170001/webrtc/modules/audio_coding/codecs/isac/fix/source/isacfix.c#newcode245 webrtc/modules/audio_coding/codecs/isac/fix/source/isacfix.c:245: // Initiaze function pointers. ...
5 years, 4 months ago (2015-08-24 08:06:54 UTC) #9
kwiberg-webrtc
https://codereview.webrtc.org/1208993010/diff/170001/webrtc/modules/audio_coding/codecs/isac/fix/source/isacfix.c File webrtc/modules/audio_coding/codecs/isac/fix/source/isacfix.c (right): https://codereview.webrtc.org/1208993010/diff/170001/webrtc/modules/audio_coding/codecs/isac/fix/source/isacfix.c#newcode245 webrtc/modules/audio_coding/codecs/isac/fix/source/isacfix.c:245: // Initiaze function pointers. On 2015/08/24 08:06:54, hlundin-webrtc wrote: ...
5 years, 4 months ago (2015-08-24 08:16:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208993010/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1208993010/180001
5 years, 4 months ago (2015-08-24 08:16:46 UTC) #13
commit-bot: I haz the power
Committed patchset #10 (id:180001)
5 years, 4 months ago (2015-08-24 09:03:27 UTC) #14
commit-bot: I haz the power
Patchset 10 (id:??) landed as https://crrev.com/608c3cfe77c165965ea04fcd0a2a71aad05a1d16 Cr-Commit-Position: refs/heads/master@{#9762}
5 years, 4 months ago (2015-08-24 09:03:36 UTC) #15
brucedawson
/analyze reported a new variable shadowing warning after webrtc was rolled into Chromium. FWIW. https://codereview.webrtc.org/1208993010/diff/180001/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h ...
5 years, 3 months ago (2015-08-26 18:45:57 UTC) #17
kwiberg-webrtc
5 years, 3 months ago (2015-08-27 09:01:48 UTC) #18
Message was sent while issue was closed. 
https://codereview.webrtc.org/1208993010/diff/180001/webrtc/modules/audio_cod...
File webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h
(right):

https://codereview.webrtc.org/1208993010/diff/180001/webrtc/modules/audio_cod...
webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h:189:
IsacBandwidthInfo bwinfo;
On 2015/08/26 18:45:57, brucedawson wrote:
> This variable shadows the function parameter bwinfo. This isn't a bug but it
is
> confusing, especially given the different type and the similarly named member
> variable.
> 
> Consider renaming to ibwinfo or something else different.

Good idea. CL here: https://codereview.webrtc.org/1315333003/

Powered by Google App Engine
This is Rietveld 408576698