iSAC: Make separate AudioEncoder and AudioDecoder objects

webrtc/modules/audio_coding/main/acm2/codec_owner.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 57 matching lines @@
 
 bool IsG722(const CodecInst& codec) {
   return
 #ifdef WEBRTC_CODEC_G722
       !STR_CASE_CMP(codec.plname, "g722") ||
 #endif
       false;
 }
 }  // namespace
 
-CodecOwner::CodecOwner()
-    : isac_is_encoder_(false), external_speech_encoder_(nullptr) {
+CodecOwner::CodecOwner() : external_speech_encoder_(nullptr) {
 }
 
 CodecOwner::~CodecOwner() = default;
 
 namespace {
-AudioEncoderDecoderMutableIsac* CreateIsacCodec(const CodecInst& speech_inst) {
+
+rtc::scoped_ptr<AudioDecoder> CreateIsacDecoder(
+    LockedIsacBandwidthInfo* bwinfo) {
 #if defined(WEBRTC_CODEC_ISACFX)
-  return new AudioEncoderDecoderMutableIsacFix(speech_inst);
+  return rtc_make_scoped_ptr(new AudioDecoderIsacFix(bwinfo));
 #elif defined(WEBRTC_CODEC_ISAC)
-  return new AudioEncoderDecoderMutableIsacFloat(speech_inst);
+  return rtc_make_scoped_ptr(new AudioDecoderIsac(bwinfo));
 #else
   FATAL() << "iSAC is not supported.";
-  return nullptr;
+  return rtc::scoped_ptr<AudioDecoder>();
 #endif
 }
 
-void CreateSpeechEncoder(
+rtc::scoped_ptr<AudioEncoderMutable> CreateIsacEncoder(
     const CodecInst& speech_inst,
-    rtc::scoped_ptr<AudioEncoderMutable>* speech_encoder,
-    rtc::scoped_ptr<AudioEncoderDecoderMutableIsac>* isac_codec,
-    bool* isac_is_encoder) {
+    LockedIsacBandwidthInfo* bwinfo) {
+#if defined(WEBRTC_CODEC_ISACFX)
+  return rtc_make_scoped_ptr(
+      new AudioEncoderMutableIsacFix(speech_inst, bwinfo));
+#elif defined(WEBRTC_CODEC_ISAC)
+  return rtc_make_scoped_ptr(
+      new AudioEncoderMutableIsacFloat(speech_inst, bwinfo));
+#else
+  FATAL() << "iSAC is not supported.";
+  return rtc::scoped_ptr<AudioEncoderMutable>();
+#endif
+}
+
+rtc::scoped_ptr<AudioEncoderMutable> CreateSpeechEncoder(
+    const CodecInst& speech_inst,
+    LockedIsacBandwidthInfo* bwinfo) {
   if (IsIsac(speech_inst)) {
-    if (*isac_codec) {
-      (*isac_codec)->UpdateSettings(speech_inst);
-    } else {
-      isac_codec->reset(CreateIsacCodec(speech_inst));
-    }
-    *isac_is_encoder = true;
-    speech_encoder->reset();
-    return;
-  }
-  if (IsOpus(speech_inst)) {
-    speech_encoder->reset(new AudioEncoderMutableOpus(speech_inst));
+    return CreateIsacEncoder(speech_inst, bwinfo);
+  } else if (IsOpus(speech_inst)) {
+    return rtc_make_scoped_ptr(new AudioEncoderMutableOpus(speech_inst));
   } else if (IsPcmU(speech_inst)) {
-    speech_encoder->reset(new AudioEncoderMutablePcmU(speech_inst));
+    return rtc_make_scoped_ptr(new AudioEncoderMutablePcmU(speech_inst));
   } else if (IsPcmA(speech_inst)) {
-    speech_encoder->reset(new AudioEncoderMutablePcmA(speech_inst));
+    return rtc_make_scoped_ptr(new AudioEncoderMutablePcmA(speech_inst));
   } else if (IsPcm16B(speech_inst)) {
-    speech_encoder->reset(new AudioEncoderMutablePcm16B(speech_inst));
+    return rtc_make_scoped_ptr(new AudioEncoderMutablePcm16B(speech_inst));
   } else if (IsIlbc(speech_inst)) {
-    speech_encoder->reset(new AudioEncoderMutableIlbc(speech_inst));
+    return rtc_make_scoped_ptr(new AudioEncoderMutableIlbc(speech_inst));
   } else if (IsG722(speech_inst)) {
-    speech_encoder->reset(new AudioEncoderMutableG722(speech_inst));
+    return rtc_make_scoped_ptr(new AudioEncoderMutableG722(speech_inst));
   } else {
     FATAL();
+    return rtc::scoped_ptr<AudioEncoderMutable>();
   }
-  *isac_is_encoder = false;
 }
 
 AudioEncoder* CreateRedEncoder(int red_payload_type,
                                AudioEncoder* encoder,
                                rtc::scoped_ptr<AudioEncoder>* red_encoder) {
   if (red_payload_type == -1) {
     red_encoder->reset();
     return encoder;
   }
   AudioEncoderCopyRed::Config config;
@@ skipping 32 matching lines @@
       FATAL();
   }
   cng_encoder->reset(new AudioEncoderCng(config));
 }
 }  // namespace
 
 void CodecOwner::SetEncoders(const CodecInst& speech_inst,
                              int cng_payload_type,
                              ACMVADMode vad_mode,
                              int red_payload_type) {
-  CreateSpeechEncoder(speech_inst, &speech_encoder_, &isac_codec_,
-                      &isac_is_encoder_);
+  speech_encoder_ = CreateSpeechEncoder(speech_inst, &isac_bandwidth_info_);
   external_speech_encoder_ = nullptr;
   ChangeCngAndRed(cng_payload_type, vad_mode, red_payload_type);
 }
 
 void CodecOwner::SetEncoders(AudioEncoderMutable* external_speech_encoder,
                              int cng_payload_type,
                              ACMVADMode vad_mode,
                              int red_payload_type) {
   external_speech_encoder_ = external_speech_encoder;
   speech_encoder_.reset();
-  isac_is_encoder_ = false;
   ChangeCngAndRed(cng_payload_type, vad_mode, red_payload_type);
 }
 
 void CodecOwner::ChangeCngAndRed(int cng_payload_type,
                                  ACMVADMode vad_mode,
                                  int red_payload_type) {
   AudioEncoderMutable* speech_encoder = SpeechEncoder();
   if (cng_payload_type != -1 || red_payload_type != -1) {
     // The RED and CNG encoders need to be in sync with the speech encoder, so
     // reset the latter to ensure its buffer is empty.
     speech_encoder->Reset();
   }
   AudioEncoder* encoder =
       CreateRedEncoder(red_payload_type, speech_encoder, &red_encoder_);
   CreateCngEncoder(cng_payload_type, vad_mode, encoder, &cng_encoder_);
-  int num_true =
-      !!speech_encoder_ + !!external_speech_encoder_ + isac_is_encoder_;
-  DCHECK_EQ(num_true, 1);
-  DCHECK(!isac_is_encoder_ || isac_codec_);
+  DCHECK_EQ(!!speech_encoder_ + !!external_speech_encoder_, 1);
 }
 
 AudioDecoder* CodecOwner::GetIsacDecoder() {
-  if (!isac_codec_) {
-    DCHECK(!isac_is_encoder_);
-    // None of the parameter values in |speech_inst| matter when the codec is
-    // used only as a decoder.
-    CodecInst speech_inst;
-    speech_inst.plfreq = 16000;
-    speech_inst.rate = -1;
-    speech_inst.pacsize = 480;
-    isac_codec_.reset(CreateIsacCodec(speech_inst));
-  }
-  return isac_codec_.get();
+  if (!isac_decoder_)
+    isac_decoder_ = CreateIsacDecoder(&isac_bandwidth_info_);
+  return isac_decoder_.get();
 }
 
 AudioEncoder* CodecOwner::Encoder() {
   const auto& const_this = *this;
   return const_cast<AudioEncoder*>(const_this.Encoder());
 }
 
 const AudioEncoder* CodecOwner::Encoder() const {
   if (cng_encoder_)
     return cng_encoder_.get();
   if (red_encoder_)
     return red_encoder_.get();
   return SpeechEncoder();
 }
 
 AudioEncoderMutable* CodecOwner::SpeechEncoder() {
   const auto& const_this = *this;
   return const_cast<AudioEncoderMutable*>(const_this.SpeechEncoder());
 }
 
 const AudioEncoderMutable* CodecOwner::SpeechEncoder() const {
-  int num_true =
-      !!speech_encoder_ + !!external_speech_encoder_ + isac_is_encoder_;
-  DCHECK_GE(num_true, 0);
-  DCHECK_LE(num_true, 1);
-  if (external_speech_encoder_)
-    return external_speech_encoder_;
-  if (speech_encoder_)
-    return speech_encoder_.get();
-  return isac_is_encoder_ ? isac_codec_.get() : nullptr;
+  DCHECK(!speech_encoder_ || !external_speech_encoder_);
+  return external_speech_encoder_ ? external_speech_encoder_
+                                  : speech_encoder_.get();
 }
 
 }  // namespace acm2
 }  // namespace webrtc