Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1315333003: Rename local variable to avoid shadowing (Closed)

Created:
5 years, 3 months ago by kwiberg-webrtc
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
kwiberg-webrtc
5 years, 3 months ago (2015-08-27 09:02:29 UTC) #2
brucedawson
I am not an owner but lgtm.
5 years, 3 months ago (2015-08-27 17:47:32 UTC) #3
kwiberg-webrtc
On 2015/08/27 17:47:32, brucedawson wrote: > I am not an owner but lgtm. No problem, ...
5 years, 3 months ago (2015-08-27 18:12:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315333003/1
5 years, 3 months ago (2015-08-27 18:12:26 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-08-27 18:12:27 UTC) #8
kwiberg-webrtc
On 2015/08/27 18:12:10, kwiberg-webrtc wrote: > On 2015/08/27 17:47:32, brucedawson wrote: > > I am ...
5 years, 3 months ago (2015-08-27 18:15:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315333003/1
5 years, 3 months ago (2015-08-27 18:16:47 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 18:17:40 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a567bf329239480529835ccb34a6d9cc8cbbf715 Cr-Commit-Position: refs/heads/master@{#9800}
5 years, 3 months ago (2015-08-27 18:17:46 UTC) #14
hlundin-webrtc
5 years, 3 months ago (2015-08-27 21:34:55 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698