Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1179233003: Add kGoogEchoCancellation to MediaConstraintsInterface. (Closed)

Created:
5 years, 6 months ago by tommi
Modified:
5 years, 6 months ago
Reviewers:
Andrew MacDonald
CC:
Andrew MacDonald, interface-changes_webrtc.org, niklas.enbom, qiang.lu, rwolff_gocast.it, tterriberry_mozilla.com, webrtc-reviews_webrtc.org, yujie_mao (webrtc)
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add kGoogEchoCancellation to MediaConstraintsInterface. This constraint will be equal to kEchoCancellation until we've updated Chromium to use kGoogEchoCancellation where that constraint is needed. Once that's done, I'll change kEchoCancellation to be 'echoCancellation'. BUG=webrtc:4747 R=andrew@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/70c7fe14ac322a3abac2726d29ae3264b956e3da

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M talk/app/webrtc/localaudiosource.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/localaudiosource_unittest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M talk/app/webrtc/mediaconstraintsinterface.h View 1 chunk +6 lines, -0 lines 0 comments Download
M talk/app/webrtc/mediaconstraintsinterface.cc View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
tommi
5 years, 6 months ago (2015-06-14 08:20:45 UTC) #1
Andrew MacDonald
lgtm
5 years, 6 months ago (2015-06-15 06:56:53 UTC) #2
Andrew MacDonald
https://codereview.webrtc.org/1179233003/diff/1/talk/app/webrtc/mediaconstraintsinterface.cc File talk/app/webrtc/mediaconstraintsinterface.cc (right): https://codereview.webrtc.org/1179233003/diff/1/talk/app/webrtc/mediaconstraintsinterface.cc#newcode51 talk/app/webrtc/mediaconstraintsinterface.cc:51: const char MediaConstraintsInterface::kGoogEchoCancellation[] = Not for this CL of ...
5 years, 6 months ago (2015-06-15 06:58:54 UTC) #3
tommi
https://codereview.webrtc.org/1179233003/diff/1/talk/app/webrtc/mediaconstraintsinterface.cc File talk/app/webrtc/mediaconstraintsinterface.cc (right): https://codereview.webrtc.org/1179233003/diff/1/talk/app/webrtc/mediaconstraintsinterface.cc#newcode51 talk/app/webrtc/mediaconstraintsinterface.cc:51: const char MediaConstraintsInterface::kGoogEchoCancellation[] = On 2015/06/15 at 06:58:54, andrew ...
5 years, 6 months ago (2015-06-15 07:12:51 UTC) #4
tommi
5 years, 6 months ago (2015-06-15 07:14:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
70c7fe14ac322a3abac2726d29ae3264b956e3da (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698