Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: talk/app/webrtc/mediaconstraintsinterface.h

Issue 1179233003: Add kGoogEchoCancellation to MediaConstraintsInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/app/webrtc/localaudiosource_unittest.cc ('k') | talk/app/webrtc/mediaconstraintsinterface.cc » ('j') | talk/app/webrtc/mediaconstraintsinterface.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/mediaconstraintsinterface.h
diff --git a/talk/app/webrtc/mediaconstraintsinterface.h b/talk/app/webrtc/mediaconstraintsinterface.h
index 31cc99622f203006c2f4d9b445fc317e4bfa554b..843bee071c44835a7c42de855eb5ca166c810dd4 100644
--- a/talk/app/webrtc/mediaconstraintsinterface.h
+++ b/talk/app/webrtc/mediaconstraintsinterface.h
@@ -73,7 +73,13 @@ class MediaConstraintsInterface {
// Constraint keys used by a local audio source.
// These keys are google specific.
+ // TODO(tommi): Change kEchoCancellation to be "echoCancellation" once
+ // Chrome has been updated to use kGoogEchoCancellation where the 'goog'
+ // variant is needed.
+ // See https://code.google.com/p/webrtc/issues/detail?id=4747
static const char kEchoCancellation[]; // googEchoCancellation
+ static const char kGoogEchoCancellation[]; // googEchoCancellation
+
// TODO(henrik.lundin) Remove kExperimentalEchoCancellation.
// https://code.google.com/p/webrtc/issues/detail?id=4696
static const char kExperimentalEchoCancellation[]; // googEchoCancellation2
« no previous file with comments | « talk/app/webrtc/localaudiosource_unittest.cc ('k') | talk/app/webrtc/mediaconstraintsinterface.cc » ('j') | talk/app/webrtc/mediaconstraintsinterface.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698