talk/app/webrtc/localaudiosource_unittest.cc - Issue 1179233003: Add kGoogEchoCancellation to MediaConstraintsInterface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/localaudiosource_unittest.cc

Issue 1179233003: Add kGoogEchoCancellation to MediaConstraintsInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/app/webrtc/localaudiosource_unittest.cc

diff --git a/talk/app/webrtc/localaudiosource_unittest.cc b/talk/app/webrtc/localaudiosource_unittest.cc

index 1c434203da800129ef74f6b35999fec2e6f20d26..7e5d8dea678557696ec4e476e69e4e4c095c95b0 100644

--- a/talk/app/webrtc/localaudiosource_unittest.cc

+++ b/talk/app/webrtc/localaudiosource_unittest.cc

@@ -43,7 +43,8 @@ using webrtc::PeerConnectionFactoryInterface;

TEST(LocalAudioSourceTest, SetValidOptions) {

webrtc::FakeConstraints constraints;

- constraints.AddMandatory(MediaConstraintsInterface::kEchoCancellation, false);

+ constraints.AddMandatory(

+ MediaConstraintsInterface::kGoogEchoCancellation, false);

constraints.AddOptional(

MediaConstraintsInterface::kExtendedFilterEchoCancellation, true);

constraints.AddOptional(MediaConstraintsInterface::kDAEchoCancellation, true);

@@ -133,8 +134,10 @@ TEST(LocalAudioSourceTest, OptionNotSet) {

TEST(LocalAudioSourceTest, MandatoryOverridesOptional) {

webrtc::FakeConstraints constraints;

- constraints.AddMandatory(MediaConstraintsInterface::kEchoCancellation, false);

- constraints.AddOptional(MediaConstraintsInterface::kEchoCancellation, true);

+ constraints.AddMandatory(

+ MediaConstraintsInterface::kGoogEchoCancellation, false);

+ constraints.AddOptional(

+ MediaConstraintsInterface::kGoogEchoCancellation, true);

rtc::scoped_refptr<LocalAudioSource> source =

LocalAudioSource::Create(PeerConnectionFactoryInterface::Options(),

« no previous file with comments | « talk/app/webrtc/localaudiosource.cc ('k') | talk/app/webrtc/mediaconstraintsinterface.h » ('j') | talk/app/webrtc/mediaconstraintsinterface.cc » ('J')