Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: talk/app/webrtc/mediaconstraintsinterface.cc

Issue 1179233003: Add kGoogEchoCancellation to MediaConstraintsInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/app/webrtc/mediaconstraintsinterface.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2013 Google Inc. 3 * Copyright 2013 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 30 matching lines...) Expand all
41 const char MediaConstraintsInterface::kMaxWidth[] = "maxWidth"; 41 const char MediaConstraintsInterface::kMaxWidth[] = "maxWidth";
42 const char MediaConstraintsInterface::kMinWidth[] = "minWidth"; 42 const char MediaConstraintsInterface::kMinWidth[] = "minWidth";
43 const char MediaConstraintsInterface::kMaxHeight[] = "maxHeight"; 43 const char MediaConstraintsInterface::kMaxHeight[] = "maxHeight";
44 const char MediaConstraintsInterface::kMinHeight[] = "minHeight"; 44 const char MediaConstraintsInterface::kMinHeight[] = "minHeight";
45 const char MediaConstraintsInterface::kMaxFrameRate[] = "maxFrameRate"; 45 const char MediaConstraintsInterface::kMaxFrameRate[] = "maxFrameRate";
46 const char MediaConstraintsInterface::kMinFrameRate[] = "minFrameRate"; 46 const char MediaConstraintsInterface::kMinFrameRate[] = "minFrameRate";
47 47
48 // Audio constraints. 48 // Audio constraints.
49 const char MediaConstraintsInterface::kEchoCancellation[] = 49 const char MediaConstraintsInterface::kEchoCancellation[] =
50 "googEchoCancellation"; 50 "googEchoCancellation";
51 const char MediaConstraintsInterface::kGoogEchoCancellation[] =
Andrew MacDonald 2015/06/15 06:58:54 Not for this CL of course, but should we change th
tommi 2015/06/15 07:12:51 Don't know if it's worth spending the time on it r
52 "googEchoCancellation";
51 const char MediaConstraintsInterface::kExperimentalEchoCancellation[] = 53 const char MediaConstraintsInterface::kExperimentalEchoCancellation[] =
52 "googEchoCancellation2"; 54 "googEchoCancellation2";
53 const char MediaConstraintsInterface::kExtendedFilterEchoCancellation[] = 55 const char MediaConstraintsInterface::kExtendedFilterEchoCancellation[] =
54 "googEchoCancellation2"; 56 "googEchoCancellation2";
55 const char MediaConstraintsInterface::kDAEchoCancellation[] = 57 const char MediaConstraintsInterface::kDAEchoCancellation[] =
56 "googDAEchoCancellation"; 58 "googDAEchoCancellation";
57 const char MediaConstraintsInterface::kAutoGainControl[] = 59 const char MediaConstraintsInterface::kAutoGainControl[] =
58 "googAutoGainControl"; 60 "googAutoGainControl";
59 const char MediaConstraintsInterface::kExperimentalAutoGainControl[] = 61 const char MediaConstraintsInterface::kExperimentalAutoGainControl[] =
60 "googAutoGainControl2"; 62 "googAutoGainControl2";
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 ++*mandatory_constraints; 160 ++*mandatory_constraints;
159 return rtc::FromString(string_value, value); 161 return rtc::FromString(string_value, value);
160 } 162 }
161 if (constraints->GetOptional().FindFirst(key, &string_value)) { 163 if (constraints->GetOptional().FindFirst(key, &string_value)) {
162 return rtc::FromString(string_value, value); 164 return rtc::FromString(string_value, value);
163 } 165 }
164 return false; 166 return false;
165 } 167 }
166 168
167 } // namespace webrtc 169 } // namespace webrtc
OLDNEW
« no previous file with comments | « talk/app/webrtc/mediaconstraintsinterface.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698