Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3020493002: Remove AudioDeviceObserver and make ADM not inherit from the Module interface.

Created:
3 years, 2 months ago by the sun
Modified:
3 years, 2 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove AudioDeviceObserver and make ADM not inherit from the Module interface. BUG=webrtc:4690

Patch Set 1 #

Patch Set 2 : linux build error #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -688 lines) Patch
M call/call_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/engine/apm_helpers_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/engine/webrtcvoiceengine_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M modules/audio_device/android/audio_device_template.h View 1 chunk +0 lines, -24 lines 0 comments Download
M modules/audio_device/audio_device_buffer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M modules/audio_device/audio_device_config.h View 1 chunk +0 lines, -1 line 0 comments Download
M modules/audio_device/audio_device_data_observer.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M modules/audio_device/audio_device_generic.h View 1 chunk +0 lines, -9 lines 0 comments Download
M modules/audio_device/audio_device_impl.h View 3 chunks +0 lines, -8 lines 0 comments Download
M modules/audio_device/audio_device_impl.cc View 3 chunks +1 line, -88 lines 0 comments Download
M modules/audio_device/dummy/audio_device_dummy.h View 1 chunk +0 lines, -9 lines 0 comments Download
M modules/audio_device/dummy/audio_device_dummy.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M modules/audio_device/dummy/file_audio_device.h View 1 chunk +0 lines, -9 lines 0 comments Download
M modules/audio_device/dummy/file_audio_device.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M modules/audio_device/include/audio_device.h View 2 chunks +2 lines, -2 lines 1 comment Download
M modules/audio_device/include/audio_device_defines.h View 1 chunk +0 lines, -16 lines 0 comments Download
M modules/audio_device/include/fake_audio_device.h View 1 chunk +0 lines, -3 lines 0 comments Download
M modules/audio_device/include/mock_audio_device.h View 1 chunk +1 line, -7 lines 0 comments Download
M modules/audio_device/ios/audio_device_ios.h View 1 chunk +0 lines, -8 lines 0 comments Download
M modules/audio_device/ios/audio_device_not_implemented_ios.mm View 1 chunk +0 lines, -16 lines 0 comments Download
M modules/audio_device/linux/audio_device_alsa_linux.h View 2 chunks +0 lines, -14 lines 0 comments Download
M modules/audio_device/linux/audio_device_alsa_linux.cc View 1 4 chunks +1 line, -59 lines 0 comments Download
M modules/audio_device/linux/audio_device_pulse_linux.h View 2 chunks +0 lines, -13 lines 0 comments Download
M modules/audio_device/linux/audio_device_pulse_linux.cc View 6 chunks +3 lines, -63 lines 0 comments Download
M modules/audio_device/mac/audio_device_mac.h View 2 chunks +0 lines, -14 lines 0 comments Download
M modules/audio_device/mac/audio_device_mac.cc View 5 chunks +0 lines, -49 lines 0 comments Download
M modules/audio_device/win/audio_device_core_win.h View 2 chunks +0 lines, -15 lines 0 comments Download
M modules/audio_device/win/audio_device_core_win.cc View 6 chunks +4 lines, -93 lines 0 comments Download
M modules/include/module.h View 1 chunk +0 lines, -18 lines 0 comments Download
M pc/test/fakeaudiocapturemodule.h View 2 chunks +0 lines, -13 lines 0 comments Download
M pc/test/fakeaudiocapturemodule.cc View 5 chunks +1 line, -31 lines 0 comments Download
M pc/test/fakeaudiocapturemodule_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M test/mock_voice_engine.h View 1 chunk +0 lines, -2 lines 0 comments Download
M voice_engine/voe_base_impl.h View 2 chunks +1 line, -6 lines 0 comments Download
M voice_engine/voe_base_impl.cc View 4 chunks +0 lines, -35 lines 0 comments Download

Depends on Patchset:

Issue 3020473002 Patch 40001

Messages

Total messages: 4 (1 generated)
the sun
3 years, 2 months ago (2017-09-25 10:38:18 UTC) #2
henrika_webrtc
Love it. Works in the world's most used browser as well I assume? lgtm
3 years, 2 months ago (2017-09-25 10:42:46 UTC) #3
henrika_webrtc
3 years, 2 months ago (2017-09-25 10:42:58 UTC) #4 
https://codereview.webrtc.org/3020493002/diff/20001/modules/audio_device/incl...
File modules/audio_device/include/audio_device.h (right):

https://codereview.webrtc.org/3020493002/diff/20001/modules/audio_device/incl...
modules/audio_device/include/audio_device.h:21: class AudioDeviceModule : public
rtc::RefCountInterface {
Me like ;-)

Powered by Google App Engine
This is Rietveld 408576698