Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: voice_engine/voe_base_impl.h

Issue 3020493002: Remove AudioDeviceObserver and make ADM not inherit from the Module interface.
Patch Set: linux build error Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: voice_engine/voe_base_impl.h
diff --git a/voice_engine/voe_base_impl.h b/voice_engine/voe_base_impl.h
index d03a1997c46f2d75bf96bbc54a6c83d50c0532ed..a3c4c1f40fbc63d4539e2c4d95b8e7d32fd954e8 100644
--- a/voice_engine/voe_base_impl.h
+++ b/voice_engine/voe_base_impl.h
@@ -22,8 +22,7 @@ namespace webrtc {
class ProcessThread;
class VoEBaseImpl : public VoEBase,
- public AudioTransport,
- public AudioDeviceObserver {
+ public AudioTransport {
public:
int Init(
AudioDeviceModule* external_adm,
@@ -81,10 +80,6 @@ class VoEBaseImpl : public VoEBase,
int64_t* elapsed_time_ms,
int64_t* ntp_time_ms) override;
- // AudioDeviceObserver
- void OnErrorIsReported(const ErrorCode error) override;
- void OnWarningIsReported(const WarningCode warning) override;
-
protected:
VoEBaseImpl(voe::SharedData* shared);
~VoEBaseImpl() override;

Powered by Google App Engine
This is Rietveld 408576698