Remove various IDs

Remove various IDs:

- AudioFrame
- AudioCodingModule

BUG=webrtc:4690
TBR=kwiberg@webrtc.org

Review-Url: https://codereview.webrtc.org/3019543002
Cr-Original-Commit-Position: refs/heads/master@{#20005}
Committed: https://webrtc.googlesource.com/src/+/2d0f77585d556d8b11d6269d35149ae9ca14c472
Review-Url: https://codereview.webrtc.org/3019543002
Cr-Commit-Position: refs/heads/master@{#20019}
Committed: https://webrtc.googlesource.com/src/+/c7b4a45594cb8a5efb8a1aada03810e4d250263c

[the sun, 2017-09-22 20:11:09]

solenberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2017-09-25 06:36:49]

LGMT, but...

1. You have some changes that seem unrelated to me.
2. Delete or TODO/deprecate AudioCodingModule::Config::id
(https://cs.chromium.org/chromium/src/third_party/webrtc/modules/audio_coding/...).
3. You've got downstream issues, which might get worse by fixing 2.

But still, fantastic!

https://codereview.webrtc.org/3019543002/diff/20001/voice_engine/voice_engine...
File voice_engine/voice_engine_defines.h (left):

https://codereview.webrtc.org/3019543002/diff/20001/voice_engine/voice_engine...
voice_engine/voice_engine_defines.h:28: // Min scale factor for per-channel
volume scaling
Is this related?

https://codereview.webrtc.org/3019543002/diff/20001/voice_engine/voice_engine...
voice_engine/voice_engine_defines.h:51: const GainControl::Mode
kDefaultRxAgcMode = GainControl::kAdaptiveDigital;
And this?

[the sun, 2017-09-26 21:57:44]

Description was changed from

==========
Remove various IDs:

- AudioFrame
- AudioCodingModule

BUG=webrtc:4690
==========

to

==========
Remove various IDs:

- AudioFrame
- AudioCodingModule

BUG=webrtc:4690
==========

[the sun, 2017-09-26 21:57:44]

solenberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[the sun, 2017-09-26 21:59:02]

On 2017/09/25 06:36:49, hlundin-webrtc wrote:
> LGMT, but...
> 
> 1. You have some changes that seem unrelated to me.

I'd like to keep them - it's just deleting unused things from
voice_engine_defines.h

> 2. Delete or TODO/deprecate AudioCodingModule::Config::id
>
(https://cs.chromium.org/chromium/src/third_party/webrtc/modules/audio_coding/...).

Done.

> 3. You've got downstream issues, which might get worse by fixing 2.

Should be fixed soon.

> But still, fantastic!
> 
>
https://codereview.webrtc.org/3019543002/diff/20001/voice_engine/voice_engine...
> File voice_engine/voice_engine_defines.h (left):
> 
>
https://codereview.webrtc.org/3019543002/diff/20001/voice_engine/voice_engine...
> voice_engine/voice_engine_defines.h:28: // Min scale factor for per-channel
> volume scaling
> Is this related?
> 
>
https://codereview.webrtc.org/3019543002/diff/20001/voice_engine/voice_engine...
> voice_engine/voice_engine_defines.h:51: const GainControl::Mode
> kDefaultRxAgcMode = GainControl::kAdaptiveDigital;
> And this?

Only in the sense of trying to remove as much as possible from
voice_engine_defines.h.

[hlundin-webrtc, 2017-09-27 06:08:38]

Great! LGTM.

I believe these were the last traces of the base class Module to be removed from
ACM.

[the sun, 2017-09-27 17:01:52]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2017-09-27 17:01:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3019543002/#ps120001 (title:
"rebase")

[commit-bot: I haz the power, 2017-09-27 17:01:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[the sun, 2017-09-27 17:05:17]

Description was changed from

==========
Remove various IDs:

- AudioFrame
- AudioCodingModule

BUG=webrtc:4690
==========

to

==========
Remove various IDs:

- AudioFrame
- AudioCodingModule

BUG=webrtc:4690
TBR=kwiberg@webrtc.org
==========

[the sun, 2017-09-27 17:05:55]

On 2017/09/27 17:01:57, commit-bot: I haz the power wrote:
> CQ is trying da patch.
> 
> Follow status at:
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

TBR Karl for module_common_types.h and module_common_types_unittest.cc; I want
to land before Rietveld shut down.

[commit-bot: I haz the power, 2017-09-27 17:33:58]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1506531712150370,
"parent_rev": "94286cb25c3e90f7ab5bb90dbaf0d814ba1e5408", "commit_rev":
"2d0f77585d556d8b11d6269d35149ae9ca14c472"}

[commit-bot: I haz the power, 2017-09-27 17:34:02]

Description was changed from

==========
Remove various IDs:

- AudioFrame
- AudioCodingModule

BUG=webrtc:4690
TBR=kwiberg@webrtc.org
==========

to

==========
Remove various IDs:

- AudioFrame
- AudioCodingModule

BUG=webrtc:4690
TBR=kwiberg@webrtc.org

Review-Url: https://codereview.webrtc.org/3019543002
Cr-Commit-Position: refs/heads/master@{#20005}
Committed:
https://webrtc.googlesource.com/src/+/2d0f77585d556d8b11d6269d35149ae9ca14c472
==========

[commit-bot: I haz the power, 2017-09-27 17:34:04]

Committed patchset #7 (id:120001) as
https://webrtc.googlesource.com/src/+/2d0f77585d556d8b11d6269d35149ae9ca14c472

[the sun, 2017-09-27 18:27:58]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.webrtc.org/3014683002/ by solenberg@webrtc.org.

The reason for reverting is: Breaks downstream.

[the sun, 2017-09-28 13:44:49]

Description was changed from

==========
Remove various IDs:

- AudioFrame
- AudioCodingModule

BUG=webrtc:4690
TBR=kwiberg@webrtc.org

Review-Url: https://codereview.webrtc.org/3019543002
Cr-Commit-Position: refs/heads/master@{#20005}
Committed:
https://webrtc.googlesource.com/src/+/2d0f77585d556d8b11d6269d35149ae9ca14c472
==========

to

==========
Remove various IDs:

- AudioFrame
- AudioCodingModule

BUG=webrtc:4690
TBR=kwiberg@webrtc.org

Review-Url: https://codereview.webrtc.org/3019543002
Cr-Commit-Position: refs/heads/master@{#20005}
Committed:
https://webrtc.googlesource.com/src/+/2d0f77585d556d8b11d6269d35149ae9ca14c472
==========

[the sun, 2017-09-28 13:46:58]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2017-09-28 13:46:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3019543002/#ps140001 (title:
"rebase+build error")

[commit-bot: I haz the power, 2017-09-28 13:47:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-28 14:37:12]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1506606418725570,
"parent_rev": "3935c34cbc1d2c3f0bc79715381925404bbeeaf6", "commit_rev":
"c7b4a45594cb8a5efb8a1aada03810e4d250263c"}

[commit-bot: I haz the power, 2017-09-28 14:37:17]

Description was changed from

==========
Remove various IDs:

- AudioFrame
- AudioCodingModule

BUG=webrtc:4690
TBR=kwiberg@webrtc.org

Review-Url: https://codereview.webrtc.org/3019543002
Cr-Commit-Position: refs/heads/master@{#20005}
Committed:
https://webrtc.googlesource.com/src/+/2d0f77585d556d8b11d6269d35149ae9ca14c472
==========

to

==========
Remove various IDs:

- AudioFrame
- AudioCodingModule

BUG=webrtc:4690
TBR=kwiberg@webrtc.org

Review-Url: https://codereview.webrtc.org/3019543002
Cr-Original-Commit-Position: refs/heads/master@{#20005}
Committed:
https://webrtc.googlesource.com/src/+/2d0f77585d556d8b11d6269d35149ae9ca14c472
Review-Url: https://codereview.webrtc.org/3019543002
Cr-Commit-Position: refs/heads/master@{#20019}
Committed:
https://webrtc.googlesource.com/src/+/c7b4a45594cb8a5efb8a1aada03810e4d250263c
==========

[commit-bot: I haz the power, 2017-09-28 14:37:18]

Committed patchset #8 (id:140001) as
https://webrtc.googlesource.com/src/+/c7b4a45594cb8a5efb8a1aada03810e4d250263c