Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 3014683002: Revert of Remove various IDs (Closed)

Created:
3 years, 2 months ago by the sun
Modified:
3 years, 2 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove various IDs (patchset #7 id:120001 of https://codereview.webrtc.org/3019543002/ ) Reason for revert: Breaks downstream Original issue's description: > Remove various IDs: > > - AudioFrame > - AudioCodingModule > > BUG=webrtc:4690 > TBR=kwiberg@webrtc.org > > Review-Url: https://codereview.webrtc.org/3019543002 > Cr-Commit-Position: refs/heads/master@{#20005} > Committed: https://webrtc.googlesource.com/src/+/2d0f77585d556d8b11d6269d35149ae9ca14c472 TBR=henrik.lundin@webrtc.org,kwiberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/3014683002 Cr-Commit-Position: refs/heads/master@{#20008} Committed: https://webrtc.googlesource.com/src/+/e423a9de93082049029634081b5d7012521db573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -52 lines) Patch
M modules/audio_coding/acm2/acm_receive_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M modules/audio_coding/acm2/acm_send_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M modules/audio_coding/acm2/audio_coding_module.cc View 5 chunks +9 lines, -4 lines 0 comments Download
M modules/audio_coding/acm2/audio_coding_module_unittest.cc View 4 chunks +5 lines, -2 lines 0 comments Download
M modules/audio_coding/include/audio_coding_module.h View 2 chunks +3 lines, -2 lines 0 comments Download
M modules/audio_coding/test/APITest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M modules/audio_coding/test/EncodeDecodeTest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M modules/audio_coding/test/PacketLossTest.cc View 1 chunk +1 line, -1 line 0 comments Download
M modules/audio_coding/test/TestAllCodecs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M modules/audio_coding/test/TestRedFec.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M modules/audio_coding/test/TestStereo.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M modules/audio_coding/test/TestVADDTX.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M modules/audio_coding/test/TwoWayCommunication.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M modules/audio_coding/test/delay_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M modules/audio_coding/test/iSACTest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M modules/audio_coding/test/insert_packet_with_timing.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M modules/audio_coding/test/opus_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M modules/audio_coding/test/target_delay_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M modules/audio_mixer/audio_mixer_impl_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M modules/audio_mixer/frame_combiner.cc View 1 chunk +1 line, -1 line 0 comments Download
M modules/audio_mixer/frame_combiner_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M modules/include/module_common_types.h View 5 chunks +7 lines, -13 lines 0 comments Download
M modules/module_common_types_unittest.cc View 5 chunks +7 lines, -4 lines 0 comments Download
M voice_engine/channel.cc View 5 chunks +6 lines, -0 lines 0 comments Download
M voice_engine/voice_engine_defines.h View 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
the sun
Created Revert of Remove various IDs
3 years, 2 months ago (2017-09-27 18:27:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3014683002/1
3 years, 2 months ago (2017-09-27 18:28:04 UTC) #3
commit-bot: I haz the power
3 years, 2 months ago (2017-09-27 18:28:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://webrtc.googlesource.com/src/+/e423a9de93082049029634081b5d7012521db573

Powered by Google App Engine
This is Rietveld 408576698