Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 3018523002: Clean out unused methods from VoiceEngine and VoEBase. (Closed)

Created:
3 years, 3 months ago by the sun
Modified:
3 years, 3 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clean out unused methods from VoiceEngine and VoEBase. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/3018523002 Cr-Commit-Position: refs/heads/master@{#19880} Committed: https://webrtc.googlesource.com/src/+/35dee8132185f981ff6285f1c9797414de62d9bd

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -325 lines) Patch
M media/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/engine/fakewebrtcvoiceengine.h View 1 chunk +0 lines, -6 lines 0 comments Download
D media/engine/webrtccommon.h View 1 chunk +0 lines, -58 lines 0 comments Download
M media/engine/webrtcvoe.h View 2 chunks +0 lines, -3 lines 0 comments Download
M media/engine/webrtcvoiceengine.h View 3 chunks +0 lines, -3 lines 0 comments Download
M media/engine/webrtcvoiceengine.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M test/mock_voice_engine.h View 1 chunk +0 lines, -6 lines 0 comments Download
M voice_engine/include/voe_base.h View 3 chunks +0 lines, -33 lines 0 comments Download
D voice_engine/mock/mock_voe_observer.h View 1 chunk +0 lines, -29 lines 0 comments Download
M voice_engine/statistics.h View 1 chunk +0 lines, -1 line 0 comments Download
M voice_engine/statistics.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M voice_engine/voe_base_impl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M voice_engine/voe_base_impl.cc View 3 chunks +0 lines, -61 lines 0 comments Download
M voice_engine/voe_base_unittest.cc View 2 chunks +22 lines, -43 lines 0 comments Download
M voice_engine/voice_engine_defines.h View 1 chunk +0 lines, -5 lines 0 comments Download
M voice_engine/voice_engine_fixture.h View 2 chunks +0 lines, -2 lines 0 comments Download
M voice_engine/voice_engine_fixture.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M voice_engine/voice_engine_impl.cc View 2 chunks +0 lines, -43 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
the sun
3 years, 3 months ago (2017-09-18 07:20:08 UTC) #2
kwiberg-webrtc
lgtm
3 years, 3 months ago (2017-09-18 07:24:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3018523002/20001
3 years, 3 months ago (2017-09-18 08:12:44 UTC) #6
commit-bot: I haz the power
3 years, 3 months ago (2017-09-18 08:57:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://webrtc.googlesource.com/src/+/35dee8132185f981ff6285f1c9797414de62d9bd

Powered by Google App Engine
This is Rietveld 408576698