Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: voice_engine/voe_base_impl.cc

Issue 3018523002: Clean out unused methods from VoiceEngine and VoEBase. (Closed)
Patch Set: rebase Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « voice_engine/voe_base_impl.h ('k') | voice_engine/voe_base_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: voice_engine/voe_base_impl.cc
diff --git a/voice_engine/voe_base_impl.cc b/voice_engine/voe_base_impl.cc
index 50611df77e955fac805b8bf5e21a04d07d22b178..8768b324b9869a1be51293f04ed2a7dbdf97a8a9 100644
--- a/voice_engine/voe_base_impl.cc
+++ b/voice_engine/voe_base_impl.cc
@@ -468,22 +468,6 @@ int VoEBaseImpl::DeleteChannel(int channel) {
return 0;
}
-int VoEBaseImpl::StartReceive(int channel) {
- rtc::CritScope cs(shared_->crit_sec());
- if (!shared_->statistics().Initialized()) {
- shared_->SetLastError(VE_NOT_INITED, kTraceError);
- return -1;
- }
- voe::ChannelOwner ch = shared_->channel_manager().GetChannel(channel);
- voe::Channel* channelPtr = ch.channel();
- if (channelPtr == nullptr) {
- shared_->SetLastError(VE_CHANNEL_NOT_VALID, kTraceError,
- "StartReceive() failed to locate channel");
- return -1;
- }
- return 0;
-}
-
int VoEBaseImpl::StartPlayout(int channel) {
rtc::CritScope cs(shared_->crit_sec());
if (!shared_->statistics().Initialized()) {
@@ -569,22 +553,6 @@ int VoEBaseImpl::StopSend(int channel) {
return StopSend();
}
-int VoEBaseImpl::GetVersion(char version[1024]) {
- if (version == nullptr) {
- shared_->SetLastError(VE_INVALID_ARGUMENT, kTraceError);
- return -1;
- }
-
- std::string versionString = VoiceEngine::GetVersionString();
- RTC_DCHECK_GT(1024, versionString.size() + 1);
- char* end = std::copy(versionString.cbegin(), versionString.cend(), version);
- end[0] = '\n';
- end[1] = '\0';
- return 0;
-}
-
-int VoEBaseImpl::LastError() { return (shared_->statistics().LastError()); }
-
int32_t VoEBaseImpl::StartPlayout() {
if (!shared_->audio_device()->Playing()) {
if (shared_->audio_device()->InitPlayout() != 0) {
@@ -716,33 +684,4 @@ void VoEBaseImpl::GetPlayoutData(int sample_rate, size_t number_of_channels,
*ntp_time_ms = audioFrame_.ntp_time_ms_;
}
-int VoEBaseImpl::AssociateSendChannel(int channel,
- int accociate_send_channel) {
- rtc::CritScope cs(shared_->crit_sec());
-
- if (!shared_->statistics().Initialized()) {
- shared_->SetLastError(VE_NOT_INITED, kTraceError);
- return -1;
- }
-
- voe::ChannelOwner ch = shared_->channel_manager().GetChannel(channel);
- voe::Channel* channel_ptr = ch.channel();
- if (channel_ptr == NULL) {
- shared_->SetLastError(VE_CHANNEL_NOT_VALID, kTraceError,
- "AssociateSendChannel() failed to locate channel");
- return -1;
- }
-
- ch = shared_->channel_manager().GetChannel(accociate_send_channel);
- voe::Channel* accociate_send_channel_ptr = ch.channel();
- if (accociate_send_channel_ptr == NULL) {
- shared_->SetLastError(VE_CHANNEL_NOT_VALID, kTraceError,
- "AssociateSendChannel() failed to locate accociate_send_channel");
- return -1;
- }
-
- channel_ptr->set_associate_send_channel(ch);
- return 0;
-}
-
} // namespace webrtc
« no previous file with comments | « voice_engine/voe_base_impl.h ('k') | voice_engine/voe_base_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698