Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 3017433002: Android: Improve handling of RGB texture frames (Closed)

Created:
1 year, 6 months ago by magjed_webrtc
Modified:
1 year, 6 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Improve handling of RGB texture frames In the transition period when we have both VideoRenderer.Callbacks and VideoSinks, and VideoRenderer.I420Frames and VideoFrames, the adapters between them does not handle RGB frames correctly. This CL improves the situation somewhat, and at least gives clearer error messages. BUG=webrtc:7749 Review-Url: https://codereview.webrtc.org/3017433002 Cr-Commit-Position: refs/heads/master@{#19817} Committed: https://chromium.googlesource.com/external/webrtc/+/2ab9879af0ef661b9afde3f1a56ef7073c4006cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M webrtc/sdk/android/api/org/webrtc/VideoRenderer.java View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/TextureBufferImpl.java View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
magjed_webrtc
Sami - please take a look.
1 year, 6 months ago (2017-09-13 11:18:33 UTC) #5
sakal
lgtm
1 year, 6 months ago (2017-09-13 11:22:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3017433002/1
1 year, 6 months ago (2017-09-13 12:18:04 UTC) #10
commit-bot: I haz the power
1 year, 6 months ago (2017-09-13 12:20:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/2ab9879af0ef661b9afde3f1a...

Powered by Google App Engine
This is Rietveld 408576698