Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 3016443002: Android AppRTCMobile: Transition local render to new VideoSink interface (Closed)

Created:
3 years, 3 months ago by magjed_webrtc
Modified:
3 years, 3 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android AppRTCMobile: Transition local render to new VideoSink interface BUG=None Review-Url: https://codereview.webrtc.org/3016443002 Cr-Commit-Position: refs/heads/master@{#19820} Committed: https://chromium.googlesource.com/external/webrtc/+/4e15e67da8072e8ce7b70c32df3c4be286363ab4

Patch Set 1 #

Patch Set 2 : Track previous CL #

Patch Set 3 : Update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -14 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java View 3 chunks +17 lines, -3 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 4 chunks +5 lines, -4 lines 0 comments Download
M webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java View 1 2 8 chunks +52 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (10 generated)
magjed_webrtc
Sami - please take a look.
3 years, 3 months ago (2017-09-13 12:23:16 UTC) #4
sakal
lgtm
3 years, 3 months ago (2017-09-13 12:31:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3016443002/20001
3 years, 3 months ago (2017-09-13 12:51:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg/builds/17828)
3 years, 3 months ago (2017-09-13 13:02:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3016443002/40001
3 years, 3 months ago (2017-09-13 13:30:05 UTC) #13
commit-bot: I haz the power
3 years, 3 months ago (2017-09-13 14:11:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/4e15e67da8072e8ce7b70c32d...

Powered by Google App Engine
This is Rietveld 408576698