Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 3016633002: Reland of Fix the video buffer size should take rtt into consideration (Closed)

Created:
3 years, 2 months ago by philipel
Modified:
3 years, 2 months ago
Reviewers:
sprang_webrtc, ggarber
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Fix the video buffer size should take rtt into consideration (patchset #2 id:160001 of https://codereview.chromium.org/3002033002/ ) Reason for revert: Fixes has landed. Original issue's description: > Revert of Fix the video buffer size should take rtt into consideration (patchset #3 id:40001 of https://codereview.chromium.org/2980413002/ ) > > Reason for revert: > We are not certain this is the behavior we want. > > Original issue's description: > > Fix the video buffer size should take rtt into consideration > > > > BUG=webrtc:8010 > > > > Review-Url: https://codereview.webrtc.org/2980413002 > > Cr-Commit-Position: refs/heads/master@{#19285} > > Committed: https://chromium.googlesource.com/external/webrtc/+/f1e08d0b5848d32fd31c5b6e4e570115c32b7ce5 > > TBR=sprang@webrtc.org,gustavogb@gmail.com > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:8010 > > Review-Url: https://codereview.webrtc.org/3002033002 > Cr-Commit-Position: refs/heads/master@{#19442} > Committed: https://chromium.googlesource.com/external/webrtc/+/bdbc8895f3a630a4fe28d4661d8e71877ecaf14d TBR=sprang@webrtc.org,gustavogb@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:8010 Review-Url: https://codereview.webrtc.org/3016633002 Cr-Commit-Position: refs/heads/master@{#19944} Committed: https://webrtc.googlesource.com/src/+/e21be1db4c04d35f90a86ca2376862e58f026602

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M modules/video_coding/frame_buffer2.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M modules/video_coding/frame_buffer2.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M video/video_receive_stream.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M video/video_receive_stream.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
philipel
Created Reland of Fix the video buffer size should take rtt into consideration
3 years, 2 months ago (2017-09-25 12:18:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3016633002/1
3 years, 2 months ago (2017-09-25 12:19:59 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/25227) mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 2 months ago (2017-09-25 12:21:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3016633002/160001
3 years, 2 months ago (2017-09-25 13:34:29 UTC) #11
commit-bot: I haz the power
3 years, 2 months ago (2017-09-25 13:37:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:160001) as
https://webrtc.googlesource.com/src/+/e21be1db4c04d35f90a86ca2376862e58f026602

Powered by Google App Engine
This is Rietveld 408576698