Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 3002033002: Revert of Fix the video buffer size should take rtt into consideration (Closed)

Created:
3 years, 4 months ago by philipel
Modified:
3 years, 4 months ago
Reviewers:
sprang_webrtc, ggarber
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fix the video buffer size should take rtt into consideration (patchset #3 id:40001 of https://codereview.chromium.org/2980413002/ ) Reason for revert: We are not certain this is the behavior we want. Original issue's description: > Fix the video buffer size should take rtt into consideration > > BUG=webrtc:8010 > > Review-Url: https://codereview.webrtc.org/2980413002 > Cr-Commit-Position: refs/heads/master@{#19285} > Committed: https://chromium.googlesource.com/external/webrtc/+/f1e08d0b5848d32fd31c5b6e4e570115c32b7ce5 TBR=sprang@webrtc.org,gustavogb@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:8010 Review-Url: https://codereview.webrtc.org/3002033002 Cr-Commit-Position: refs/heads/master@{#19442} Committed: https://chromium.googlesource.com/external/webrtc/+/bdbc8895f3a630a4fe28d4661d8e71877ecaf14d

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
M AUTHORS View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/frame_buffer2.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
philipel
Created Revert of Fix the video buffer size should take rtt into consideration
3 years, 4 months ago (2017-08-21 12:25:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3002033002/1
3 years, 4 months ago (2017-08-21 12:25:36 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/27222) mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 4 months ago (2017-08-21 12:28:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3002033002/160001
3 years, 4 months ago (2017-08-21 12:35:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/26744)
3 years, 4 months ago (2017-08-21 13:52:38 UTC) #10
sprang_webrtc
rs lgtm
3 years, 4 months ago (2017-08-22 08:47:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3002033002/160001
3 years, 4 months ago (2017-08-22 08:50:38 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:160001) as https://chromium.googlesource.com/external/webrtc/+/bdbc8895f3a630a4fe28d4661d8e71877ecaf14d
3 years, 4 months ago (2017-08-22 09:08:58 UTC) #16
philipel
3 years, 2 months ago (2017-09-25 12:18:58 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:160001) has been created in
https://codereview.chromium.org/3016633002/ by philipel@webrtc.org.

The reason for reverting is: Fixes has landed..

Powered by Google App Engine
This is Rietveld 408576698