Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 3016593002: Revert of Add full stack tests for MediaCodec. (Closed)

Created:
1 year, 2 months ago by brandtr
Modified:
1 year, 2 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add full stack tests for MediaCodec. (patchset #10 id:180001 of https://codereview.webrtc.org/3005253002/ ) Reason for revert: Breaks KitKat/Lollipop perf bots. Original issue's description: > Add full stack tests for MediaCodec encoder. > > * Add audio_ prefix to CallTest::{en,de}coder_factory_. > * Let VideoQualityTest only instantiate encoders using encoder factories. > * Add HW encoder factories to VideoQualityTest. > * Add full stack tests: > - sqcif7 at 30 kbps: MediaCodec and libvpx. > - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx. > > BUG=webrtc:8219 > > Review-Url: https://codereview.webrtc.org/3005253002 > Cr-Commit-Position: refs/heads/master@{#19923} > Committed: https://webrtc.googlesource.com/src/+/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa TBR=sprang@webrtc.org,asapersson@webrtc.org,kjellander@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:8219 Review-Url: https://codereview.webrtc.org/3016593002 Cr-Commit-Position: refs/heads/master@{#19926} Committed: https://webrtc.googlesource.com/src/+/2c30120fac1e1cbdab89e459ac6256d198bf291d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -475 lines) Patch
M BUILD.gn View 2 chunks +1 line, -9 lines 0 comments Download
M call/call_perf_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M modules/video_coding/BUILD.gn View 3 chunks +10 lines, -19 lines 0 comments Download
M test/call_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/call_test.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M video/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
M video/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M video/full_stack_tests.cc View 42 chunks +124 lines, -370 lines 0 comments Download
M video/screenshare_loopback.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M video/video_loopback.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M video/video_quality_test.h View 3 chunks +1 line, -4 lines 0 comments Download
M video/video_quality_test.cc View 7 chunks +41 lines, -49 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
brandtr
Created Revert of Add full stack tests for MediaCodec.
1 year, 2 months ago (2017-09-22 11:29:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3016593002/1
1 year, 2 months ago (2017-09-22 11:30:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://webrtc.googlesource.com/src/+/2c30120fac1e1cbdab89e459ac6256d198bf291d
1 year, 2 months ago (2017-09-22 11:30:14 UTC) #6
brandtr
1 year, 2 months ago (2017-09-29 06:35:04 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/3019593002/ by brandtr@webrtc.org.

The reason for reverting is: Will disable the failing tests and then reland..

Powered by Google App Engine
This is Rietveld 408576698