Add full stack tests for MediaCodec.

Add full stack tests for MediaCodec encoder.

* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate encoders using encoder factories.
* Add HW encoder factories to VideoQualityTest.
* Add full stack tests:
  - sqcif7 at  30 kbps: MediaCodec and libvpx.
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx.

BUG=webrtc:8219
Review-Url: https://codereview.webrtc.org/3005253002
Cr-Commit-Position: refs/heads/master@{#19923}
Committed: https://webrtc.googlesource.com/src/+/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa

[brandtr, 2017-09-08 08:49:28]

Description was changed from

==========
Add full stack tests for MediaCodec encoder.

* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate codecs using factories.
* Add support for HW codecs to VideoQualityTest.
* Add full stack tests:
  - sqcif15 at 30 kbps: MediaCodec and libvpx
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx

BUG=webrtc:8219
==========

to

==========
Add full stack tests for MediaCodec encoder.

* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate codecs using factories.
* Add HW codec factories to VideoQualityTest.
* Add full stack tests:
  - sqcif15 at 30 kbps: MediaCodec and libvpx
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx

BUG=webrtc:8219
==========

[brandtr, 2017-09-08 08:49:51]

Description was changed from

==========
Add full stack tests for MediaCodec encoder.

* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate codecs using factories.
* Add HW codec factories to VideoQualityTest.
* Add full stack tests:
  - sqcif15 at 30 kbps: MediaCodec and libvpx
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx

BUG=webrtc:8219
==========

to

==========
Add full stack tests for MediaCodec.

* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate codecs using factories.
* Add HW codec factories to VideoQualityTest.
* Add full stack tests:
  - sqcif15 at 30 kbps: MediaCodec and libvpx
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx

BUG=webrtc:8219
==========

[brandtr, 2017-09-08 08:56:45]

Description was changed from

==========
Add full stack tests for MediaCodec.

* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate codecs using factories.
* Add HW codec factories to VideoQualityTest.
* Add full stack tests:
  - sqcif15 at 30 kbps: MediaCodec and libvpx
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx

BUG=webrtc:8219
==========

to

==========
Add full stack tests for MediaCodec encoder.

* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate encoders using encoder factories.
* Add HW encoder factories to VideoQualityTest.
* Add full stack tests:
  - sqcif15 at 30 kbps: MediaCodec and libvpx
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx

BUG=webrtc:8219
==========

[brandtr, 2017-09-08 11:31:14]

brandtr@webrtc.org changed reviewers:
+ asapersson@webrtc.org, kjellander@webrtc.org, sprang@webrtc.org

[brandtr, 2017-09-08 11:31:15]

Please take a look :)

sprang: General review, but focus on VideoQualityTest
asapersson: FullStackTest.Foreman240p100kbpsMediaCodecWithForcedSwFallback
kjellander: BUILD files + _java dep workaround.

https://codereview.webrtc.org/3005253002/diff/1/webrtc/video/full_stack_tests.cc
File webrtc/video/full_stack_tests.cc (right):

https://codereview.webrtc.org/3005253002/diff/1/webrtc/video/full_stack_tests...
webrtc/video/full_stack_tests.cc:257: TEST_F(FullStackTest,
ForemanSqcif30kbpsLibvpx) {
I'm not fully convinced that the settings selected in these tests are the most
relevant, but it's a start. I'm open for suggestions here.

https://codereview.webrtc.org/3005253002/diff/1/webrtc/video/full_stack_tests...
webrtc/video/full_stack_tests.cc:399: conf_motion_hd.video = {true,
git cl format made me do it...

https://codereview.webrtc.org/3005253002/diff/1/webrtc/video/video_quality_te...
File webrtc/video/video_quality_test.cc (right):

https://codereview.webrtc.org/3005253002/diff/1/webrtc/video/video_quality_te...
webrtc/video/video_quality_test.cc:1490:
CreateMatchingReceiveConfigs(recv_transport);
The decoder is instantiated during this call. Adding support for HW decode thus
requires a bit more work, and can be done in a followup CL.

[kjellander_webrtc, 2017-09-08 12:36:39]

lgtm with two comments

https://codereview.webrtc.org/3005253002/diff/1/webrtc/modules/video_coding/B...
File webrtc/modules/video_coding/BUILD.gn (right):

https://codereview.webrtc.org/3005253002/diff/1/webrtc/modules/video_coding/B...
webrtc/modules/video_coding/BUILD.gn:370:
rtc_source_set("video_coding_codecs_test_android_test_initializer") {
I'd suggest a shorter target name, e.g. codecs_test_android_test_initializer
since the dir it sits in is called video_coding

https://codereview.webrtc.org/3005253002/diff/1/webrtc/video/DEPS
File webrtc/video/DEPS (right):

https://codereview.webrtc.org/3005253002/diff/1/webrtc/video/DEPS#newcode23
webrtc/video/DEPS:23: "+webrtc/sdk",
Do we need to be this strict? If webrtc/sdk is considered being fine to depend
on (which I guess it is, or?) it should be in the list above.

[åsapersson, 2017-09-11 09:28:44]

lgtm

https://codereview.webrtc.org/3005253002/diff/1/webrtc/test/call_test.cc
File webrtc/test/call_test.cc (right):

https://codereview.webrtc.org/3005253002/diff/1/webrtc/test/call_test.cc#newc...
webrtc/test/call_test.cc:431: audio_decoder_factory_.get()));
audio_decoder_factory_?

https://codereview.webrtc.org/3005253002/diff/1/webrtc/test/call_test.cc#newc...
webrtc/test/call_test.cc:441: audio_decoder_factory_.get()));
same here

https://codereview.webrtc.org/3005253002/diff/1/webrtc/video/full_stack_tests.cc
File webrtc/video/full_stack_tests.cc (right):

https://codereview.webrtc.org/3005253002/diff/1/webrtc/video/full_stack_tests...
webrtc/video/full_stack_tests.cc:307: char field_trial[100];
maybe std::string

[brandtr, 2017-09-11 14:22:54]

Rebase.

[sprang_webrtc, 2017-09-12 13:08:47]

lgtm

https://codereview.webrtc.org/3005253002/diff/20001/webrtc/video/full_stack_t...
File webrtc/video/full_stack_tests.cc (right):

https://codereview.webrtc.org/3005253002/diff/20001/webrtc/video/full_stack_t...
webrtc/video/full_stack_tests.cc:590: "ConferenceMotion_1280_720_50"};
Weird formatting. Is this clang-format's fault?

[brandtr, 2017-09-13 08:59:31]

Rebase.

[brandtr, 2017-09-13 09:50:52]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-13 09:50:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-13 10:22:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-13 10:22:45]

Dry run: This issue passed the CQ dry run.

[brandtr, 2017-09-13 11:15:16]

Description was changed from

==========
Add full stack tests for MediaCodec encoder.

* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate encoders using encoder factories.
* Add HW encoder factories to VideoQualityTest.
* Add full stack tests:
  - sqcif15 at 30 kbps: MediaCodec and libvpx
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx

BUG=webrtc:8219
==========

to

==========
Add full stack tests for MediaCodec encoder.

* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate encoders using encoder factories.
* Add HW encoder factories to VideoQualityTest.
* Add full stack tests:
  - sqcif7 at 30 kbps: MediaCodec and libvpx
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx

BUG=webrtc:8219
==========

[brandtr, 2017-09-13 11:17:24]

Addressed comments.

https://codereview.webrtc.org/3005253002/diff/1/webrtc/modules/video_coding/B...
File webrtc/modules/video_coding/BUILD.gn (right):

https://codereview.webrtc.org/3005253002/diff/1/webrtc/modules/video_coding/B...
webrtc/modules/video_coding/BUILD.gn:370:
rtc_source_set("video_coding_codecs_test_android_test_initializer") {
On 2017/09/08 12:36:39, kjellander_webrtc wrote:
> I'd suggest a shorter target name, e.g. codecs_test_android_test_initializer
> since the dir it sits in is called video_coding

Good idea, done.

https://codereview.webrtc.org/3005253002/diff/1/webrtc/test/call_test.cc
File webrtc/test/call_test.cc (right):

https://codereview.webrtc.org/3005253002/diff/1/webrtc/test/call_test.cc#newc...
webrtc/test/call_test.cc:431: audio_decoder_factory_.get()));
On 2017/09/11 09:28:44, åsapersson wrote:
> audio_decoder_factory_?

Done. Not sure why I added this?

https://codereview.webrtc.org/3005253002/diff/1/webrtc/test/call_test.cc#newc...
webrtc/test/call_test.cc:441: audio_decoder_factory_.get()));
On 2017/09/11 09:28:44, åsapersson wrote:
> same here

Done.

https://codereview.webrtc.org/3005253002/diff/1/webrtc/video/DEPS
File webrtc/video/DEPS (right):

https://codereview.webrtc.org/3005253002/diff/1/webrtc/video/DEPS#newcode23
webrtc/video/DEPS:23: "+webrtc/sdk",
On 2017/09/08 12:36:39, kjellander_webrtc wrote:
> Do we need to be this strict? If webrtc/sdk is considered being fine to depend
> on (which I guess it is, or?) it should be in the list above.

Right, that makes sense. Changed.

https://codereview.webrtc.org/3005253002/diff/1/webrtc/video/full_stack_tests.cc
File webrtc/video/full_stack_tests.cc (right):

https://codereview.webrtc.org/3005253002/diff/1/webrtc/video/full_stack_tests...
webrtc/video/full_stack_tests.cc:307: char field_trial[100];
On 2017/09/11 09:28:44, åsapersson wrote:
> maybe std::string

Done.

https://codereview.webrtc.org/3005253002/diff/20001/webrtc/video/full_stack_t...
File webrtc/video/full_stack_tests.cc (right):

https://codereview.webrtc.org/3005253002/diff/20001/webrtc/video/full_stack_t...
webrtc/video/full_stack_tests.cc:590: "ConferenceMotion_1280_720_50"};
On 2017/09/12 13:08:47, sprang_webrtc wrote:
> Weird formatting. Is this clang-format's fault?

Yes :( Maybe this is a sign that we should split up
VideoQualityTest::Params::Video into sub-structs.

[brandtr, 2017-09-13 11:17:29]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-13 11:17:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[brandtr, 2017-09-13 11:28:48]

Description was changed from

==========
Add full stack tests for MediaCodec encoder.

* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate encoders using encoder factories.
* Add HW encoder factories to VideoQualityTest.
* Add full stack tests:
  - sqcif7 at 30 kbps: MediaCodec and libvpx
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx

BUG=webrtc:8219
==========

to

==========
Add full stack tests for MediaCodec encoder.

* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate encoders using encoder factories.
* Add HW encoder factories to VideoQualityTest.
* Add full stack tests:
  - sqcif7 at  30 kbps: MediaCodec and libvpx.
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx.

BUG=webrtc:8219
==========

[commit-bot: I haz the power, 2017-09-13 11:44:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-13 11:44:36]

Dry run: This issue passed the CQ dry run.

[brandtr, 2017-09-13 12:21:17]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2017-09-13 12:21:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org, kjellander@webrtc.org, sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3005253002/#ps100001 (title:
"Comment fixes and 7 fps in sqcif test instead.")

[commit-bot: I haz the power, 2017-09-13 12:21:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[brandtr, 2017-09-13 12:26:21]

brandtr@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[brandtr, 2017-09-13 12:26:22]

+solenberg for variable rename in call/

[commit-bot: I haz the power, 2017-09-13 12:27:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-13 12:27:05]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/21542)

[brandtr, 2017-09-14 13:59:29]

Rebase.

[brandtr, 2017-09-15 07:52:19]

Rebase: webrtc/ move.

[brandtr, 2017-09-21 07:26:40]

Rebase.

[stefan-webrtc, 2017-09-22 07:01:41]

stefan@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2017-09-22 07:01:42]

lgtm

[brandtr, 2017-09-22 07:02:10]

brandtr@webrtc.org changed reviewers:
- solenberg@webrtc.org

[brandtr, 2017-09-22 07:04:02]

Rebase.

[brandtr, 2017-09-22 07:05:05]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-22 07:05:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-22 07:38:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-22 07:38:43]

Dry run: This issue passed the CQ dry run.

[brandtr, 2017-09-22 07:42:10]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2017-09-22 07:42:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org, kjellander@webrtc.org, sprang@webrtc.org,
stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3005253002/#ps180001 (title:
"Rebase.")

[commit-bot: I haz the power, 2017-09-22 07:42:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-22 07:46:26]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1506066130581280,
"parent_rev": "433b11ede72a8047ad5b34d8ab522e2da07f99f8", "commit_rev":
"2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa"}

[commit-bot: I haz the power, 2017-09-22 07:46:31]

Description was changed from

==========
Add full stack tests for MediaCodec encoder.

* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate encoders using encoder factories.
* Add HW encoder factories to VideoQualityTest.
* Add full stack tests:
  - sqcif7 at  30 kbps: MediaCodec and libvpx.
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx.

BUG=webrtc:8219
==========

to

==========
Add full stack tests for MediaCodec encoder.

* Add audio_ prefix to CallTest::{en,de}coder_factory_.
* Let VideoQualityTest only instantiate encoders using encoder factories.
* Add HW encoder factories to VideoQualityTest.
* Add full stack tests:
  - sqcif7 at  30 kbps: MediaCodec and libvpx.
  - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx.

BUG=webrtc:8219

Review-Url: https://codereview.webrtc.org/3005253002
Cr-Commit-Position: refs/heads/master@{#19923}
Committed:
https://webrtc.googlesource.com/src/+/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa
==========

[commit-bot: I haz the power, 2017-09-22 07:46:32]

Committed patchset #10 (id:180001) as
https://webrtc.googlesource.com/src/+/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa

[brandtr, 2017-09-22 11:29:56]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.webrtc.org/3016593002/ by brandtr@webrtc.org.

The reason for reverting is: Breaks KitKat/Lollipop perf bots..