Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3016543002: Remove VoENetwork (Closed)

Created:
3 years, 3 months ago by the sun
Modified:
3 years, 3 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VoENetwork BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/3016543002 Cr-Commit-Position: refs/heads/master@{#19912} Committed: https://webrtc.googlesource.com/src/+/946d886187ac7e60d6c845e1e704ea4b49e78ae3

Patch Set 1 #

Patch Set 2 : remove VoiceEngineFixture #

Patch Set 3 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -505 lines) Patch
M test/mock_voice_engine.h View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M voice_engine/BUILD.gn View 1 2 3 chunks +0 lines, -6 lines 0 comments Download
M voice_engine/channel.h View 1 2 4 chunks +2 lines, -8 lines 2 comments Download
M voice_engine/channel.cc View 1 2 1 chunk +15 lines, -38 lines 0 comments Download
D voice_engine/include/voe_network.h View 1 chunk +0 lines, -95 lines 0 comments Download
D voice_engine/voe_network_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D voice_engine/voe_network_impl.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D voice_engine/voe_network_unittest.cc View 1 1 chunk +0 lines, -120 lines 0 comments Download
D voice_engine/voice_engine_fixture.h View 1 1 chunk +0 lines, -33 lines 0 comments Download
D voice_engine/voice_engine_fixture.cc View 1 1 chunk +0 lines, -32 lines 0 comments Download
M voice_engine/voice_engine_impl.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
the sun
3 years, 3 months ago (2017-09-21 09:25:39 UTC) #2
kwiberg-webrtc
lgtm, if you change or remove the TODO https://codereview.webrtc.org/3016543002/diff/40001/voice_engine/channel.h File voice_engine/channel.h (right): https://codereview.webrtc.org/3016543002/diff/40001/voice_engine/channel.h#newcode210 voice_engine/channel.h:210: // ...
3 years, 3 months ago (2017-09-21 10:33:13 UTC) #3
the sun
https://codereview.webrtc.org/3016543002/diff/40001/voice_engine/channel.h File voice_engine/channel.h (right): https://codereview.webrtc.org/3016543002/diff/40001/voice_engine/channel.h#newcode210 voice_engine/channel.h:210: // TODO(nisse, solenberg): Delete when VoENetwork is deleted. On ...
3 years, 3 months ago (2017-09-21 10:35:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3016543002/40001
3 years, 3 months ago (2017-09-21 10:36:02 UTC) #6
commit-bot: I haz the power
3 years, 3 months ago (2017-09-21 11:03:01 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://webrtc.googlesource.com/src/+/946d886187ac7e60d6c845e1e704ea4b49e78ae3

Powered by Google App Engine
This is Rietveld 408576698