Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: voice_engine/voe_network_unittest.cc

Issue 3016543002: Remove VoENetwork (Closed)
Patch Set: rebase Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: voice_engine/voe_network_unittest.cc
diff --git a/voice_engine/voe_network_unittest.cc b/voice_engine/voe_network_unittest.cc
deleted file mode 100644
index b37caf5a3c15210857dfc012591cd2d943afe3ab..0000000000000000000000000000000000000000
--- a/voice_engine/voe_network_unittest.cc
+++ /dev/null
@@ -1,120 +0,0 @@
-/*
- * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
- *
- * Use of this source code is governed by a BSD-style license
- * that can be found in the LICENSE file in the root of the source
- * tree. An additional intellectual property rights grant can be found
- * in the file PATENTS. All contributing project authors may
- * be found in the AUTHORS file in the root of the source tree.
- */
-
-#include "voice_engine/include/voe_network.h"
-
-#include "test/gtest.h"
-#include "voice_engine/include/voe_errors.h"
-#include "voice_engine/voice_engine_fixture.h"
-
-namespace webrtc {
-
-enum {
- kMinValidSizeOfRtcpPacketInBytes = 4,
- kMinValidSizeOfRtpPacketInBytes = 12,
- kMaxValidSizeOfRtpPacketInBytes = 1292
-};
-
-// A packet with a valid header for both RTP and RTCP.
-// Methods that are tested in this file are checking only packet header.
-static const uint8_t kPacket[kMinValidSizeOfRtpPacketInBytes] = {0x80};
-static const uint8_t kPacketJunk[kMinValidSizeOfRtpPacketInBytes] = {};
-
-static const int kNonExistingChannel = 1234;
-
-class VoENetworkTest : public VoiceEngineFixture {
- protected:
- int CreateChannelAndRegisterExternalTransport() {
- EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
- int channelID = base_->CreateChannel();
- EXPECT_NE(channelID, -1);
- EXPECT_EQ(0, network_->RegisterExternalTransport(channelID, transport_));
- return channelID;
- }
-};
-
-TEST_F(VoENetworkTest, RegisterAndDeRegisterExternalTransport) {
- int channelID = CreateChannelAndRegisterExternalTransport();
- EXPECT_EQ(0, network_->DeRegisterExternalTransport(channelID));
-}
-
-TEST_F(VoENetworkTest,
- RegisterExternalTransportOnNonExistingChannelShouldFail) {
- EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
- EXPECT_NE(
- 0, network_->RegisterExternalTransport(kNonExistingChannel, transport_));
-}
-
-TEST_F(VoENetworkTest,
- DeRegisterExternalTransportOnNonExistingChannelShouldFail) {
- EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
- EXPECT_NE(0, network_->DeRegisterExternalTransport(kNonExistingChannel));
-}
-
-TEST_F(VoENetworkTest, DeRegisterExternalTransportBeforeRegister) {
- EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
- int channelID = base_->CreateChannel();
- EXPECT_NE(channelID, -1);
- EXPECT_EQ(0, network_->DeRegisterExternalTransport(channelID));
-}
-
-TEST_F(VoENetworkTest, ReceivedRTPPacketWithJunkDataShouldFail) {
- int channelID = CreateChannelAndRegisterExternalTransport();
- EXPECT_EQ(-1, network_->ReceivedRTPPacket(channelID, kPacketJunk,
- sizeof(kPacketJunk)));
-}
-
-TEST_F(VoENetworkTest, ReceivedRTPPacketOnNonExistingChannelShouldFail) {
- EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
- EXPECT_EQ(-1, network_->ReceivedRTPPacket(kNonExistingChannel, kPacket,
- sizeof(kPacket)));
-}
-
-TEST_F(VoENetworkTest, ReceivedRTPPacketOnChannelWithoutTransportShouldFail) {
- EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
- int channelID = base_->CreateChannel();
- EXPECT_NE(channelID, -1);
- EXPECT_EQ(-1,
- network_->ReceivedRTPPacket(channelID, kPacket, sizeof(kPacket)));
-}
-
-TEST_F(VoENetworkTest, ReceivedTooSmallRTPPacketShouldFail) {
- int channelID = CreateChannelAndRegisterExternalTransport();
- EXPECT_EQ(-1, network_->ReceivedRTPPacket(
- channelID, kPacket, kMinValidSizeOfRtpPacketInBytes - 1));
-}
-
-TEST_F(VoENetworkTest, ReceivedTooLargeRTPPacketShouldFail) {
- int channelID = CreateChannelAndRegisterExternalTransport();
- EXPECT_EQ(-1, network_->ReceivedRTPPacket(
- channelID, kPacket, kMaxValidSizeOfRtpPacketInBytes + 1));
-}
-
-TEST_F(VoENetworkTest, ReceivedRTCPPacketOnNonExistingChannelShouldFail) {
- EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
- EXPECT_EQ(-1, network_->ReceivedRTCPPacket(kNonExistingChannel, kPacket,
- sizeof(kPacket)));
-}
-
-TEST_F(VoENetworkTest, ReceivedRTCPPacketOnChannelWithoutTransportShouldFail) {
- EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
- int channelID = base_->CreateChannel();
- EXPECT_NE(channelID, -1);
- EXPECT_EQ(-1,
- network_->ReceivedRTCPPacket(channelID, kPacket, sizeof(kPacket)));
-}
-
-TEST_F(VoENetworkTest, ReceivedTooSmallRTCPPacket4ShouldFail) {
- int channelID = CreateChannelAndRegisterExternalTransport();
- EXPECT_EQ(-1, network_->ReceivedRTCPPacket(
- channelID, kPacket, kMinValidSizeOfRtcpPacketInBytes - 1));
-}
-
-} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698