Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 3013543002: Revert of Remove typedefs.h from webrtc/ root (part 1) (Closed)

Created:
3 years, 3 months ago by kjellander_webrtc
Modified:
3 years, 3 months ago
Reviewers:
the sun, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, tlegrand-webrtc, qiang.lu, peah-webrtc, bjornv1, video-team_agora.io, AleBzk, tterriberry_mozilla.com, sdk-team_agora.io, minyue-webrtc, mflodman, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, kwiberg-webrtc, interface-changes_webrtc.org, danilchap, henrika_webrtc, audio-team_agora.io, hlundin-webrtc, niklas.enbom, aluebs-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove typedefs.h from webrtc/ root (part 1) (patchset #3 id:40001 of https://codereview.webrtc.org/3007253002/ ) Reason for revert: Breaks the Chromium WebRTC FYI bots: https://build.chromium.org/p/chromium.webrtc.fyi/builders/ios-simulator/builds/2834 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/11775 Example: FAILED: obj/third_party/libjingle_xmpp/libjingle_xmpp_unittests/xmpplogintask_unittest.obj ninja -t msvc -e environment.x86 -- E:\b\c\goma_client/gomacc.exe "e:\b\c\win_toolchain\vs_files\f53e4598951162bad6330f7a167486c7ae5db1e5\vc\bin\amd64_x86/cl.exe" /nologo /showIncludes @obj/third_party/libjingle_xmpp/libjingle_xmpp_unittests/xmpplogintask_unittest.obj.rsp /c ../../third_party/libjingle_xmpp/xmpp/xmpplogintask_unittest.cc /Foobj/third_party/libjingle_xmpp/libjingle_xmpp_unittests/xmpplogintask_unittest.obj /Fd"obj/third_party/libjingle_xmpp/libjingle_xmpp_unittests_cc.pdb" ../../third_party/libjingle_xmpp/xmpp/xmpplogintask_unittest.cc(95): error C3861: 'FALLTHROUGH': identifier not found Original issue's description: > Remove typedefs.h from webrtc/ root (part 1) > > Split out webrtc-specific #defines from typedefs.h, into rtc_base/annotations.h and rtc_base/arch.h. > Also removes the curiously named WEBRTC_CPU_DETECTION #define. > > BUG=webrtc:6854 > > Review-Url: https://codereview.webrtc.org/3007253002 > Cr-Commit-Position: refs/heads/master@{#19752} > Committed: https://chromium.googlesource.com/external/webrtc/+/a895836321e68b67ca2081c3bdbf6c08d8ee4b57 TBR=kwiberg@webrtc.org,solenberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6854 Review-Url: https://codereview.webrtc.org/3013543002 Cr-Commit-Position: refs/heads/master@{#19754} Committed: https://chromium.googlesource.com/external/webrtc/+/bdf3072f1a06c7af95420e314cac4de72b7f8248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -138 lines) Patch
M webrtc/common_audio/resampler/sinc_resampler.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/resampler/sinc_resampler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/ios/voice_processing_audio_unit.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/jitter_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/rtp_frame_reference_finder.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/rtc_base/annotations.h View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/rtc_base/arch.h View 1 chunk +0 lines, -58 lines 0 comments Download
M webrtc/rtc_base/checks.h View 3 chunks +4 lines, -12 lines 0 comments Download
M webrtc/rtc_base/checks.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/rtc_base/httpbase.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/typedefs.h View 1 chunk +107 lines, -3 lines 0 comments Download
M webrtc/video/rtp_video_stream_receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_stream_encoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kjellander_webrtc
Created Revert of Remove typedefs.h from webrtc/ root (part 1)
3 years, 3 months ago (2017-09-08 18:00:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3013543002/1
3 years, 3 months ago (2017-09-08 18:00:16 UTC) #3
commit-bot: I haz the power
3 years, 3 months ago (2017-09-08 18:00:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/bdf3072f1a06c7af95420e314...

Powered by Google App Engine
This is Rietveld 408576698