Remove typedefs.h from webrtc/ root (part 1)

Remove typedefs.h from webrtc/ root (part 1)

Split out webrtc-specific #defines from typedefs.h, into rtc_base/annotations.h and rtc_base/arch.h.
Also removes the curiously named WEBRTC_CPU_DETECTION #define.

BUG=webrtc:6854
Review-Url: https://codereview.webrtc.org/3007253002
Cr-Commit-Position: refs/heads/master@{#19752}
Committed: https://chromium.googlesource.com/external/webrtc/+/a895836321e68b67ca2081c3bdbf6c08d8ee4b57

[the sun, 2017-09-08 07:07:56]

solenberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2017-09-08 11:11:34]

https://codereview.webrtc.org/3007253002/diff/1/webrtc/rtc_base/annotations.h
File webrtc/rtc_base/annotations.h (right):

https://codereview.webrtc.org/3007253002/diff/1/webrtc/rtc_base/annotations.h...
webrtc/rtc_base/annotations.h:2: *  Copyright (c) 2017 The WebRTC project
authors. All Rights Reserved.
You said (c) 2012 in the other new file. You should probably use the same year
in both of them. I *think* the policy is to use the current year for new files
even if they contain only "old" things, but I'm not certain.

https://codereview.webrtc.org/3007253002/diff/1/webrtc/rtc_base/arch.h
File webrtc/rtc_base/arch.h (right):

https://codereview.webrtc.org/3007253002/diff/1/webrtc/rtc_base/arch.h#newcode51
webrtc/rtc_base/arch.h:51: #error Please add support for your architecture in
typedefs.h
rtc_base/arch.h

Or just don't mention the file name; the error message will point to this exact
line anyway.

[the sun, 2017-09-08 13:28:04]

https://codereview.webrtc.org/3007253002/diff/1/webrtc/rtc_base/annotations.h
File webrtc/rtc_base/annotations.h (right):

https://codereview.webrtc.org/3007253002/diff/1/webrtc/rtc_base/annotations.h...
webrtc/rtc_base/annotations.h:2: *  Copyright (c) 2017 The WebRTC project
authors. All Rights Reserved.
On 2017/09/08 11:11:34, kwiberg-webrtc wrote:
> You said (c) 2012 in the other new file. You should probably use the same year
> in both of them. I *think* the policy is to use the current year for new files
> even if they contain only "old" things, but I'm not certain.

done.

https://codereview.webrtc.org/3007253002/diff/1/webrtc/rtc_base/arch.h
File webrtc/rtc_base/arch.h (right):

https://codereview.webrtc.org/3007253002/diff/1/webrtc/rtc_base/arch.h#newcode51
webrtc/rtc_base/arch.h:51: #error Please add support for your architecture in
typedefs.h
On 2017/09/08 11:11:34, kwiberg-webrtc wrote:
> rtc_base/arch.h
> 
> Or just don't mention the file name; the error message will point to this
exact
> line anyway.

Done.

[kwiberg-webrtc, 2017-09-08 13:30:05]

lgtm

https://codereview.webrtc.org/3007253002/diff/20001/webrtc/rtc_base/checks.cc
File webrtc/rtc_base/checks.cc (right):

https://codereview.webrtc.org/3007253002/diff/20001/webrtc/rtc_base/checks.cc...
webrtc/rtc_base/checks.cc:139: RTC_NO_RETURN void rtc_FatalMessage(const char*
file, int line, const char* msg)
Did clang-format do this?

[the sun, 2017-09-08 13:34:56]

On 2017/09/08 13:30:05, kwiberg-webrtc wrote:
> lgtm
> 
> https://codereview.webrtc.org/3007253002/diff/20001/webrtc/rtc_base/checks.cc
> File webrtc/rtc_base/checks.cc (right):
> 
>
https://codereview.webrtc.org/3007253002/diff/20001/webrtc/rtc_base/checks.cc...
> webrtc/rtc_base/checks.cc:139: RTC_NO_RETURN void rtc_FatalMessage(const char*
> file, int line, const char* msg)
> Did clang-format do this?

Done.

[the sun, 2017-09-08 13:35:01]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2017-09-08 13:35:02]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3007253002/#ps40001 (title:
"git cl format on checks.cc")

[commit-bot: I haz the power, 2017-09-08 13:35:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-08 15:50:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1504877701965990,
"parent_rev": "e1198e068bdcb01dcb8799d6871018092711714e", "commit_rev":
"a895836321e68b67ca2081c3bdbf6c08d8ee4b57"}

[commit-bot: I haz the power, 2017-09-08 15:51:00]

Description was changed from

==========
Remove typedefs.h from webrtc/ root (part 1)

Split out webrtc-specific #defines from typedefs.h, into rtc_base/annotations.h
and rtc_base/arch.h.
Also removes the curiously named WEBRTC_CPU_DETECTION #define.

BUG=webrtc:6854
==========

to

==========
Remove typedefs.h from webrtc/ root (part 1)

Split out webrtc-specific #defines from typedefs.h, into rtc_base/annotations.h
and rtc_base/arch.h.
Also removes the curiously named WEBRTC_CPU_DETECTION #define.

BUG=webrtc:6854

Review-Url: https://codereview.webrtc.org/3007253002
Cr-Commit-Position: refs/heads/master@{#19752}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a895836321e68b67ca2081c3b...
==========

[commit-bot: I haz the power, 2017-09-08 15:51:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/a895836321e68b67ca2081c3b...

[kjellander_webrtc, 2017-09-08 18:00:12]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/3013543002/ by kjellander@webrtc.org.

The reason for reverting is: Breaks the Chromium WebRTC FYI bots:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/ios-simulator/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build...

Example:
FAILED:
obj/third_party/libjingle_xmpp/libjingle_xmpp_unittests/xmpplogintask_unittest.obj

ninja -t msvc -e environment.x86 -- E:\b\c\goma_client/gomacc.exe
"e:\b\c\win_toolchain\vs_files\f53e4598951162bad6330f7a167486c7ae5db1e5\vc\bin\amd64_x86/cl.exe"
/nologo /showIncludes 
@obj/third_party/libjingle_xmpp/libjingle_xmpp_unittests/xmpplogintask_unittest.obj.rsp
/c ../../third_party/libjingle_xmpp/xmpp/xmpplogintask_unittest.cc
/Foobj/third_party/libjingle_xmpp/libjingle_xmpp_unittests/xmpplogintask_unittest.obj
/Fd"obj/third_party/libjingle_xmpp/libjingle_xmpp_unittests_cc.pdb"
../../third_party/libjingle_xmpp/xmpp/xmpplogintask_unittest.cc(95): error
C3861: 'FALLTHROUGH': identifier not found

.

[the sun, 2017-09-11 11:40:57]

Description was changed from

==========
Remove typedefs.h from webrtc/ root (part 1)

Split out webrtc-specific #defines from typedefs.h, into rtc_base/annotations.h
and rtc_base/arch.h.
Also removes the curiously named WEBRTC_CPU_DETECTION #define.

BUG=webrtc:6854

Review-Url: https://codereview.webrtc.org/3007253002
Cr-Commit-Position: refs/heads/master@{#19752}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a895836321e68b67ca2081c3b...
==========

to

==========
Remove typedefs.h from webrtc/ root (part 1)

Split out webrtc-specific #defines from typedefs.h, into rtc_base/annotations.h
and rtc_base/arch.h.
Also removes the curiously named WEBRTC_CPU_DETECTION #define.

BUG=webrtc:6854

Review-Url: https://codereview.webrtc.org/3007253002
Cr-Commit-Position: refs/heads/master@{#19752}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a895836321e68b67ca2081c3b...
==========