Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 3013513002: Add SentToInputFpsRatioPercent UMA metric on send side (Closed)

Created:
3 years, 3 months ago by ilnik
Modified:
3 years, 3 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/branch-heads/62
Project:
webrtc
Visibility:
Public.

Description

Add SentToInputFpsRatioPercent UMA metric on send side New metric is a ratio between SentFramesPerSecond and InputFramesPerSecond. It's needed to measure how much of input frames are actually sent. Merge into M62. Original was reviewed here: https://codereview.webrtc.org/3010723002 BUG=webrtc:8178, chromium:762868 NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.webrtc.org/3013513002 Cr-Commit-Position: refs/branch-heads/62@{#5} Cr-Branched-From: 85e6a4ba1372f21b8648ffaad2fd19a76a8bb316-refs/heads/master@{#19592} Committed: https://chromium.googlesource.com/external/webrtc/+/7e46bc497c8b231585fdcc764605d0996b5909fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M webrtc/video/send_statistics_proxy.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
ilnik
3 years, 3 months ago (2017-09-08 10:17:44 UTC) #2
tommi
lgtm
3 years, 3 months ago (2017-09-08 11:41:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3013513002/1
3 years, 3 months ago (2017-09-08 12:26:33 UTC) #7
commit-bot: I haz the power
3 years, 3 months ago (2017-09-08 12:26:40 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7e46bc497c8b231585fdcc764...

Powered by Google App Engine
This is Rietveld 408576698