Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 3010723002: Add SentToInputFpsRatioPercent UMA metric on send side (Closed)

Created:
3 years, 3 months ago by ilnik
Modified:
3 years, 3 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add SentToInputFpsRatioPercent UMA metric on send side New metric is a ratio between SentFramesPerSecond and InputFramesPerSecond. It's needed to measure how much of input frames are actually sent. BUG=webrtc:8178 Review-Url: https://codereview.webrtc.org/3010723002 Cr-Commit-Position: refs/heads/master@{#19596} Committed: https://chromium.googlesource.com/external/webrtc/+/f4ded682e913d56bbadf14a391ff3ba37a7419f5

Patch Set 1 #

Patch Set 2 : don't report new metric if the input fps is 0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M webrtc/video/send_statistics_proxy.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ilnik
3 years, 3 months ago (2017-08-30 08:08:49 UTC) #2
sprang_webrtc
lgtm
3 years, 3 months ago (2017-08-30 09:14:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010723002/20001
3 years, 3 months ago (2017-08-30 09:28:18 UTC) #9
commit-bot: I haz the power
3 years, 3 months ago (2017-08-30 09:30:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/f4ded682e913d56bbadf14a39...

Powered by Google App Engine
This is Rietveld 408576698