Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 3013433002: Convert mac/ios TaskQueue implementation to pimpl convention. (Closed)

Created:
3 years, 3 months ago by nisse-webrtc
Modified:
3 years, 3 months ago
Reviewers:
tommi, daniela-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Convert mac/ios TaskQueue implementation to pimpl convention. BUG=webrtc:8160, webrtc:8166 Review-Url: https://codereview.webrtc.org/3013433002 Cr-Commit-Position: refs/heads/master@{#19743} Committed: https://chromium.googlesource.com/external/webrtc/+/66d07c54fef7b0ddd5418f05096757e2acc8308e

Patch Set 1 #

Patch Set 2 : Fix refcount includes. #

Patch Set 3 : Update Current method, different from other impls since it uses AutoSetCurrentQueuePtr. #

Patch Set 4 : Fix more compilation errors, and some formatting. #

Patch Set 5 : Fix for PostTaskAndReply. #

Patch Set 6 : Adding lost TaskQueue::Current method. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -84 lines) Patch
M webrtc/rtc_base/task_queue.h View 2 chunks +0 lines, -12 lines 0 comments Download
M webrtc/rtc_base/task_queue_gcd.cc View 1 2 3 4 5 4 chunks +135 lines, -72 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
nisse-webrtc
PTAL. Like for the recent windows cl (https://codereview.webrtc.org/3009133002), I haven't really tried to understand how ...
3 years, 3 months ago (2017-09-06 14:24:52 UTC) #2
tommi
lgtm assuming all tests pass (I'm not sure the mac_rel bot runs everything)
3 years, 3 months ago (2017-09-08 08:32:10 UTC) #3
daniela-webrtc
lgtm
3 years, 3 months ago (2017-09-08 09:22:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3013433002/100001
3 years, 3 months ago (2017-09-08 11:39:51 UTC) #6
commit-bot: I haz the power
3 years, 3 months ago (2017-09-08 12:12:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/66d07c54fef7b0ddd5418f050...

Powered by Google App Engine
This is Rietveld 408576698