Convert windows TaskQueue implementation to pimpl convention.

Convert windows TaskQueue implementation to pimpl convention.

BUG=webrtc:8160, webrtc:8166
Review-Url: https://codereview.webrtc.org/3009133002
Cr-Commit-Position: refs/heads/master@{#19709}
Committed: https://chromium.googlesource.com/external/webrtc/+/341c8e40b7f7202b13a4b93e225f4ec8320c9eea

[nisse-webrtc, 2017-09-05 09:40:45]

Description was changed from

==========
Convert windows TaskQueue implementation to pimpl convention.

BUG=webrtc:8160
==========

to

==========
Convert windows TaskQueue implementation to pimpl convention.

BUG=webrtc:8160,webrtc:8166
==========

[nisse-webrtc, 2017-09-05 09:42:54]

nisse@webrtc.org changed reviewers:
+ perkj@webrtc.org, tommi@webrtc.org

[nisse-webrtc, 2017-09-05 09:42:55]

PTAL. This is a simple-minded conversion, looking at task_queue_libevent.cc as a
model. I haven't tried to understand what the code actually does...

[perkj_webrtc, 2017-09-05 13:30:19]

https://codereview.webrtc.org/3009133002/diff/80001/webrtc/rtc_base/task_queu...
File webrtc/rtc_base/task_queue_win.cc (right):

https://codereview.webrtc.org/3009133002/diff/80001/webrtc/rtc_base/task_queu...
webrtc/rtc_base/task_queue_win.cc:175: void PostTask(const Closure& closure) {
This method is not used and not needed.

https://codereview.webrtc.org/3009133002/diff/80001/webrtc/rtc_base/task_queu...
webrtc/rtc_base/task_queue_win.cc:186: void RunPendingTasks();
Everything from here can be made private.

[nisse-webrtc, 2017-09-05 14:39:33]

https://codereview.webrtc.org/3009133002/diff/80001/webrtc/rtc_base/task_queu...
File webrtc/rtc_base/task_queue_win.cc (right):

https://codereview.webrtc.org/3009133002/diff/80001/webrtc/rtc_base/task_queu...
webrtc/rtc_base/task_queue_win.cc:175: void PostTask(const Closure& closure) {
On 2017/09/05 13:30:18, perkj_webrtc wrote:
> This method is not used and not needed.

It's used in TaskQueue::Impl::PostTaskAndReply, for posting a lambda.

https://codereview.webrtc.org/3009133002/diff/80001/webrtc/rtc_base/task_queu...
webrtc/rtc_base/task_queue_win.cc:186: void RunPendingTasks();
On 2017/09/05 13:30:18, perkj_webrtc wrote:
> Everything from here can be made private.

Done.

[perkj_webrtc, 2017-09-05 15:14:04]

lgtm

https://codereview.webrtc.org/3009133002/diff/80001/webrtc/rtc_base/task_queu...
File webrtc/rtc_base/task_queue_win.cc (right):

https://codereview.webrtc.org/3009133002/diff/80001/webrtc/rtc_base/task_queu...
webrtc/rtc_base/task_queue_win.cc:175: void PostTask(const Closure& closure) {
On 2017/09/05 14:39:33, nisse-webrtc wrote:
> On 2017/09/05 13:30:18, perkj_webrtc wrote:
> > This method is not used and not needed.
> 
> It's used in TaskQueue::Impl::PostTaskAndReply, for posting a lambda. 

ok

[tommi, 2017-09-06 09:37:17]

lgtm

[nisse-webrtc, 2017-09-06 11:03:00]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-09-06 11:03:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-06 11:38:23]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1504695780470320,
"parent_rev": "5301e3c3db996feb4fd622d4449f740da1064477", "commit_rev":
"341c8e40b7f7202b13a4b93e225f4ec8320c9eea"}

[commit-bot: I haz the power, 2017-09-06 11:38:27]

Description was changed from

==========
Convert windows TaskQueue implementation to pimpl convention.

BUG=webrtc:8160,webrtc:8166
==========

to

==========
Convert windows TaskQueue implementation to pimpl convention.

BUG=webrtc:8160,webrtc:8166

Review-Url: https://codereview.webrtc.org/3009133002
Cr-Commit-Position: refs/heads/master@{#19709}
Committed:
https://chromium.googlesource.com/external/webrtc/+/341c8e40b7f7202b13a4b93e2...
==========

[commit-bot: I haz the power, 2017-09-06 11:38:29]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/341c8e40b7f7202b13a4b93e2...