Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 3012853002: Update thread annotiation macros to use RTC_ prefix (Closed)

Created:
3 years, 3 months ago by danilchap
Modified:
3 years, 3 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), peah-webrtc, henrika_webrtc, zhengzhonghou_agora.io, Andrew MacDonald, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, fengyue_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, AleBzk, mflodman, audio-team_agora.io
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update thread annotiation macros to use RTC_ prefix BUG=webrtc:8198 Review-Url: https://codereview.webrtc.org/3012853002 Cr-Commit-Position: refs/heads/master@{#19760} Committed: https://chromium.googlesource.com/external/webrtc/+/a37de39216cccecb1448725b7dbd00bb69c52360

Patch Set 1 : script generated #

Patch Set 2 : Undo changes to thread_annotation/thread_checker #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -429 lines) Patch
M webrtc/api/statstypes.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_receive_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_send_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_state.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/bitrate_allocator.h View 1 chunk +12 lines, -12 lines 0 comments Download
M webrtc/call/bitrate_estimator_tests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/call/call.cc View 1 2 5 chunks +19 lines, -16 lines 0 comments Download
M webrtc/call/call_perf_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/call/rtp_stream_receiver_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_video/include/bitrate_adjuster.h View 1 chunk +10 lines, -9 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M webrtc/media/base/adaptedvideotracksource.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/videoadapter.h View 1 chunk +7 lines, -5 lines 0 comments Download
M webrtc/media/base/videobroadcaster.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/media/base/videocapturer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/media/engine/fakewebrtcvideoengine.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine.h View 4 chunks +24 lines, -23 lines 0 comments Download
M webrtc/pc/mediamonitor.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/videotrack.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/task_queue_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/rtc_tools/network_tester/packet_sender.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/rtc_tools/network_tester/test_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/system_wrappers/include/rw_lock_wrapper.h View 1 chunk +11 lines, -15 lines 0 comments Download
M webrtc/system_wrappers/source/metrics_default.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/system_wrappers/source/trace_impl.h View 2 chunks +7 lines, -7 lines 0 comments Download
M webrtc/test/direct_transport.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fake_audio_device.h View 1 chunk +7 lines, -7 lines 0 comments Download
M webrtc/test/fake_encoder.h View 4 chunks +12 lines, -12 lines 0 comments Download
M webrtc/test/frame_generator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/test/frame_generator.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/test/frame_generator_capturer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/test/single_threaded_task_queue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/test/vcm_capturer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/call_stats.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/video/encoder_rtcp_feedback.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 2 19 chunks +40 lines, -39 lines 0 comments Download
M webrtc/video/overuse_frame_detector.h View 1 chunk +15 lines, -14 lines 0 comments Download
M webrtc/video/payload_router.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/picture_id_tests.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 2 chunks +34 lines, -33 lines 0 comments Download
M webrtc/video/rtp_streams_synchronizer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/video/rtp_video_stream_receiver.h View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/video/send_delay_stats.h View 1 chunk +7 lines, -7 lines 0 comments Download
M webrtc/video/send_statistics_proxy.h View 2 chunks +12 lines, -13 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 6 chunks +34 lines, -32 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 13 chunks +28 lines, -28 lines 0 comments Download
M webrtc/video/video_stream_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_stream_encoder.h View 5 chunks +33 lines, -30 lines 0 comments Download
M webrtc/video/video_stream_encoder.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/video/video_stream_encoder_unittest.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M webrtc/voice_engine/audio_level.h View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 2 6 chunks +15 lines, -14 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M webrtc/voice_engine/shared_data.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/fakes/conference_transport.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/after_initialization_fixture.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
danilchap
Same script as before used to update the macros: #!/bin/sh MACROS=(GUARDED_BY GUARDED_VAR PT_GUARDED_BY PT_GUARDED_VAR ACQUIRED_AFTER ...
3 years, 3 months ago (2017-09-07 15:16:52 UTC) #2
kwiberg-webrtc
lgtm
3 years, 3 months ago (2017-09-09 04:30:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012853002/20001
3 years, 3 months ago (2017-09-09 10:31:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012853002/40001
3 years, 3 months ago (2017-09-09 10:42:39 UTC) #13
commit-bot: I haz the power
3 years, 3 months ago (2017-09-09 11:17:38 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/a37de39216cccecb1448725b7...

Powered by Google App Engine
This is Rietveld 408576698