Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: webrtc/video/video_send_stream_tests.cc

Issue 3012853002: Update thread annotiation macros to use RTC_ prefix (Closed)
Patch Set: Rebase Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/video_send_stream.cc ('k') | webrtc/video/video_stream_decoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_send_stream_tests.cc
diff --git a/webrtc/video/video_send_stream_tests.cc b/webrtc/video/video_send_stream_tests.cc
index ce7a0eea7d083362cc5f05a6cec1a1336583eacb..422b983ef9b431168e827b832917d18bbc9a9f0c 100644
--- a/webrtc/video/video_send_stream_tests.cc
+++ b/webrtc/video/video_send_stream_tests.cc
@@ -1223,7 +1223,7 @@ TEST_F(VideoSendStreamTest, SuspendBelowMinBitrate) {
};
virtual void SendRtcpFeedback(int remb_value)
- EXCLUSIVE_LOCKS_REQUIRED(crit_) {
+ RTC_EXCLUSIVE_LOCKS_REQUIRED(crit_) {
FakeReceiveStatistics receive_stats(kVideoSendSsrcs[0],
last_sequence_number_, rtp_count_, 0);
RTCPSender rtcp_sender(false, clock_, &receive_stats, nullptr, nullptr,
@@ -1244,12 +1244,12 @@ TEST_F(VideoSendStreamTest, SuspendBelowMinBitrate) {
VideoSendStream* stream_;
rtc::CriticalSection crit_;
- TestState test_state_ GUARDED_BY(crit_);
- int rtp_count_ GUARDED_BY(crit_);
- int last_sequence_number_ GUARDED_BY(crit_);
- int suspended_frame_count_ GUARDED_BY(crit_);
- int low_remb_bps_ GUARDED_BY(crit_);
- int high_remb_bps_ GUARDED_BY(crit_);
+ TestState test_state_ RTC_GUARDED_BY(crit_);
+ int rtp_count_ RTC_GUARDED_BY(crit_);
+ int last_sequence_number_ RTC_GUARDED_BY(crit_);
+ int suspended_frame_count_ RTC_GUARDED_BY(crit_);
+ int low_remb_bps_ RTC_GUARDED_BY(crit_);
+ int high_remb_bps_ RTC_GUARDED_BY(crit_);
} test;
RunBaseTest(&test);
@@ -1326,8 +1326,8 @@ TEST_F(VideoSendStreamTest, NoPaddingWhenVideoIsMuted) {
Clock* const clock_;
std::unique_ptr<internal::TransportAdapter> transport_adapter_;
rtc::CriticalSection crit_;
- int64_t last_packet_time_ms_ GUARDED_BY(crit_);
- test::FrameGeneratorCapturer* capturer_ GUARDED_BY(crit_);
+ int64_t last_packet_time_ms_ RTC_GUARDED_BY(crit_);
+ test::FrameGeneratorCapturer* capturer_ RTC_GUARDED_BY(crit_);
} test;
RunBaseTest(&test);
@@ -1395,8 +1395,8 @@ TEST_F(VideoSendStreamTest, PaddingIsPrimarilyRetransmissions) {
rtc::CriticalSection crit_;
Clock* const clock_;
- size_t padding_length_ GUARDED_BY(crit_);
- size_t total_length_ GUARDED_BY(crit_);
+ size_t padding_length_ RTC_GUARDED_BY(crit_);
+ size_t total_length_ RTC_GUARDED_BY(crit_);
Call* call_;
} test;
@@ -1634,7 +1634,7 @@ TEST_F(VideoSendStreamTest, ChangingTransportOverhead) {
test::SingleThreadedTaskQueueForTesting* const task_queue_;
Call* call_;
rtc::CriticalSection lock_;
- int packets_sent_ GUARDED_BY(lock_);
+ int packets_sent_ RTC_GUARDED_BY(lock_);
int transport_overhead_;
const size_t kMaxRtpPacketSize = 1000;
} test(&task_queue_);
@@ -1742,10 +1742,10 @@ class MaxPaddingSetTest : public test::SendTest {
rtc::CriticalSection crit_;
rtc::Event content_switch_event_;
Call* call_;
- VideoSendStream* send_stream_ GUARDED_BY(crit_);
+ VideoSendStream* send_stream_ RTC_GUARDED_BY(crit_);
VideoSendStream::Config send_stream_config_;
VideoEncoderConfig encoder_config_;
- uint32_t packets_sent_ GUARDED_BY(crit_);
+ uint32_t packets_sent_ RTC_GUARDED_BY(crit_);
bool running_without_padding_;
T* const stream_resetter_;
};
@@ -1833,9 +1833,9 @@ TEST_F(VideoSendStreamTest,
rtc::CriticalSection crit_;
rtc::Event init_encode_called_;
- size_t number_of_initializations_ GUARDED_BY(&crit_);
- int last_initialized_frame_width_ GUARDED_BY(&crit_);
- int last_initialized_frame_height_ GUARDED_BY(&crit_);
+ size_t number_of_initializations_ RTC_GUARDED_BY(&crit_);
+ int last_initialized_frame_width_ RTC_GUARDED_BY(&crit_);
+ int last_initialized_frame_height_ RTC_GUARDED_BY(&crit_);
};
test::NullTransport transport;
@@ -1902,7 +1902,7 @@ TEST_F(VideoSendStreamTest, CanReconfigureToUseStartBitrateAbovePreviousMax) {
private:
rtc::CriticalSection crit_;
rtc::Event start_bitrate_changed_;
- int start_bitrate_kbps_ GUARDED_BY(crit_);
+ int start_bitrate_kbps_ RTC_GUARDED_BY(crit_);
};
CreateSenderCall(Call::Config(event_log_.get()));
@@ -1992,7 +1992,7 @@ TEST_F(VideoSendStreamTest, VideoSendStreamStopSetEncoderRateToZero) {
rtc::CriticalSection crit_;
rtc::Event encoder_init_;
rtc::Event bitrate_changed_;
- rtc::Optional<int> bitrate_kbps_ GUARDED_BY(crit_);
+ rtc::Optional<int> bitrate_kbps_ RTC_GUARDED_BY(crit_);
};
test::NullTransport transport;
@@ -2244,10 +2244,10 @@ TEST_F(VideoSendStreamTest, EncoderIsProperlyInitializedAndDestroyed) {
test::SingleThreadedTaskQueueForTesting* const task_queue_;
rtc::CriticalSection crit_;
VideoSendStream* stream_;
- bool initialized_ GUARDED_BY(crit_);
- bool callback_registered_ GUARDED_BY(crit_);
- size_t num_releases_ GUARDED_BY(crit_);
- bool released_ GUARDED_BY(crit_);
+ bool initialized_ RTC_GUARDED_BY(crit_);
+ bool callback_registered_ RTC_GUARDED_BY(crit_);
+ size_t num_releases_ RTC_GUARDED_BY(crit_);
+ bool released_ RTC_GUARDED_BY(crit_);
VideoEncoderConfig encoder_config_;
} test_encoder(&task_queue_);
@@ -2557,8 +2557,8 @@ TEST_F(VideoSendStreamTest, RtcpSenderReportContainsMediaBytesSent) {
}
rtc::CriticalSection crit_;
- size_t rtp_packets_sent_ GUARDED_BY(&crit_);
- size_t media_bytes_sent_ GUARDED_BY(&crit_);
+ size_t rtp_packets_sent_ RTC_GUARDED_BY(&crit_);
+ size_t media_bytes_sent_ RTC_GUARDED_BY(&crit_);
} test;
RunBaseTest(&test);
@@ -2792,7 +2792,7 @@ TEST_F(VideoSendStreamTest, ReconfigureBitratesSetsEncoderBitratesCorrectly) {
rtc::Event init_encode_event_;
rtc::Event bitrate_changed_event_;
rtc::CriticalSection crit_;
- uint32_t target_bitrate_ GUARDED_BY(&crit_);
+ uint32_t target_bitrate_ RTC_GUARDED_BY(&crit_);
int num_initializations_;
webrtc::Call* call_;
@@ -3457,8 +3457,8 @@ TEST_F(VideoSendStreamTest, RemoveOverheadFromBandwidth) {
test::SingleThreadedTaskQueueForTesting* const task_queue_;
Call* call_;
rtc::CriticalSection crit_;
- uint32_t max_bitrate_bps_ GUARDED_BY(&crit_);
- bool first_packet_sent_ GUARDED_BY(&crit_);
+ uint32_t max_bitrate_bps_ RTC_GUARDED_BY(&crit_);
+ bool first_packet_sent_ RTC_GUARDED_BY(&crit_);
rtc::Event bitrate_changed_event_;
} test(&task_queue_);
RunBaseTest(&test);
« no previous file with comments | « webrtc/video/video_send_stream.cc ('k') | webrtc/video/video_stream_decoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698