Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread ( https://codereview.w…

Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread ( https://codereview.webrtc.org/3007473002/ )

Original issue's description:
> Revert of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (patchset #18 id:340001 of https://codereview.webrtc.org/3007473002/ )
>
> Reason for revert:
> Breaks google3 project.
>
> Original issue's description:
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread
> >
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This will eventually allow us to run multiple log sessions on a single task-queue.
> >
> > BUG=webrtc:8142, webrtc:8143, webrtc:8145
> >
> > Review-Url: https://codereview.webrtc.org/3007473002
> > Cr-Commit-Position: refs/heads/master@{#19666}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/f33cee7534f0469330b6b7aa57f84eec4b082598

TBR=terelius@webrtc.org,nisse@webrtc.org,charujain@webrtc.org
NOPRESUBMIT=true
NOTRY=True
BUG=webrtc:8142, webrtc:8143, webrtc:8145
Review-Url: https://codereview.webrtc.org/3012783002
Cr-Commit-Position: refs/heads/master@{#19712}
Committed: https://chromium.googlesource.com/external/webrtc/+/248fd4f47c073cc4b444d31c236e3d091487c565

[eladalon, 2017-09-05 15:56:13]

The CQ bit was checked by eladalon@webrtc.org

[commit-bot: I haz the power, 2017-09-05 15:56:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-05 16:21:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-05 16:21:29]

Try jobs failed on following builders:
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)

[eladalon, 2017-09-06 07:20:40]

The CQ bit was checked by eladalon@webrtc.org

[commit-bot: I haz the power, 2017-09-06 07:20:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-06 07:30:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-06 07:30:40]

Try jobs failed on following builders:
  linux_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/29410)
  win_x64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/28818)

[eladalon, 2017-09-06 09:34:28]

The CQ bit was checked by eladalon@webrtc.org

[commit-bot: I haz the power, 2017-09-06 09:34:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[nisse-webrtc, 2017-09-06 11:24:12]

lgtm, with one optional nit not really related to the reland.

https://codereview.webrtc.org/3012783002/diff/40001/webrtc/pc/peerconnectionf...
File webrtc/pc/peerconnectionfactory.cc (right):

https://codereview.webrtc.org/3012783002/diff/40001/webrtc/pc/peerconnectionf...
webrtc/pc/peerconnectionfactory.cc:336: return event_log_factory_ ?
event_log_factory_->CreateRtcEventLog()
I think it's good practice to add a DCHECK that this _w method is running on the
worker thread as expected.

[commit-bot: I haz the power, 2017-09-06 11:35:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-06 11:35:01]

Try jobs failed on following builders:
  linux_rel on master.tryserver.webrtc (JOB_TIMED_OUT, build has not started
yet; builder either lacks capacity or does not exist (misspelled?))

[eladalon, 2017-09-06 11:38:46]

https://codereview.webrtc.org/3012783002/diff/40001/webrtc/pc/peerconnectionf...
File webrtc/pc/peerconnectionfactory.cc (right):

https://codereview.webrtc.org/3012783002/diff/40001/webrtc/pc/peerconnectionf...
webrtc/pc/peerconnectionfactory.cc:336: return event_log_factory_ ?
event_log_factory_->CreateRtcEventLog()
On 2017/09/06 11:24:12, nisse-webrtc wrote:
> I think it's good practice to add a DCHECK that this _w method is running on
the
> worker thread as expected.

Good point; https://codereview.webrtc.org/3007153006 created.

[eladalon, 2017-09-06 12:17:04]

Description was changed from

==========
Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (
https://codereview.webrtc.org/3007473002/ )

Original issue's description:
> Revert of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread
(patchset #18 id:340001 of https://codereview.webrtc.org/3007473002/ )
>
> Reason for revert:
> Breaks google3 project.
>
> Original issue's description:
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread
> >
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This
will eventually allow us to run multiple log sessions on a single task-queue.
> >
> > BUG=webrtc:8142, webrtc:8143, webrtc:8145
> >
> > Review-Url: https://codereview.webrtc.org/3007473002
> > Cr-Commit-Position: refs/heads/master@{#19666}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f33cee7534f0469330b6b7aa5...

TBR=terelius@webrtc.org,nisse@webrtc.org,charujain@webrtc.org
NOPRESUBMIT=true
BUG=webrtc:8142, webrtc:8143, webrtc:8145
==========

to

==========
Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (
https://codereview.webrtc.org/3007473002/ )

Original issue's description:
> Revert of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread
(patchset #18 id:340001 of https://codereview.webrtc.org/3007473002/ )
>
> Reason for revert:
> Breaks google3 project.
>
> Original issue's description:
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread
> >
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This
will eventually allow us to run multiple log sessions on a single task-queue.
> >
> > BUG=webrtc:8142, webrtc:8143, webrtc:8145
> >
> > Review-Url: https://codereview.webrtc.org/3007473002
> > Cr-Commit-Position: refs/heads/master@{#19666}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f33cee7534f0469330b6b7aa5...

TBR=terelius@webrtc.org,nisse@webrtc.org,charujain@webrtc.org
NOPRESUBMIT=true
NOTRY=True
BUG=webrtc:8142, webrtc:8143, webrtc:8145
==========

[eladalon, 2017-09-06 12:17:53]

linux_rel had to be run manually because of some infrastructure hiccup. It
passes. I've added NOTRY and I will now land manually.

[eladalon, 2017-09-06 12:18:01]

The CQ bit was checked by eladalon@webrtc.org

[commit-bot: I haz the power, 2017-09-06 12:18:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-06 12:18:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1504700281263410,
"parent_rev": "e1ed24196b377452963f5183ed1d8f49af0cba32", "commit_rev":
"248fd4f47c073cc4b444d31c236e3d091487c565"}

[commit-bot: I haz the power, 2017-09-06 12:18:20]

Description was changed from

==========
Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (
https://codereview.webrtc.org/3007473002/ )

Original issue's description:
> Revert of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread
(patchset #18 id:340001 of https://codereview.webrtc.org/3007473002/ )
>
> Reason for revert:
> Breaks google3 project.
>
> Original issue's description:
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread
> >
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This
will eventually allow us to run multiple log sessions on a single task-queue.
> >
> > BUG=webrtc:8142, webrtc:8143, webrtc:8145
> >
> > Review-Url: https://codereview.webrtc.org/3007473002
> > Cr-Commit-Position: refs/heads/master@{#19666}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f33cee7534f0469330b6b7aa5...

TBR=terelius@webrtc.org,nisse@webrtc.org,charujain@webrtc.org
NOPRESUBMIT=true
NOTRY=True
BUG=webrtc:8142, webrtc:8143, webrtc:8145
==========

to

==========
Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (
https://codereview.webrtc.org/3007473002/ )

Original issue's description:
> Revert of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread
(patchset #18 id:340001 of https://codereview.webrtc.org/3007473002/ )
>
> Reason for revert:
> Breaks google3 project.
>
> Original issue's description:
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread
> >
> > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This
will eventually allow us to run multiple log sessions on a single task-queue.
> >
> > BUG=webrtc:8142, webrtc:8143, webrtc:8145
> >
> > Review-Url: https://codereview.webrtc.org/3007473002
> > Cr-Commit-Position: refs/heads/master@{#19666}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f33cee7534f0469330b6b7aa5...

TBR=terelius@webrtc.org,nisse@webrtc.org,charujain@webrtc.org
NOPRESUBMIT=true
NOTRY=True
BUG=webrtc:8142, webrtc:8143, webrtc:8145

Review-Url: https://codereview.webrtc.org/3012783002
Cr-Commit-Position: refs/heads/master@{#19712}
Committed:
https://chromium.googlesource.com/external/webrtc/+/248fd4f47c073cc4b444d31c2...
==========

[commit-bot: I haz the power, 2017-09-06 12:18:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/248fd4f47c073cc4b444d31c2...