Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 3012783002: Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread ( https://codereview.w… (Closed)

Created:
3 years, 3 months ago by eladalon
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread ( https://codereview.webrtc.org/3007473002/ ) Original issue's description: > Revert of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (patchset #18 id:340001 of https://codereview.webrtc.org/3007473002/ ) > > Reason for revert: > Breaks google3 project. > > Original issue's description: > > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread > > > > Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This will eventually allow us to run multiple log sessions on a single task-queue. > > > > BUG=webrtc:8142, webrtc:8143, webrtc:8145 > > > > Review-Url: https://codereview.webrtc.org/3007473002 > > Cr-Commit-Position: refs/heads/master@{#19666} > > Committed: https://chromium.googlesource.com/external/webrtc/+/f33cee7534f0469330b6b7aa57f84eec4b082598 TBR=terelius@webrtc.org,nisse@webrtc.org,charujain@webrtc.org NOPRESUBMIT=true NOTRY=True BUG=webrtc:8142, webrtc:8143, webrtc:8145 Review-Url: https://codereview.webrtc.org/3012783002 Cr-Commit-Position: refs/heads/master@{#19712} Committed: https://chromium.googlesource.com/external/webrtc/+/248fd4f47c073cc4b444d31c236e3d091487c565

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased and PeerConnection fixed. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -542 lines) Patch
M webrtc/logging/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 1 chunk +4 lines, -3 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 7 chunks +317 lines, -84 lines 0 comments Download
D webrtc/logging/rtc_event_log/rtc_event_log_helper_thread.h View 1 chunk +0 lines, -128 lines 0 comments Download
D webrtc/logging/rtc_event_log/rtc_event_log_helper_thread.cc View 1 chunk +0 lines, -315 lines 0 comments Download
M webrtc/pc/peerconnection.cc View 1 2 2 chunks +10 lines, -8 lines 0 comments Download
M webrtc/pc/peerconnectionfactory.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/pc/peerconnectionfactory.cc View 2 chunks +8 lines, -2 lines 2 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012783002/20001
3 years, 3 months ago (2017-09-05 15:56:19 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/builds/7322)
3 years, 3 months ago (2017-09-05 16:21:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012783002/20001
3 years, 3 months ago (2017-09-06 07:20:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/29410) win_x64_rel on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 3 months ago (2017-09-06 07:30:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012783002/40001
3 years, 3 months ago (2017-09-06 09:34:40 UTC) #10
nisse-webrtc
lgtm, with one optional nit not really related to the reland. https://codereview.webrtc.org/3012783002/diff/40001/webrtc/pc/peerconnectionfactory.cc File webrtc/pc/peerconnectionfactory.cc (right): ...
3 years, 3 months ago (2017-09-06 11:24:12 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel on master.tryserver.webrtc (JOB_TIMED_OUT, build has not started yet; ...
3 years, 3 months ago (2017-09-06 11:35:01 UTC) #13
eladalon
https://codereview.webrtc.org/3012783002/diff/40001/webrtc/pc/peerconnectionfactory.cc File webrtc/pc/peerconnectionfactory.cc (right): https://codereview.webrtc.org/3012783002/diff/40001/webrtc/pc/peerconnectionfactory.cc#newcode336 webrtc/pc/peerconnectionfactory.cc:336: return event_log_factory_ ? event_log_factory_->CreateRtcEventLog() On 2017/09/06 11:24:12, nisse-webrtc wrote: ...
3 years, 3 months ago (2017-09-06 11:38:46 UTC) #14
eladalon
linux_rel had to be run manually because of some infrastructure hiccup. It passes. I've added ...
3 years, 3 months ago (2017-09-06 12:17:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012783002/40001
3 years, 3 months ago (2017-09-06 12:18:10 UTC) #18
commit-bot: I haz the power
3 years, 3 months ago (2017-09-06 12:18:23 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/248fd4f47c073cc4b444d31c2...

Powered by Google App Engine
This is Rietveld 408576698