Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 3007153006: Thread-checkers for PeerConnectionFactory::worker_thread_ (Closed)

Created:
3 years, 3 months ago by eladalon
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Thread-checkers for PeerConnectionFactory::worker_thread_ Add RTC_DCHECKs that would ensure that PeerConnectionFactory::X_w() functions, intended to run on the worker_thread_, do so. BUG=None Review-Url: https://codereview.webrtc.org/3007153006 Cr-Commit-Position: refs/heads/master@{#19720} Committed: https://chromium.googlesource.com/external/webrtc/+/591753bf1a4db26f5b36ac9ddc1465f05c8e3f2c

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/pc/peerconnectionfactory.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
eladalon
PTAL
3 years, 3 months ago (2017-09-06 11:39:15 UTC) #2
nisse-webrtc
https://codereview.webrtc.org/3007153006/diff/1/webrtc/pc/peerconnectionfactory.cc File webrtc/pc/peerconnectionfactory.cc (right): https://codereview.webrtc.org/3007153006/diff/1/webrtc/pc/peerconnectionfactory.cc#newcode336 webrtc/pc/peerconnectionfactory.cc:336: RTC_DCHECK(worker_thread_->IsCurrent()); Should be RTC_DCHECK_RUN_ON(worker_thread_);, right?
3 years, 3 months ago (2017-09-06 11:56:46 UTC) #3
eladalon
https://codereview.webrtc.org/3007153006/diff/1/webrtc/pc/peerconnectionfactory.cc File webrtc/pc/peerconnectionfactory.cc (right): https://codereview.webrtc.org/3007153006/diff/1/webrtc/pc/peerconnectionfactory.cc#newcode336 webrtc/pc/peerconnectionfactory.cc:336: RTC_DCHECK(worker_thread_->IsCurrent()); On 2017/09/06 11:56:46, nisse-webrtc wrote: > Should be ...
3 years, 3 months ago (2017-09-06 12:24:27 UTC) #4
nisse-webrtc
lgtm
3 years, 3 months ago (2017-09-06 12:28:22 UTC) #5
perkj_webrtc
lgtm
3 years, 3 months ago (2017-09-06 12:46:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3007153006/20001
3 years, 3 months ago (2017-09-06 14:43:10 UTC) #8
commit-bot: I haz the power
3 years, 3 months ago (2017-09-06 19:33:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/591753bf1a4db26f5b36ac9dd...

Powered by Google App Engine
This is Rietveld 408576698