Thread-checkers for PeerConnectionFactory::worker_thread_

Thread-checkers for PeerConnectionFactory::worker_thread_

Add RTC_DCHECKs that would ensure that PeerConnectionFactory::X_w() functions, intended to run on the worker_thread_, do so.

BUG=None

Review-Url: https://codereview.webrtc.org/3007153006
Cr-Commit-Position: refs/heads/master@{#19720}
Committed: https://chromium.googlesource.com/external/webrtc/+/591753bf1a4db26f5b36ac9ddc1465f05c8e3f2c

[eladalon, 2017-09-06 11:39:14]

eladalon@webrtc.org changed reviewers:
+ nisse@webrtc.org, perkj@webrtc.org

[eladalon, 2017-09-06 11:39:15]

PTAL

[nisse-webrtc, 2017-09-06 11:56:46]

https://codereview.webrtc.org/3007153006/diff/1/webrtc/pc/peerconnectionfacto...
File webrtc/pc/peerconnectionfactory.cc (right):

https://codereview.webrtc.org/3007153006/diff/1/webrtc/pc/peerconnectionfacto...
webrtc/pc/peerconnectionfactory.cc:336: RTC_DCHECK(worker_thread_->IsCurrent());
Should be RTC_DCHECK_RUN_ON(worker_thread_);, right?

[eladalon, 2017-09-06 12:24:27]

https://codereview.webrtc.org/3007153006/diff/1/webrtc/pc/peerconnectionfacto...
File webrtc/pc/peerconnectionfactory.cc (right):

https://codereview.webrtc.org/3007153006/diff/1/webrtc/pc/peerconnectionfacto...
webrtc/pc/peerconnectionfactory.cc:336: RTC_DCHECK(worker_thread_->IsCurrent());
On 2017/09/06 11:56:46, nisse-webrtc wrote:
> Should be RTC_DCHECK_RUN_ON(worker_thread_);, right?

Done.

[nisse-webrtc, 2017-09-06 12:28:22]

lgtm

[perkj_webrtc, 2017-09-06 12:46:01]

lgtm

[eladalon, 2017-09-06 14:43:02]

The CQ bit was checked by eladalon@webrtc.org

[commit-bot: I haz the power, 2017-09-06 14:43:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-06 19:33:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1504708982443200,
"parent_rev": "50864a8f4b911cce51aec715985a929cad86c688", "commit_rev":
"591753bf1a4db26f5b36ac9ddc1465f05c8e3f2c"}

[commit-bot: I haz the power, 2017-09-06 19:33:47]

Description was changed from

==========
Thread-checkers for PeerConnectionFactory::worker_thread_

Add RTC_DCHECKs that would ensure that PeerConnectionFactory::X_w() functions,
intended to run on the worker_thread_, do so.

BUG=None
==========

to

==========
Thread-checkers for PeerConnectionFactory::worker_thread_

Add RTC_DCHECKs that would ensure that PeerConnectionFactory::X_w() functions,
intended to run on the worker_thread_, do so.

BUG=None

Review-Url: https://codereview.webrtc.org/3007153006
Cr-Commit-Position: refs/heads/master@{#19720}
Committed:
https://chromium.googlesource.com/external/webrtc/+/591753bf1a4db26f5b36ac9dd...
==========

[commit-bot: I haz the power, 2017-09-06 19:33:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/591753bf1a4db26f5b36ac9dd...