Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 3012753003: Tightening visibility and removing a public_dep. (Closed)

Created:
3 years, 3 months ago by mbonadei
Modified:
3 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Tightening visibility and removing a public_dep. This CL aligns the visibility and the dependency between the _objc and the _generic targets to the standard decided in: https://codereview.webrtc.org/3001623003. BUG=webrtc:7743 NOTRY=True Review-Url: https://codereview.webrtc.org/3012753003 Cr-Commit-Position: refs/heads/master@{#19668} Committed: https://chromium.googlesource.com/external/webrtc/+/edb8429ba3df2f359813498e63bc269fe495f3f1

Patch Set 1 #

Patch Set 2 : Fixing public_deps append #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M webrtc/modules/desktop_capture/BUILD.gn View 1 2 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
mbonadei
3 years, 3 months ago (2017-09-04 11:44:29 UTC) #3
kjellander_webrtc
lgtm It would probably be sufficient to run one bot per platform for simple changes ...
3 years, 3 months ago (2017-09-04 11:52:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012753003/20001
3 years, 3 months ago (2017-09-04 14:55:52 UTC) #8
commit-bot: I haz the power
3 years, 3 months ago (2017-09-04 14:58:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/edb8429ba3df2f359813498e6...

Powered by Google App Engine
This is Rietveld 408576698