Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: webrtc/modules/desktop_capture/BUILD.gn

Issue 3012753003: Tightening visibility and removing a public_dep. (Closed)
Patch Set: Fixing public_deps append Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/desktop_capture/BUILD.gn
diff --git a/webrtc/modules/desktop_capture/BUILD.gn b/webrtc/modules/desktop_capture/BUILD.gn
index 2f8f8bf9cacb39aa65cbe93c07fb14c568a6513e..6b7fb22eaa98121483654d19131a0492027d7a1b 100644
--- a/webrtc/modules/desktop_capture/BUILD.gn
+++ b/webrtc/modules/desktop_capture/BUILD.gn
@@ -166,30 +166,25 @@ if (rtc_include_tests) {
}
rtc_source_set("desktop_capture") {
+ public_deps = [
+ ":desktop_capture_generic",
+ ]
if (is_mac) {
- public_deps = [
- ":desktop_capture_objc",
- ]
- } else {
- public_deps = [
- ":desktop_capture_generic",
- ]
+ public_deps += [ ":desktop_capture_objc" ]
}
}
if (is_mac) {
rtc_source_set("desktop_capture_objc") {
- visibility = [ ":*" ]
+ visibility = [ ":desktop_capture" ]
sources = [
"mac/desktop_configuration.mm",
"mouse_cursor_monitor_mac.mm",
"screen_capturer_mac.mm",
"window_capturer_mac.mm",
]
- public_deps = [
- ":desktop_capture_generic",
- ]
deps = [
+ ":desktop_capture_generic",
":primitives",
"../../rtc_base:rtc_base",
"../../rtc_base:rtc_base_approved",
@@ -203,7 +198,10 @@ if (is_mac) {
}
rtc_static_library("desktop_capture_generic") {
- visibility = [ ":*" ]
+ visibility = [
+ ":desktop_capture",
+ ":desktop_capture_objc",
+ ]
sources = [
"blank_detector_desktop_capturer_wrapper.cc",
"blank_detector_desktop_capturer_wrapper.h",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698