Fix Gn Untracked headers in webrtc/modules/video_coding.

Fix Gn Untracked headers in webrtc/modules/video_coding.

Fixed following headers in this CL
===================================

src/webrtc/modules/video_coding/sequence_number_util.h
src/webrtc/modules/video_coding/codecs/interface/common_constants.h
src/webrtc/modules/video_coding/codecs/interface/mock/mock_video_codec_interface.h

src/webrtc/modules/video_coding/codecs/vp8/include/vp8_globals.h
src/webrtc/modules/video_coding/codecs/vp9/include/vp9_globals.h
src/webrtc/modules/video_coding/codecs/h264/include/h264_globals.h

src/webrtc/modules/video_coding/utility/mock/mock_frame_dropper.h

src/webrtc/modules/video_coding/test/test_util.h
src/webrtc/modules/video_coding/codecs/interface/video_error_codes.h
src/webrtc/modules/video_coding/codecs/interface/video_codec_interface.h
src/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h

Remaining:
===========
src/webrtc/modules/video_coding/include/video_codec_interface.h
src/webrtc/modules/video_coding/include/video_error_codes.h

BUG=webrtc:7620
Review-Url: https://codereview.webrtc.org/3012323002
Cr-Commit-Position: refs/heads/master@{#19886}
Committed: https://webrtc.googlesource.com/src/+/cb728ea83a93d5d8dc4dee377260de0eda8a6203

[charujain, 2017-09-14 09:07:12]

Description was changed from

==========
Fix Gn Untracked headers in webrtc/modules/video_coding.

BUG=
==========

to

==========
Fix Gn Untracked headers in webrtc/modules/video_coding.

BUG=webrtc:7620
==========

[charujain, 2017-09-14 09:16:31]

Description was changed from

==========
Fix Gn Untracked headers in webrtc/modules/video_coding.

BUG=webrtc:7620
==========

to

==========
Fix Gn Untracked headers in webrtc/modules/video_coding.

Fixed following headers in this CL
===================================

src/webrtc/modules/video_coding/sequence_number_util.h
src/webrtc/modules/video_coding/codecs/interface/common_constants.h
src/webrtc/modules/video_coding/codecs/interface/mock/mock_video_codec_interface.h

src/webrtc/modules/video_coding/codecs/vp8/include/vp8_globals.h
src/webrtc/modules/video_coding/codecs/vp9/include/vp9_globals.h
src/webrtc/modules/video_coding/codecs/h264/include/h264_globals.h

src/webrtc/modules/video_coding/utility/mock/mock_frame_dropper.h
src/webrtc/modules/video_coding/include/video_codec_interface.h
src/webrtc/modules/video_coding/include/video_error_codes.h

Remaining ones to fix inside video_coding
=========================================
src/webrtc/modules/video_coding/test/test_util.h
src/webrtc/modules/video_coding/codecs/interface/video_error_codes.h
src/webrtc/modules/video_coding/codecs/interface/video_codec_interface.h
src/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h

BUG=webrtc:7620
==========

[charujain, 2017-09-14 09:16:31]

charujain@webrtc.org changed reviewers:
+ kjellander@google.com, mbonadei@webrtc.org, phoglund@webrtc.org

[charujain, 2017-09-14 09:36:37]

Description was changed from

==========
Fix Gn Untracked headers in webrtc/modules/video_coding.

Fixed following headers in this CL
===================================

src/webrtc/modules/video_coding/sequence_number_util.h
src/webrtc/modules/video_coding/codecs/interface/common_constants.h
src/webrtc/modules/video_coding/codecs/interface/mock/mock_video_codec_interface.h

src/webrtc/modules/video_coding/codecs/vp8/include/vp8_globals.h
src/webrtc/modules/video_coding/codecs/vp9/include/vp9_globals.h
src/webrtc/modules/video_coding/codecs/h264/include/h264_globals.h

src/webrtc/modules/video_coding/utility/mock/mock_frame_dropper.h
src/webrtc/modules/video_coding/include/video_codec_interface.h
src/webrtc/modules/video_coding/include/video_error_codes.h

Remaining ones to fix inside video_coding
=========================================
src/webrtc/modules/video_coding/test/test_util.h
src/webrtc/modules/video_coding/codecs/interface/video_error_codes.h
src/webrtc/modules/video_coding/codecs/interface/video_codec_interface.h
src/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h

BUG=webrtc:7620
==========

to

==========
Fix Gn Untracked headers in webrtc/modules/video_coding.

Fixed following headers in this CL
===================================

src/webrtc/modules/video_coding/sequence_number_util.h
src/webrtc/modules/video_coding/codecs/interface/common_constants.h
src/webrtc/modules/video_coding/codecs/interface/mock/mock_video_codec_interface.h

src/webrtc/modules/video_coding/codecs/vp8/include/vp8_globals.h
src/webrtc/modules/video_coding/codecs/vp9/include/vp9_globals.h
src/webrtc/modules/video_coding/codecs/h264/include/h264_globals.h

src/webrtc/modules/video_coding/utility/mock/mock_frame_dropper.h
src/webrtc/modules/video_coding/include/video_codec_interface.h
src/webrtc/modules/video_coding/include/video_error_codes.h

src/webrtc/modules/video_coding/test/test_util.h
src/webrtc/modules/video_coding/codecs/interface/video_error_codes.h
src/webrtc/modules/video_coding/codecs/interface/video_codec_interface.h
src/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h

BUG=webrtc:7620
==========

[charujain, 2017-09-14 09:54:16]

Description was changed from

==========
Fix Gn Untracked headers in webrtc/modules/video_coding.

Fixed following headers in this CL
===================================

src/webrtc/modules/video_coding/sequence_number_util.h
src/webrtc/modules/video_coding/codecs/interface/common_constants.h
src/webrtc/modules/video_coding/codecs/interface/mock/mock_video_codec_interface.h

src/webrtc/modules/video_coding/codecs/vp8/include/vp8_globals.h
src/webrtc/modules/video_coding/codecs/vp9/include/vp9_globals.h
src/webrtc/modules/video_coding/codecs/h264/include/h264_globals.h

src/webrtc/modules/video_coding/utility/mock/mock_frame_dropper.h
src/webrtc/modules/video_coding/include/video_codec_interface.h
src/webrtc/modules/video_coding/include/video_error_codes.h

src/webrtc/modules/video_coding/test/test_util.h
src/webrtc/modules/video_coding/codecs/interface/video_error_codes.h
src/webrtc/modules/video_coding/codecs/interface/video_codec_interface.h
src/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h

BUG=webrtc:7620
==========

to

==========
Fix Gn Untracked headers in webrtc/modules/video_coding.

Fixed following headers in this CL
===================================

src/webrtc/modules/video_coding/sequence_number_util.h
src/webrtc/modules/video_coding/codecs/interface/common_constants.h
src/webrtc/modules/video_coding/codecs/interface/mock/mock_video_codec_interface.h

src/webrtc/modules/video_coding/codecs/vp8/include/vp8_globals.h
src/webrtc/modules/video_coding/codecs/vp9/include/vp9_globals.h
src/webrtc/modules/video_coding/codecs/h264/include/h264_globals.h

src/webrtc/modules/video_coding/utility/mock/mock_frame_dropper.h
src/webrtc/modules/video_coding/include/video_error_codes.h

src/webrtc/modules/video_coding/test/test_util.h
src/webrtc/modules/video_coding/codecs/interface/video_error_codes.h
src/webrtc/modules/video_coding/codecs/interface/video_codec_interface.h
src/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h

Remaining:
===========
src/webrtc/modules/video_coding/include/video_codec_interface.h


BUG=webrtc:7620
==========

[charujain, 2017-09-14 11:22:22]

Description was changed from

==========
Fix Gn Untracked headers in webrtc/modules/video_coding.

Fixed following headers in this CL
===================================

src/webrtc/modules/video_coding/sequence_number_util.h
src/webrtc/modules/video_coding/codecs/interface/common_constants.h
src/webrtc/modules/video_coding/codecs/interface/mock/mock_video_codec_interface.h

src/webrtc/modules/video_coding/codecs/vp8/include/vp8_globals.h
src/webrtc/modules/video_coding/codecs/vp9/include/vp9_globals.h
src/webrtc/modules/video_coding/codecs/h264/include/h264_globals.h

src/webrtc/modules/video_coding/utility/mock/mock_frame_dropper.h
src/webrtc/modules/video_coding/include/video_error_codes.h

src/webrtc/modules/video_coding/test/test_util.h
src/webrtc/modules/video_coding/codecs/interface/video_error_codes.h
src/webrtc/modules/video_coding/codecs/interface/video_codec_interface.h
src/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h

Remaining:
===========
src/webrtc/modules/video_coding/include/video_codec_interface.h


BUG=webrtc:7620
==========

to

==========
Fix Gn Untracked headers in webrtc/modules/video_coding.

Fixed following headers in this CL
===================================

src/webrtc/modules/video_coding/sequence_number_util.h
src/webrtc/modules/video_coding/codecs/interface/common_constants.h
src/webrtc/modules/video_coding/codecs/interface/mock/mock_video_codec_interface.h

src/webrtc/modules/video_coding/codecs/vp8/include/vp8_globals.h
src/webrtc/modules/video_coding/codecs/vp9/include/vp9_globals.h
src/webrtc/modules/video_coding/codecs/h264/include/h264_globals.h

src/webrtc/modules/video_coding/utility/mock/mock_frame_dropper.h

src/webrtc/modules/video_coding/test/test_util.h
src/webrtc/modules/video_coding/codecs/interface/video_error_codes.h
src/webrtc/modules/video_coding/codecs/interface/video_codec_interface.h
src/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h

Remaining:
===========
src/webrtc/modules/video_coding/include/video_codec_interface.h
src/webrtc/modules/video_coding/include/video_error_codes.h

BUG=webrtc:7620
==========

[charujain, 2017-09-14 13:07:27]

charujain@webrtc.org changed reviewers:
+ charujain@webrtc.org

[charujain, 2017-09-14 13:07:28]

Trybots seems be green in latest patchset. PTAL now. 

Will fix remaining header in another CL.

[phoglund, 2017-09-14 13:29:27]

Would have been nice if we could ensure the added headers stayed added, but I
suppose this is fine. We should make the presubmit check cover the case where
someone modifies a GN file and causes a .h to get orphaned; let's do that in a
separate CL.

https://codereview.webrtc.org/3012323002/diff/150001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/BUILD.gn (right):

https://codereview.webrtc.org/3012323002/diff/150001/webrtc/modules/video_cod...
webrtc/modules/video_coding/BUILD.gn:114: rtc_source_set("mock_headers_utility")
{
There's nothing "utility" about this, just call it mock_headers.

https://codereview.webrtc.org/3012323002/diff/150001/webrtc/modules/video_cod...
webrtc/modules/video_coding/BUILD.gn:127:
rtc_source_set("video_coding_headers_utility") {
codec_globals_headers?

[mbonadei, 2017-09-14 13:36:33]

On 2017/09/14 13:29:27, phoglund wrote:
> Would have been nice if we could ensure the added headers stayed added, but I
> suppose this is fine. We should make the presubmit check cover the case where
> someone modifies a GN file and causes a .h to get orphaned; let's do that in a
> separate CL.

Yeah, that is right. We have a presubmit check here:
https://chromium.googlesource.com/external/webrtc/+/master/PRESUBMIT.py#605 but
it only checks that new headers will be part of a GN target. But as you say we
are not checking that headers don't get orphaned (I forgot about this case). I
think we should add it soon in order to avoid it.

[kjellander_webrtc, 2017-09-14 16:48:41]

On 2017/09/14 13:36:33, mbonadei wrote:
> On 2017/09/14 13:29:27, phoglund wrote:
> > Would have been nice if we could ensure the added headers stayed added, but
I
> > suppose this is fine. We should make the presubmit check cover the case
where
> > someone modifies a GN file and causes a .h to get orphaned; let's do that in
a
> > separate CL.
> 
> Yeah, that is right. We have a presubmit check here:
> https://chromium.googlesource.com/external/webrtc/+/master/PRESUBMIT.py#605
but
> it only checks that new headers will be part of a GN target. But as you say we
> are not checking that headers don't get orphaned (I forgot about this case). I
> think we should add it soon in order to avoid it.

It can certainly happen that someone deletes a header from a GN target without
deleting the file, but it should be pretty rare so I'm not sure it's worth
writing a check for.

[kjellander_webrtc, 2017-09-14 16:49:56]

kjellander@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-09-14 16:49:57]

https://codereview.webrtc.org/3012323002/diff/150001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/BUILD.gn (right):

https://codereview.webrtc.org/3012323002/diff/150001/webrtc/modules/video_cod...
webrtc/modules/video_coding/BUILD.gn:114: rtc_source_set("mock_headers_utility")
{
On 2017/09/14 13:29:26, phoglund wrote:
> There's nothing "utility" about this, just call it mock_headers.

+1

https://codereview.webrtc.org/3012323002/diff/150001/webrtc/modules/video_cod...
webrtc/modules/video_coding/BUILD.gn:127:
rtc_source_set("video_coding_headers_utility") {
On 2017/09/14 13:29:26, phoglund wrote:
> codec_globals_headers?

I agree that's a better name

[charujain, 2017-09-15 09:02:29]

On 2017/09/14 16:49:57, kjellander_webrtc wrote:
>
https://codereview.webrtc.org/3012323002/diff/150001/webrtc/modules/video_cod...
> File webrtc/modules/video_coding/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/3012323002/diff/150001/webrtc/modules/video_cod...
> webrtc/modules/video_coding/BUILD.gn:114:
rtc_source_set("mock_headers_utility")
> {
> On 2017/09/14 13:29:26, phoglund wrote:
> > There's nothing "utility" about this, just call it mock_headers.
> 
> +1
> 
>
https://codereview.webrtc.org/3012323002/diff/150001/webrtc/modules/video_cod...
> webrtc/modules/video_coding/BUILD.gn:127:
> rtc_source_set("video_coding_headers_utility") {
> On 2017/09/14 13:29:26, phoglund wrote:
> > codec_globals_headers?
> 
> I agree that's a better name

Done.

[kjellander_webrtc, 2017-09-18 04:29:48]

lgtm

[charujain, 2017-09-18 08:17:49]

The CQ bit was checked by charujain@webrtc.org

[commit-bot: I haz the power, 2017-09-18 08:17:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-18 10:08:08]

CQ is committing da patch.

Bot data: {"patchset_id": 210001, "attempt_start_ts": 1505722669180570,
"parent_rev": "b63310a25690842a40b7cf31f1664d25831d0c70", "commit_rev":
"cb728ea83a93d5d8dc4dee377260de0eda8a6203"}

[commit-bot: I haz the power, 2017-09-18 10:08:11]

Description was changed from

==========
Fix Gn Untracked headers in webrtc/modules/video_coding.

Fixed following headers in this CL
===================================

src/webrtc/modules/video_coding/sequence_number_util.h
src/webrtc/modules/video_coding/codecs/interface/common_constants.h
src/webrtc/modules/video_coding/codecs/interface/mock/mock_video_codec_interface.h

src/webrtc/modules/video_coding/codecs/vp8/include/vp8_globals.h
src/webrtc/modules/video_coding/codecs/vp9/include/vp9_globals.h
src/webrtc/modules/video_coding/codecs/h264/include/h264_globals.h

src/webrtc/modules/video_coding/utility/mock/mock_frame_dropper.h

src/webrtc/modules/video_coding/test/test_util.h
src/webrtc/modules/video_coding/codecs/interface/video_error_codes.h
src/webrtc/modules/video_coding/codecs/interface/video_codec_interface.h
src/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h

Remaining:
===========
src/webrtc/modules/video_coding/include/video_codec_interface.h
src/webrtc/modules/video_coding/include/video_error_codes.h

BUG=webrtc:7620
==========

to

==========
Fix Gn Untracked headers in webrtc/modules/video_coding.

Fixed following headers in this CL
===================================

src/webrtc/modules/video_coding/sequence_number_util.h
src/webrtc/modules/video_coding/codecs/interface/common_constants.h
src/webrtc/modules/video_coding/codecs/interface/mock/mock_video_codec_interface.h

src/webrtc/modules/video_coding/codecs/vp8/include/vp8_globals.h
src/webrtc/modules/video_coding/codecs/vp9/include/vp9_globals.h
src/webrtc/modules/video_coding/codecs/h264/include/h264_globals.h

src/webrtc/modules/video_coding/utility/mock/mock_frame_dropper.h

src/webrtc/modules/video_coding/test/test_util.h
src/webrtc/modules/video_coding/codecs/interface/video_error_codes.h
src/webrtc/modules/video_coding/codecs/interface/video_codec_interface.h
src/webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h

Remaining:
===========
src/webrtc/modules/video_coding/include/video_codec_interface.h
src/webrtc/modules/video_coding/include/video_error_codes.h

BUG=webrtc:7620

Review-Url: https://codereview.webrtc.org/3012323002
Cr-Commit-Position: refs/heads/master@{#19886}
Committed:
https://webrtc.googlesource.com/src/+/cb728ea83a93d5d8dc4dee377260de0eda8a6203
==========

[commit-bot: I haz the power, 2017-09-18 10:08:12]

Committed patchset #12 (id:210001) as
https://webrtc.googlesource.com/src/+/cb728ea83a93d5d8dc4dee377260de0eda8a6203