Fix Gn Untracked headers in webrtc/modules/video_coding.

webrtc/modules/video_coding/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../../webrtc.gni")
 
@@ skipping 93 matching lines @@
     "../../rtc_base:rtc_numerics",
     "../../rtc_base:rtc_task_queue",
     "../../rtc_base:sequenced_task_checker",
     "../../system_wrappers",
     "../pacing",
     "../rtp_rtcp:rtp_rtcp",
     "../utility:utility",
   ]
 }
 
-rtc_static_library("video_coding_utility") {
+rtc_source_set("mock_headers_utility") {

[phoglund, 2017/09/14 13:29:26]

There's nothing "utility" about this, just call it mock_headers.

[kjellander_webrtc, 2017/09/14 16:49:57]

+1

+  testonly = true
   sources = [
+    "codecs/interface/mock/mock_video_codec_interface.h",
+    "include/mock/mock_video_codec_interface.h",
+  ]
+  deps = [
+    ":video_coding_utility",
+    "../..:webrtc_common",
+    "../../test:test_support",
+  ]
+}
+
+rtc_source_set("video_coding_headers_utility") {

[phoglund, 2017/09/14 13:29:26]

codec_globals_headers?

[kjellander_webrtc, 2017/09/14 16:49:57]

I agree that's a better name

+  sources = [
+    "codecs/h264/include/h264_globals.h",
+    "codecs/interface/common_constants.h",
+    "codecs/vp8/include/vp8_globals.h",
+    "codecs/vp9/include/vp9_globals.h",
+  ]
+}
+
+rtc_source_set("video_coding_utility") {
+  sources = [
+    "codecs/interface/video_codec_interface.h",
+    "codecs/interface/video_error_codes.h",
+    "sequence_number_util.h",
     "utility/default_video_bitrate_allocator.cc",
     "utility/default_video_bitrate_allocator.h",
     "utility/frame_dropper.cc",
     "utility/frame_dropper.h",
     "utility/ivf_file_writer.cc",
     "utility/ivf_file_writer.h",
     "utility/moving_average.cc",
     "utility/moving_average.h",
     "utility/quality_scaler.cc",
     "utility/quality_scaler.h",
@@ skipping 67 matching lines @@
     "codecs/i420/i420.cc",
     "codecs/i420/include/i420.h",
   ]
 
   if (!build_with_chromium && is_clang) {
     # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   deps = [
+    ":video_coding_utility",
     "../..:webrtc_common",
     "../../common_video:common_video",
     "../../rtc_base:rtc_base_approved",
     "../../system_wrappers",
   ]
 }
 
 rtc_static_library("webrtc_vp8") {
   sources = [
     "codecs/vp8/default_temporal_layers.cc",
@@ skipping 99 matching lines @@
     sources = [
       "codecs/vp8/simulcast_test_utility.h",
     ]
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
 
     deps = [
+      ":mock_headers_utility",
       ":video_coding",
       ":webrtc_vp8",
       "../../api:video_frame_api",
       "../../common_video:common_video",
       "../../rtc_base:rtc_base_approved",
       "../../test:test_support",
     ]
   }
 
   rtc_source_set("video_codecs_test_framework") {
@@ skipping 152 matching lines @@
       "jitter_buffer_unittest.cc",
       "jitter_estimator_tests.cc",
       "nack_module_unittest.cc",
       "protection_bitrate_calculator_unittest.cc",
       "receiver_unittest.cc",
       "rtp_frame_reference_finder_unittest.cc",
       "sequence_number_util_unittest.cc",
       "session_info_unittest.cc",
       "test/stream_generator.cc",
       "test/stream_generator.h",
+      "test/test_util.h",
       "timing_unittest.cc",
       "utility/default_video_bitrate_allocator_unittest.cc",
       "utility/frame_dropper_unittest.cc",
       "utility/ivf_file_writer_unittest.cc",
+      "utility/mock/mock_frame_dropper.h",
       "utility/moving_average_unittest.cc",
       "utility/quality_scaler_unittest.cc",
       "utility/simulcast_rate_allocator_unittest.cc",
       "video_codec_initializer_unittest.cc",
       "video_packet_buffer_unittest.cc",
       "video_receiver_unittest.cc",
       "video_sender_unittest.cc",
     ]
     if (rtc_libvpx_build_vp9) {
       sources += [ "codecs/vp9/vp9_screenshare_layers_unittest.cc" ]
     }
     if (rtc_use_h264) {
       sources += [ "codecs/h264/h264_encoder_impl_unittest.cc" ]
     }
     deps = [
+      ":mock_headers_utility",
       ":simulcast_test_utility",
       ":video_codecs_test_framework",
       ":video_coding",
       ":video_coding_utility",
       ":webrtc_h264",
       ":webrtc_vp8",
       ":webrtc_vp9",
       "..:module_api",
       "../..:webrtc_common",
       "../../api:video_frame_api",
@@ skipping 22 matching lines @@
     }
 
     # TODO(jschuh): bugs.webrtc.org/1348: fix this warning.
     configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 }