Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 3012253002: Reland of Delete Rtx-related methods from RTPPayloadRegistry. (Closed)

Created:
3 years, 3 months ago by nisse-webrtc
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, Andrew MacDonald, zhengzhonghou_agora.io, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, AleBzk, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Delete Rtx-related methods from RTPPayloadRegistry. (patchset #1 id:1 of https://codereview.webrtc.org/3011093002/ ) Reason for revert: The cl this change depended on has now been successfully relanded. Original issue's description: > Revert of Delete Rtx-related methods from RTPPayloadRegistry. (patchset #3 id:40001 of https://codereview.webrtc.org/3006993002/ ) > > Reason for revert: > This has to be reverted to enable reverting cl https://codereview.webrtc.org/3006063002/, which seems to have broken ulpfec. > > Original issue's description: > > Delete Rtx-related methods from RTPPayloadRegistry. > > > > Delete methods IsRtx, IsEncapsulated and RestoreOriginalPacket. > > > > BUG=webrtc:7135 > > > > Review-Url: https://codereview.webrtc.org/3006993002 > > Cr-Commit-Position: refs/heads/master@{#19739} > > Committed: https://chromium.googlesource.com/external/webrtc/+/5b4b52264132eefba10bc6880871715f9692da90 > > TBR=stefan@webrtc.org,danilchap@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7135 > > Review-Url: https://codereview.webrtc.org/3011093002 > Cr-Commit-Position: refs/heads/master@{#19742} > Committed: https://chromium.googlesource.com/external/webrtc/+/a64685325c2f8f51873b67ae8a91f94ffb19d70b TBR=stefan@webrtc.org,danilchap@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7135 Review-Url: https://codereview.webrtc.org/3012253002 Cr-Commit-Position: refs/heads/master@{#19821} Committed: https://chromium.googlesource.com/external/webrtc/+/f54573bd3b9774db6782af8de0f22242598cb974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -307 lines) Patch
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h View 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc View 15 chunks +59 lines, -113 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 3 chunks +0 lines, -60 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc View 2 chunks +0 lines, -100 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M webrtc/video/rtp_video_stream_receiver.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nisse-webrtc
Created Reland of Delete Rtx-related methods from RTPPayloadRegistry.
3 years, 3 months ago (2017-09-13 13:15:23 UTC) #1
stefan-webrtc
lgtm
3 years, 3 months ago (2017-09-13 13:43:52 UTC) #2
danilchap
lgtm
3 years, 3 months ago (2017-09-13 13:45:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012253002/1
3 years, 3 months ago (2017-09-13 13:50:06 UTC) #5
commit-bot: I haz the power
3 years, 3 months ago (2017-09-13 14:14:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/f54573bd3b9774db6782af8de...

Powered by Google App Engine
This is Rietveld 408576698